watchdog: pcwd_usb: mark expected switch fall-through
PATCH 1/1 watchdog: pcwd_usb: mark expected switch fall-through
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Notice that in this particular case I replaced "Fall" with a proper "fall through" comment, which is what GCC is expecting to find.
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- drivers/watchdog/pcwd_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/pcwd_usb.c +1 -1
@@ -456,8 +456,8 @@ static long usb_pcwd_ioctl(struct file *file, unsigned int cmd,return -EINVAL ;usb_pcwd_keepalive (usb_pcwd_device); -/* Fall */ } +/* fall through */ case WDIOC_GETTIMEOUT :return put_user (heartbeat, p);
Signature · 1 line
2.7.4
Quoted 7 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Notice that in this particular case I replaced "Fall" with a proper "fall through" comment, which is what GCC is expecting to find.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Reviewed-by Guenter Roeck <[email protected]>
Quoted 18 lines
--- drivers/watchdog/pcwd_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/watchdog/pcwd_usb.c +1
-1@@ -456,8 +456,8 @@ static long usb_pcwd_ioctl(struct file *file, unsigned int cmd,return -EINVAL ;usb_pcwd_keepalive (usb_pcwd_device); -/* Fall */ } +/* fall through */ case WDIOC_GETTIMEOUT :return put_user (heartbeat, p);