misc: mic: scif_nodeqp: use swap macro in scif_node_connect

PATCH New Gustavo A. R. Silva 1 participant 1 message Nov 3, 2017 Char and misc drivers

lore

Share & tools

lore

Gustavo A. R. Silva

author

2017-11-03 16:34 UTC #0 lore raw

PATCH 1/1 misc: mic: scif_nodeqp: use swap macro in scif_node_connect

Make use of the swap macro and remove unnecessary variable tmppayload. This makes the code easier to read and maintain.

This code was detected with the help of Coccinelle.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/misc/mic/scif/scif_nodeqp.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

drivers/misc/mic/scif/scif_nodeqp.c +1 -4

index c66ca1a..e8ce4ba 100644
@@ -467,7 +467,6 @@ static void scif_node_connect(struct scif_dev *scifdev, int dst)
 	struct list_head *pos, *tmp;
 	struct scifmsg msg;
 	int err;
-	u64 tmppayload;
 
 	if (dst < 1 || dst > scif_info.maxid)
 		return;

@@ -524,9 +523,7 @@ static void scif_node_connect(struct scif_dev *scifdev, int dst)
 	msg.src.node = dev_i->node;
 	msg.dst.node = dev_j->node;
 
-	tmppayload = msg.payload[0];
-	msg.payload[0] = msg.payload[2];
-	msg.payload[2] = tmppayload;
+	swap(msg.payload[0], msg.payload[2]);
 	msg.payload[1] = p2p_ji->ppi_da[SCIF_PPI_MMIO];
 	msg.payload[3] = p2p_ji->ppi_len[SCIF_PPI_APER] << PAGE_SHIFT;

Signature · 1 line

2.7.4