Skip to contentSkip to conversation

x86: kvm: mmu: make kvm_mmu_clear_all_pte_masks static

PATCH Applied Gimcuan Hui 3 participants 3 messages Nov 3, 2017 – Nov 13, 2017

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: kvm: mmu: make kvm_mmu_clear_all_pte_masks static

The kvm_mmu_clear_all_pte_masks interface is only used by kvm_mmu_module_init locally, and does not need to be called by other module, make it static.

This patch cleans up sparse warning:
symbol 'kvm_mmu_clear_all_pte_masks' was not declared. Should it be static?

---
 arch/x86/kvm/mmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kvm/mmu.c +1 -1
index 7a69cf053711..6b247d64926e 100644
@@ -367,7 +367,7 @@ void kvm_mmu_set_mask_ptes(u64 user_mask, u64 accessed_mask,
 }
 EXPORT_SYMBOL_GPL(kvm_mmu_set_mask_ptes);
 
-void kvm_mmu_clear_all_pte_masks(void)
+static void kvm_mmu_clear_all_pte_masks(void)
 {
 	shadow_user_mask = 0;
 	shadow_accessed_mask = 0;
Signature · 1 line
2.11.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 17 lines · Gimcuan Hui

The kvm_mmu_clear_all_pte_masks interface is only used by kvm_mmu_module_init locally, and does not need to be called by other module, make it static.

This patch cleans up sparse warning:
symbol 'kvm_mmu_clear_all_pte_masks' was not declared. Should it be static?

---
 arch/x86/kvm/mmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kvm/mmu.c +0 -0
index 7a69cf053711..6b247d64926e 100644

arch/x86/kvm/mmu.c void kvm_mmu_set_mask_ptes(u64 user_mask, u64 accessed_mask, · line 373

Quoted 8 lines
arch/x86/kvm/mmu.c +1 -1
@@ -367,7 +367,7 @@ void kvm_mmu_set_mask_ptes(u64 user_mask, u64 accessed_mask,
 }
 EXPORT_SYMBOL_GPL(kvm_mmu_set_mask_ptes);
 
-void kvm_mmu_clear_all_pte_masks(void)
+static void kvm_mmu_clear_all_pte_masks(void)
 {
 	shadow_user_mask = 0;
 	shadow_accessed_mask = 0;
Signature · 3 lines
Thanks,

David / dhildenb
maintainer Applied
#2 lore raw
In reply to Gimcuan Hui
Quoted 17 lines · Gimcuan Hui

The kvm_mmu_clear_all_pte_masks interface is only used by kvm_mmu_module_init locally, and does not need to be called by other module, make it static.

This patch cleans up sparse warning:
symbol 'kvm_mmu_clear_all_pte_masks' was not declared. Should it be static?

---
 arch/x86/kvm/mmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kvm/mmu.c +0 -0
index 7a69cf053711..6b247d64926e 100644

arch/x86/kvm/mmu.c void kvm_mmu_set_mask_ptes(u64 user_mask, u64 accessed_mask, · line 373

Quoted 8 lines
arch/x86/kvm/mmu.c +1 -1
@@ -367,7 +367,7 @@ void kvm_mmu_set_mask_ptes(u64 user_mask, u64 accessed_mask,
 }
 EXPORT_SYMBOL_GPL(kvm_mmu_set_mask_ptes);
 
-void kvm_mmu_clear_all_pte_masks(void)
+static void kvm_mmu_clear_all_pte_masks(void)
 {
 	shadow_user_mask = 0;
 	shadow_accessed_mask = 0;

Queued, thanks.

Paolo