watchdog: wdt_pci: mark expected switch fall-through
PATCH 1/1 watchdog: wdt_pci: mark expected switch fall-through
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Notice that in this particular case I replaced "Fall" with a proper "fall through" comment, which is what GCC is expecting to find.
--- drivers/watchdog/wdt_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/wdt_pci.c +1 -1
@@ -430,7 +430,7 @@ static long wdtpci_ioctl(struct file *file, unsigned int cmd,if (wdtpci_set_heartbeat (new_heartbeat))return -EINVAL ;wdtpci_ping (); -/* Fall */ +/* fall through */ case WDIOC_GETTIMEOUT :return put_user (heartbeat, p);default :
Signature · 1 line
2.7.4
Quoted 7 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Notice that in this particular case I replaced "Fall" with a proper "fall through" comment, which is what GCC is expecting to find.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Quoted 17 lines
--- drivers/watchdog/wdt_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/watchdog/wdt_pci.c +1
-1@@ -430,7 +430,7 @@ static long wdtpci_ioctl(struct file *file, unsigned int cmd,if (wdtpci_set_heartbeat (new_heartbeat))return -EINVAL ;wdtpci_ping (); -/* Fall */ +/* fall through */ case WDIOC_GETTIMEOUT :return put_user (heartbeat, p);default :
Quoting Guenter Roeck <[email protected]>:
Quoted 11 lines · Gustavo A. R. Silva
Quoted 7 lines
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Notice that in this particular case I replaced "Fall" with a proper "fall through" comment, which is what GCC is expecting to find.
Signed-off-by Gustavo A. R. Silva <[email protected]>Reviewed-by Guenter Roeck <[email protected]>
Thanks!
--
Gustavo A. R. Silva