Skip to contentSkip to conversation

manpage: update mount.cifs manpage with info about default version being mounted

PATCH In review Jeff Layton 2 participants 5 messages Nov 4, 2017 – Nov 8, 2017 3 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 manpage: update mount.cifs manpage with info about default version being mounted

From: Jeff Layton <[email protected]>

---
 mount.cifs.rst | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
mount.cifs.rst +5 -2
index 9714f795fe76..499b9a778927 100644
@@ -517,7 +517,7 @@ prefixpath=arg
 vers=arg
   SMB protocol version. Allowed values are:
 
-  - 1.0 - The classic CIFS/SMBv1 protocol. This is the default.
+  - 1.0 - The classic CIFS/SMBv1 protocol.
   - 2.0 - The SMBv2.002 protocol. This was initially introduced in
     Windows Vista Service Pack 1, and Windows Server 2008. Note that
     the initial release version of Windows Vista spoke a slightly
@@ -529,6 +529,10 @@ vers=arg
   Note too that while this option governs the protocol version used, not
   all features of each version are available.
 
+  In kernels v4.13.5 and later, the client and server negotiate a version
+  greater than or equal to ``2.1``. In kernels prior to v4.13.5, the default
+  is ``1.0``.
+
 --verbose
   Print additional debugging information for the mount. Note that this
   parameter must be specified before the ``-o`` . For example::
@@ -857,4 +861,3 @@ Steve French
 The maintainer of the Linux cifs vfs and the userspace tool mount.cifs
 is Steve French. The Linux CIFS Mailing list is the preferred place to
 ask questions regarding these programs.
-
\ No newline at end of file
Signature · 1 line
2.13.6

A message that is not in the archive (sent off-list or not yet received): 20171104205151.3507-1-jlayton-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org

#2 lore raw

2017-11-04 13:51 GMT-07:00 Jeff Layton <[email protected]>:

Quoted 21 lines

From: Jeff Layton <[email protected]>

---
 mount.cifs.rst | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
mount.cifs.rst +1 -1
index 9714f795fe76..499b9a778927 100644
@@ -517,7 +517,7 @@ prefixpath=arg
 vers=arg
   SMB protocol version. Allowed values are:
 
-  - 1.0 - The classic CIFS/SMBv1 protocol. This is the default.
+  - 1.0 - The classic CIFS/SMBv1 protocol.
   - 2.0 - The SMBv2.002 protocol. This was initially introduced in
     Windows Vista Service Pack 1, and Windows Server 2008. Note that
     the initial release version of Windows Vista spoke a slightly

mount.cifs.rst vers=arg · line 534

Quoted 6 lines
mount.cifs.rst +3 -0
@@ -529,6 +529,10 @@ vers=arg
   Note too that while this option governs the protocol version used, not
   all features of each version are available.
 
+  In kernels v4.13.5 and later, the client and server negotiate a version
+  greater than or equal to ``2.1``. In kernels prior to v4.13.5, the default
+  is ``1.0``.

Between v4.13 and v4.13.4 (included) the default is 3.0, not sure if we should be so precise here.

Quoted 13 lines
mount.cifs.rst +1 -2
+
 --verbose
   Print additional debugging information for the mount. Note that this
   parameter must be specified before the ``-o`` . For example::
@@ -857,4 +861,3 @@ Steve French
 The maintainer of the Linux cifs vfs and the userspace tool mount.cifs
 is Steve French. The Linux CIFS Mailing list is the preferred place to
 ask questions regarding these programs.
-
\ No newline at end of file
--

2.13.6

Quoted 4 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

--
Best regards,
Pavel Shilovsky

#3 lore raw
Quoted 25 lines · Pavel Shilovsky

2017-11-04 13:51 GMT-07:00 Jeff Layton <[email protected]>:

Quoted 24 lines

From: Jeff Layton <[email protected]>

---
 mount.cifs.rst | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
mount.cifs.rst +1 -1
index 9714f795fe76..499b9a778927 100644
@@ -517,7 +517,7 @@ prefixpath=arg
 vers=arg
   SMB protocol version. Allowed values are:
 
-  - 1.0 - The classic CIFS/SMBv1 protocol. This is the default.
+  - 1.0 - The classic CIFS/SMBv1 protocol.
   - 2.0 - The SMBv2.002 protocol. This was initially introduced in
     Windows Vista Service Pack 1, and Windows Server 2008. Note that
     the initial release version of Windows Vista spoke a slightly
@@ -529,6 +529,10 @@ vers=arg
   Note too that while this option governs the protocol version used, not
   all features of each version are available.
 
Quoted 7 lines

mount.cifs.rst vers=arg · line 534

Quoted 3 lines
mount.cifs.rst +3 -0
+  In kernels v4.13.5 and later, the client and server negotiate a version
+  greater than or equal to ``2.1``. In kernels prior to v4.13.5, the default
+  is ``1.0``.

Between v4.13 and v4.13.4 (included) the default is 3.0, not sure if we should be so precise here.

Grumble...the merge of that feature outside the normal merge window makes this difficult to document. How about this?

The default since v4.13.5 is for the client and server to negotiate the highest possible version greater than or equal to ``2.1``. In kernels prior to v4.13, the default was ``1.0``. For kernels between v4.13 and v4.13.5 the default is ``3.0``.

It's still awkward, but I think it's correct.

Quoted 22 lines
Quoted 13 lines
mount.cifs.rst +1 -2
+
 --verbose
   Print additional debugging information for the mount. Note that this
   parameter must be specified before the ``-o`` . For example::
@@ -857,4 +861,3 @@ Steve French
 The maintainer of the Linux cifs vfs and the userspace tool mount.cifs
 is Steve French. The Linux CIFS Mailing list is the preferred place to
 ask questions regarding these programs.
-
\ No newline at end of file
--

2.13.6

Quoted 4 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

--
Best regards,
Pavel Shilovsky

Signature · 1 line
Jeff Layton <[email protected]>

A message that is not in the archive (sent off-list or not yet received): [email protected]

Reviewed-by
#5 lore raw

2017-11-05 5:35 GMT-08:00 Jeff Layton <[email protected]>:

Quoted 37 lines · Pavel Shilovsky
Quoted 25 lines

2017-11-04 13:51 GMT-07:00 Jeff Layton <[email protected]>:

Quoted 24 lines

From: Jeff Layton <[email protected]>

---
 mount.cifs.rst | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
mount.cifs.rst +1 -1
index 9714f795fe76..499b9a778927 100644
@@ -517,7 +517,7 @@ prefixpath=arg
 vers=arg
   SMB protocol version. Allowed values are:
 
-  - 1.0 - The classic CIFS/SMBv1 protocol. This is the default.
+  - 1.0 - The classic CIFS/SMBv1 protocol.
   - 2.0 - The SMBv2.002 protocol. This was initially introduced in
     Windows Vista Service Pack 1, and Windows Server 2008. Note that
     the initial release version of Windows Vista spoke a slightly
@@ -529,6 +529,10 @@ vers=arg
   Note too that while this option governs the protocol version used, not
   all features of each version are available.
 
Quoted 7 lines

mount.cifs.rst vers=arg · line 534

Quoted 3 lines
mount.cifs.rst +3 -0
+  In kernels v4.13.5 and later, the client and server negotiate a version
+  greater than or equal to ``2.1``. In kernels prior to v4.13.5, the default
+  is ``1.0``.

Between v4.13 and v4.13.4 (included) the default is 3.0, not sure if we should be so precise here.

Grumble...the merge of that feature outside the normal merge window makes this difficult to document. How about this?

Quoted 6 lines

The default since v4.13.5 is for the client and server to negotiate the highest possible version greater than or equal to ``2.1``. In kernels prior to v4.13, the default was ``1.0``. For kernels between v4.13 and v4.13.5 the default is ``3.0``.

It's still awkward, but I think it's correct.

Looks good.

--
Best regards,
Pavel Shilovsky

A message that is not in the archive (sent off-list or not yet received): CAKywueQ+NGsmvzg6Mcn41rKFGHcyM+AXurQbKdZSMCw4JJw_mg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org