Skip to contentSkip to conversation

zlib-ng: new package

PATCH Superseded Stefan Fröberg 3 participants 4 messages Nov 3, 2017 – Nov 5, 2017

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Stefan Fröberg

author
#0 lore raw

PATCH 1/1 zlib-ng: new package

zlib-ng, SIMD optimized zlib

Signed-off-by Stefan Fr?berg <[email protected]>
---
 package/Config.in          |  1 +
 package/zlib-ng/Config.in  |  8 ++++++++
 package/zlib-ng/zlib-ng.mk | 15 +++++++++++++++
 3 files changed, 24 insertions(+)
 create mode 100644 package/zlib-ng/Config.in
 create mode 100644 package/zlib-ng/zlib-ng.mk
package/Config.in +1 -0
index dbfb288..3e2b034 100644
@@ -1003,6 +1003,7 @@ menu "Compression and decompression"
 	source "package/snappy/Config.in"
 	source "package/szip/Config.in"
 	source "package/zlib/Config.in"
+	source "package/zlib-ng/Config.in"
 endmenu
 
 menu "Crypto"
package/zlib-ng/Config.in new file +8 -0
new file mode 100644
index 0000000..06de97c
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_ZLIB_NG
+	bool "zlib-ng"
+	help
+	  zlib replacement with optimizations for
+	  "next generation" systems.
+
+	  https://github.com/Dead2/zlib-ng
+
package/zlib-ng/zlib-ng.mk new file +15 -0
new file mode 100644
index 0000000..eaa93cd
@@ -0,0 +1,15 @@
+################################################################################
+#
+# zlib-ng
+#
+################################################################################
+
+ZLIB_NG_SITE = https://github.com/Dead2/zlib-ng.git
+ZLIB_NG_SOURCE = develop.zip
+ZLIB_NG_SUBDIR = zlib-ng-develop
+ZLIB_NG_EXTRACT_CMDS = unzip $(DL_DIR)/$(ZLIB_NG_SOURCE) -d $(ZLIB_NG_DIR)
+ZLIB_NG_LICENSE = Zlib
+ZLIB_NG_LICENSE_FILES = README.md
+ZLIB_NG_INSTALL_STAGING = YES
+
+$(eval $(cmake-package))
Signature · 1 line
2.7.3
#1 lore raw

PATCH 1/1 zlib-ng: new package

Hi Stefan,

Quoted 43 lines · Stefan Fr?berg

zlib-ng, SIMD optimized zlib

Signed-off-by Stefan Fr?berg <[email protected]>
---
 package/Config.in          |  1 +
 package/zlib-ng/Config.in  |  8 ++++++++
 package/zlib-ng/zlib-ng.mk | 15 +++++++++++++++
 3 files changed, 24 insertions(+)
 create mode 100644 package/zlib-ng/Config.in
 create mode 100644 package/zlib-ng/zlib-ng.mk
package/Config.in +1 -0
index dbfb288..3e2b034 100644
@@ -1003,6 +1003,7 @@ menu "Compression and decompression"
 	source "package/snappy/Config.in"
 	source "package/szip/Config.in"
 	source "package/zlib/Config.in"
+	source "package/zlib-ng/Config.in"
 endmenu
 
 menu "Crypto"
package/zlib-ng/Config.in new file +8 -0
new file mode 100644
index 0000000..06de97c
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_ZLIB_NG
+	bool "zlib-ng"
+	help
+	  zlib replacement with optimizations for
+	  "next generation" systems.
+
+	  https://github.com/Dead2/zlib-ng
+
package/zlib-ng/zlib-ng.mk new file +0 -0
new file mode 100644
index 0000000..eaa93cd

package/zlib-ng/zlib-ng.mk line 8

Quoted 8 lines
package/zlib-ng/zlib-ng.mk new file +8 -0
@@ -0,0 +1,15 @@
+################################################################################
+#
+# zlib-ng
+#
+################################################################################
+
+ZLIB_NG_SITE = https://github.com/Dead2/zlib-ng.git
+ZLIB_NG_SOURCE = develop.zip

I guess the intention is to point to ZLIB_NG_SITE = https://github.com/Dead2/zlib-ng/archive

Otherwise it will try to download
http://github/Dead2/zlib-ng.git/develop.zip
which is incorrect.

However, this will result in a file ./dl/develop.zip, which says nothing about package or version.

I think it is better to use git:
ZLIB_NG_SITE_METHOD = git

and specify version
ZLIB_NG_VERSION = xxxxx

package/zlib-ng/zlib-ng.mk line 10

Quoted 2 lines
package/zlib-ng/zlib-ng.mk new file +2 -0
+ZLIB_NG_SUBDIR = zlib-ng-develop
+ZLIB_NG_EXTRACT_CMDS = unzip $(DL_DIR)/$(ZLIB_NG_SOURCE) -d $(ZLIB_NG_DIR)

This is affected by the comment above

package/zlib-ng/zlib-ng.mk line 12

Quoted 2 lines
package/zlib-ng/zlib-ng.mk new file +2 -0
+ZLIB_NG_LICENSE = Zlib
+ZLIB_NG_LICENSE_FILES = README.md

The license file is LICENSE.md, not README.md.

Best regards
Marcus Folkesson

author
#2 lore raw

PATCH 1/1 zlib-ng: new package

Hi Marcus

Okay, will do another patch soon.

-S-

4.11.2017, 23:23, Marcus Folkesson kirjoitti:

Quoted 82 lines

Hi Stefan,

Quoted 43 lines · Stefan Fr?berg

zlib-ng, SIMD optimized zlib

Signed-off-by Stefan Fr?berg <[email protected]>
---
  package/Config.in          |  1 +
  package/zlib-ng/Config.in  |  8 ++++++++
  package/zlib-ng/zlib-ng.mk | 15 +++++++++++++++
  3 files changed, 24 insertions(+)

create mode 100644 package/zlib-ng/Config.in
create mode 100644 package/zlib-ng/zlib-ng.mk

package/Config.in +1 -0
index dbfb288..3e2b034 100644
@@ -1003,6 +1003,7 @@ menu "Compression and decompression"
  	source "package/snappy/Config.in"
  	source "package/szip/Config.in"
  	source "package/zlib/Config.in"
+	source "package/zlib-ng/Config.in"
  endmenu
 
  menu "Crypto"
package/zlib-ng/Config.in new file +8 -0
new file mode 100644
index 0000000..06de97c
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_ZLIB_NG
+	bool "zlib-ng"
+	help
+	  zlib replacement with optimizations for
+	  "next generation" systems.
+
+	  https://github.com/Dead2/zlib-ng
+
package/zlib-ng/zlib-ng.mk new file +0 -0
new file mode 100644
index 0000000..eaa93cd

package/zlib-ng/zlib-ng.mk line 8

Quoted 8 lines
package/zlib-ng/zlib-ng.mk new file +8 -0
@@ -0,0 +1,15 @@
+################################################################################
+#
+# zlib-ng
+#
+################################################################################
+
+ZLIB_NG_SITE = https://github.com/Dead2/zlib-ng.git
+ZLIB_NG_SOURCE = develop.zip

I guess the intention is to point to ZLIB_NG_SITE = https://github.com/Dead2/zlib-ng/archive

Otherwise it will try to download
http://github/Dead2/zlib-ng.git/develop.zip
which is incorrect.

However, this will result in a file ./dl/develop.zip, which says nothing about package or version.

I think it is better to use git:
ZLIB_NG_SITE_METHOD = git

and specify version
ZLIB_NG_VERSION = xxxxx

package/zlib-ng/zlib-ng.mk line 10

Quoted 2 lines
package/zlib-ng/zlib-ng.mk new file +2 -0
+ZLIB_NG_SUBDIR = zlib-ng-develop
+ZLIB_NG_EXTRACT_CMDS = unzip $(DL_DIR)/$(ZLIB_NG_SOURCE) -d $(ZLIB_NG_DIR)

This is affected by the comment above

package/zlib-ng/zlib-ng.mk line 12

Quoted 2 lines
package/zlib-ng/zlib-ng.mk new file +2 -0
+ZLIB_NG_LICENSE = Zlib
+ZLIB_NG_LICENSE_FILES = README.md

The license file is LICENSE.md, not README.md.

Best regards
Marcus Folkesson

#3 lore raw

PATCH 1/1 zlib-ng: new package

In reply to Marcus Folkesson
Quoted 3 lines · Marcus Folkesson

Hi Stefan,

On Fri, Nov 03, 2017 at 06:34:11AM +0000, Stefan Fr?berg wrote:

[snip]

Quoted 10 lines

package/zlib-ng/zlib-ng.mk line 8

Quoted 2 lines
package/zlib-ng/zlib-ng.mk new file +2 -0
+ZLIB_NG_SITE = https://github.com/Dead2/zlib-ng.git
+ZLIB_NG_SOURCE = develop.zip

I guess the intention is to point to ZLIB_NG_SITE = https://github.com/Dead2/zlib-ng/archive

Otherwise it will try to download
http://github/Dead2/zlib-ng.git/develop.zip
which is incorrect.

Quoted 5 lines

However, this will result in a file ./dl/develop.zip, which says nothing about package or version.

I think it is better to use git:
ZLIB_NG_SITE_METHOD = git

No, use the github helper [1]. And don't download the zip file, download the
tarball. And add a hash file. Make sure the hash file contains a hash for the license file as well.

Regards,
Arnout

[1] https://buildroot.org/downloads/manual/manual.html#github-download-url

Quoted 23 lines

and specify version
ZLIB_NG_VERSION = xxxxx

package/zlib-ng/zlib-ng.mk line 10

Quoted 2 lines
package/zlib-ng/zlib-ng.mk new file +2 -0
+ZLIB_NG_SUBDIR = zlib-ng-develop
+ZLIB_NG_EXTRACT_CMDS = unzip $(DL_DIR)/$(ZLIB_NG_SOURCE) -d $(ZLIB_NG_DIR)

This is affected by the comment above

package/zlib-ng/zlib-ng.mk line 12

Quoted 2 lines
package/zlib-ng/zlib-ng.mk new file +2 -0
+ZLIB_NG_LICENSE = Zlib
+ZLIB_NG_LICENSE_FILES = README.md

The license file is LICENSE.md, not README.md.

Best regards
Marcus Folkesson
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF