watchdog: watchdog_dev: mark expected switch fall-through
PATCH 1/1 watchdog: watchdog_dev: mark expected switch fall-through
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Notice that in this particular case I replaced "Fall" with a proper "fall through" comment, which is what GCC is expecting to find.
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- drivers/watchdog/watchdog_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/watchdog_dev.c +1 -1
@@ -720,7 +720,7 @@ static long watchdog_ioctl(struct file *file, unsigned int cmd, err =watchdog_ping (wdd);if (err <0 )break ; -/* Fall */ +/* fall through */ case WDIOC_GETTIMEOUT :/* timeout == 0 means that we don't know the timeout */ if (wdd->timeout ==0 ) {
Signature · 1 line
2.7.4
Quoted 7 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Notice that in this particular case I replaced "Fall" with a proper "fall through" comment, which is what GCC is expecting to find.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Reviewed-by Guenter Roeck <[email protected]>
Quoted 17 lines
--- drivers/watchdog/watchdog_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/watchdog/watchdog_dev.c +1
-1@@ -720,7 +720,7 @@ static long watchdog_ioctl(struct file *file, unsigned int cmd, err =watchdog_ping (wdd);if (err <0 )break ; -/* Fall */ +/* fall through */ case WDIOC_GETTIMEOUT :/* timeout == 0 means that we don't know the timeout */ if (wdd->timeout ==0 ) {