Skip to contentSkip to conversation

suport/download: force svn to be non-interactive

PATCH New Yann E. MORIN 5 participants 11 messages Nov 3, 2017 – Nov 26, 2017

lore
Share & tools
lore

Yann E. MORIN

author
#0 lore raw

PATCH 1/1 suport/download: force svn to be non-interactive

Fixes:

    http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Andr? Hentschel <[email protected]>
---
 support/download/svn | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
support/download/svn +1 -1
index 77abf3d02d..9f27d71f86 100755
@@ -33,6 +33,6 @@ _svn() {
     eval ${SVN} "${@}"
 }
 
-_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
+_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
 
 tar czf "${output}" "${basename}"
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 suport/download: force svn to be non-interactive

Am 03.11.2017 um 22:22 schrieb Yann E. MORIN:

Quoted 16 lines

Fixes:

    http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Andr? Hentschel <[email protected]>
---
 support/download/svn | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
support/download/svn +0 -0
index 77abf3d02d..9f27d71f86 100755

support/download/svn _svn() { · line 38

Quoted 7 lines
support/download/svn +1 -1
@@ -33,6 +33,6 @@ _svn() {
     eval ${SVN} "${@}"
 }
 
-_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
+_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
 
 tar czf "${output}" "${basename}"
Signed-off-by Andr? Hentschel <[email protected]>
#2 lore raw

PATCH 1/1 suport/download: force svn to be non-interactive

Quoted 19 lines · Andr? Hentschel

Am 03.11.2017 um 22:22 schrieb Yann E. MORIN:

Quoted 18 lines

Fixes:

    http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Andr? Hentschel <[email protected]>
---
 support/download/svn | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
support/download/svn +0 -0
index 77abf3d02d..9f27d71f86 100755
@@ -33,6 +33,6 @@ _svn() {
     eval ${SVN} "${@}"
 }
Quoted 8 lines

support/download/svn _svn() { · line 38

Quoted 5 lines
support/download/svn +1 -1
-_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
+_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
 
 tar czf "${output}" "${basename}"
Signed-off-by Andr? Hentschel <[email protected]>

Signed-off-by is only relevant when you propagate a patch (create one or resend
someone else's). The Signed-off-by is a short way for you to assert that you are entitled to contribute the patch under buildroot's GPL license. See
http://elinux.org/Developer_Certificate_Of_Origin for more details.

I guess you meant either Tested-by, Reviewed-by or Acked-by. Note that those
three get picked up by patchwork, will be part of the git log, and will be reported in the release announcement.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
author
#3 lore raw

PATCH 1/1 suport/download: force svn to be non-interactive

In reply to André Hentschel

Andr?, All,

On 2017-11-05 15:46 +0100, Andr? Hentschel spake thusly:

Quoted 19 lines

Am 03.11.2017 um 22:22 schrieb Yann E. MORIN:

Quoted 18 lines

Fixes:

    http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Andr? Hentschel <[email protected]>
---
 support/download/svn | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
support/download/svn +0 -0
index 77abf3d02d..9f27d71f86 100755
@@ -33,6 +33,6 @@ _svn() {
     eval ${SVN} "${@}"
 }
Quoted 7 lines

support/download/svn _svn() { · line 38

Quoted 5 lines
support/download/svn +1 -1
-_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
+_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
 
 tar czf "${output}" "${basename}"
Signed-off-by Andr? Hentschel <[email protected]>

Did you mean "Tested-by" or "Reviewed-by" instead?

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#4 lore raw

PATCH 1/1 suport/download: force svn to be non-interactive

In reply to André Hentschel

Hello,

Quoted 19 lines · Andr? Hentschel

Am 03.11.2017 um 22:22 schrieb Yann E. MORIN:

Quoted 18 lines

Fixes:

    http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Andr? Hentschel <[email protected]>
---
 support/download/svn | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
support/download/svn +0 -0
index 77abf3d02d..9f27d71f86 100755
@@ -33,6 +33,6 @@ _svn() {
     eval ${SVN} "${@}"
 }
Quoted 8 lines

support/download/svn _svn() { · line 38

Quoted 5 lines
support/download/svn +1 -1
-_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
+_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
 
 tar czf "${output}" "${basename}"
Signed-off-by Andr? Hentschel <[email protected]>

Such a Signed-off-by doesn't make sense, because you're not passing the code to someone else. You probably wanted to give one (or several) of the following:

- Reviewed-by:
- Tested-by:
- Acked-by:

See the manual for the detailed definition of those tags.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#5 lore raw

PATCH 1/1 suport/download: force svn to be non-interactive

In reply to Yann E. MORIN

Am 03.11.2017 um 22:22 schrieb Yann E. MORIN:

Quoted 16 lines

Fixes:

    http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Andr? Hentschel <[email protected]>
---
 support/download/svn | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
support/download/svn +0 -0
index 77abf3d02d..9f27d71f86 100755

support/download/svn _svn() { · line 38

Quoted 7 lines
support/download/svn +1 -1
@@ -33,6 +33,6 @@ _svn() {
     eval ${SVN} "${@}"
 }
 
-_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
+_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
 
 tar czf "${output}" "${basename}"
Reviewed-by Andr? Hentschel <[email protected]>
#6 lore raw

PATCH 1/1 suport/download: force svn to be non-interactive

Quoted 19 lines · Andr? Hentschel

Am 03.11.2017 um 22:22 schrieb Yann E. MORIN:

Quoted 18 lines

Fixes:

    http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Andr? Hentschel <[email protected]>
---
 support/download/svn | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
support/download/svn +0 -0
index 77abf3d02d..9f27d71f86 100755
@@ -33,6 +33,6 @@ _svn() {
     eval ${SVN} "${@}"
 }
Quoted 8 lines

support/download/svn _svn() { · line 38

Quoted 5 lines
support/download/svn +1 -1
-_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
+_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
 
 tar czf "${output}" "${basename}"
Reviewed-by Andr? Hentschel <[email protected]>

Thanks! Sorry that Thomas, Yann and I gave you the same message three times.
Race conditions, difficult to avoid :-)

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
author
#7 lore raw

PATCH 1/1 suport/download: force svn to be non-interactive

All,

On 2017-11-05 17:34 +0100, Arnout Vandecappelle spake thusly:

Quoted 23 lines · Andr? Hentschel
Quoted 22 lines

Am 03.11.2017 um 22:22 schrieb Yann E. MORIN:

Quoted 21 lines

Fixes:

    http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Andr? Hentschel <[email protected]>
---
 support/download/svn | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
support/download/svn +1 -1
index 77abf3d02d..9f27d71f86 100755
@@ -33,6 +33,6 @@ _svn() {
     eval ${SVN} "${@}"
 }
 
-_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
+_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
Quoted 8 lines
Quoted 5 lines

support/download/svn _svn() { · line 38

Quoted 2 lines
support/download/svn +0 -0
 tar czf "${output}" "${basename}"
Reviewed-by Andr? Hentschel <[email protected]>

Thanks! Sorry that Thomas, Yann and I gave you the same message three times.
Race conditions, difficult to avoid :-)

lock(buildroot.mailing_list)

Yeah I found it pretty funny in retrospect. A bit like the other discussion about BR2_REPRODUCIBLE where I basically repeated Thomas and Peter's words, when I should have just read the entire thread before replying.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
author
#8 lore raw

PATCH 1/1 suport/download: force svn to be non-interactive

On 2017-11-05 17:40 +0100, Yann E. MORIN spake thusly:

Quoted 35 lines

All,

On 2017-11-05 17:34 +0100, Arnout Vandecappelle spake thusly:

Quoted 23 lines · Andr? Hentschel
Quoted 22 lines

Am 03.11.2017 um 22:22 schrieb Yann E. MORIN:

Quoted 21 lines

Fixes:

    http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Andr? Hentschel <[email protected]>
---
 support/download/svn | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
support/download/svn +1 -1
index 77abf3d02d..9f27d71f86 100755
@@ -33,6 +33,6 @@ _svn() {
     eval ${SVN} "${@}"
 }
 
-_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
+_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
Quoted 8 lines
Quoted 5 lines

support/download/svn _svn() { · line 38

Quoted 2 lines
support/download/svn +0 -0
 tar czf "${output}" "${basename}"
Reviewed-by Andr? Hentschel <[email protected]>

Thanks! Sorry that Thomas, Yann and I gave you the same message three times.
Race conditions, difficult to avoid :-)

Quoted 6 lines

lock(buildroot.mailing_list)

Yeah I found it pretty funny in retrospect. A bit like the other discussion about BR2_REPRODUCIBLE where I basically repeated Thomas and Peter's words, when I should have just read the entire thread before replying.

Aha! got y'all stuck!

unlock(buildroot.mailing_list)

There, fixed. ;]

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#9 lore raw

PATCH 1/1 suport/download: force svn to be non-interactive

In reply to Yann E. MORIN
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Fixes:

    http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Andr? Hentschel <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#10 lore raw

PATCH 1/1 suport/download: force svn to be non-interactive

In reply to Yann E. MORIN
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Fixes:

    http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Andr? Hentschel <[email protected]>

Committed to 2017.02.x and 2017.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard