Skip to contentSkip to conversation

sysctl: add register_sysctl() dummy helper

PATCH Applied Arnd Bergmann 4 participants 7 messages Nov 6, 2017 – Nov 7, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sysctl: add register_sysctl() dummy helper

The register_sysctl() function has been around for five years with commit fea478d4101a ("sysctl: Add register_sysctl for normal sysctl users") but now that arm64 started using it, I ran into a compile error:

arch/arm64/kernel/armv8_deprecated.c: In function 'register_insn_emulation_sysctl':
arch/arm64/kernel/armv8_deprecated.c:257:2: error: implicit declaration of function 'register_sysctl'

This adds a inline function like we already have for register_sysctl_paths() and register_sysctl_table().

Fixes 38b9aeb32fa7 ("arm64: Port deprecated instruction emulation to new sysctl interface")

---
This should probably get merged through the arm64 tree to avoid bisection problems.

---
 include/linux/sysctl.h | 5 +++++
 1 file changed, 5 insertions(+)
include/linux/sysctl.h +5 -0
index fabe15e51c56..992bc9948232 100644
@@ -216,6 +216,11 @@ static inline struct ctl_table_header *register_sysctl_paths(
 	return NULL;
 }
 
+static inline struct ctl_table_header *register_sysctl(const char *path, struct ctl_table *table)
+{
+	return NULL;
+}
+
 static inline void unregister_sysctl_table(struct ctl_table_header * table)
 {
 }
Signature · 1 line
2.9.0
#1 lore raw
Quoted 6 lines · Arnd Bergmann

The register_sysctl() function has been around for five years with commit fea478d4101a ("sysctl: Add register_sysctl for normal sysctl users") but now that arm64 started using it, I ran into a compile error:

arch/arm64/kernel/armv8_deprecated.c: In function 'register_insn_emulation_sysctl':
arch/arm64/kernel/armv8_deprecated.c:257:2: error: implicit declaration of function 'register_sysctl'

Hmmm, looks like I missed this combination in testing.

I wonder whether ARMV8_DEPRECATED without SYSCTL is really a good idea
though: in that config, we build a lot of dead code and leak some memory today. The default emulation is still potentially useful, but all the support for runtime twiddling of the emulation modes becomes useless.

For parallel reasons, the SVE sysctl stuff is protected by #ifdef CONFIG_SYSCTL, which is why I didn't get a similar splat there.

So, although this patch is superficially sensible, it may tend to hide
bugs: code that calls register_sysctl() when CONFIG_SYSCTL=n is suspicious and probably needs review... no?

Cheers
---Dave

Quoted 30 lines

This adds a inline function like we already have for register_sysctl_paths() and register_sysctl_table().

Fixes 38b9aeb32fa7 ("arm64: Port deprecated instruction emulation to new sysctl interface")

---
This should probably get merged through the arm64 tree to avoid bisection problems.

---
 include/linux/sysctl.h | 5 +++++
 1 file changed, 5 insertions(+)
include/linux/sysctl.h +5 -0
index fabe15e51c56..992bc9948232 100644
@@ -216,6 +216,11 @@ static inline struct ctl_table_header *register_sysctl_paths(
 	return NULL;
 }
 
+static inline struct ctl_table_header *register_sysctl(const char *path, struct ctl_table *table)
+{
+	return NULL;
+}
+
 static inline void unregister_sysctl_table(struct ctl_table_header * table)
 {
 }
Signature · 1 line
2.9.0
#2 lore raw
Quoted 16 lines · Dave Martin
Quoted 6 lines · Arnd Bergmann

The register_sysctl() function has been around for five years with commit fea478d4101a ("sysctl: Add register_sysctl for normal sysctl users") but now that arm64 started using it, I ran into a compile error:

arch/arm64/kernel/armv8_deprecated.c: In function 'register_insn_emulation_sysctl':
arch/arm64/kernel/armv8_deprecated.c:257:2: error: implicit declaration of function 'register_sysctl'

Hmmm, looks like I missed this combination in testing.

I wonder whether ARMV8_DEPRECATED without SYSCTL is really a good idea
though: in that config, we build a lot of dead code and leak some memory today. The default emulation is still potentially useful, but all the support for runtime twiddling of the emulation modes becomes useless.

Quoted 7 lines

For parallel reasons, the SVE sysctl stuff is protected by #ifdef CONFIG_SYSCTL, which is why I didn't get a similar splat there.

So, although this patch is superficially sensible, it may tend to hide
bugs: code that calls register_sysctl() when CONFIG_SYSCTL=n is suspicious and probably needs review... no?

I think your analysis for this code is correct, we waste a lot of memory if we do it like this. However in the general case where we register a statically allocated 'struct ctl_table', it wouldn't be an issue, because gcc could then eliminate all the dead code.

Adding a CONFIG_SYSCTL #ifdef or Kconfig dependency would probably be reasonable for armv8_deprecated.c, for the rest of the kernel, having that wrapper is probably better.

I don't really care how this gets fixed, as long as some solution gets merged.

Arnd

Reviewed-by
#3 lore raw
Quoted 30 lines · Arnd Bergmann
Quoted 16 lines · Dave Martin
Quoted 6 lines · Arnd Bergmann

The register_sysctl() function has been around for five years with commit fea478d4101a ("sysctl: Add register_sysctl for normal sysctl users") but now that arm64 started using it, I ran into a compile error:

arch/arm64/kernel/armv8_deprecated.c: In function 'register_insn_emulation_sysctl':
arch/arm64/kernel/armv8_deprecated.c:257:2: error: implicit declaration of function 'register_sysctl'

Hmmm, looks like I missed this combination in testing.

I wonder whether ARMV8_DEPRECATED without SYSCTL is really a good idea
though: in that config, we build a lot of dead code and leak some memory today. The default emulation is still potentially useful, but all the support for runtime twiddling of the emulation modes becomes useless.

Quoted 7 lines

For parallel reasons, the SVE sysctl stuff is protected by #ifdef CONFIG_SYSCTL, which is why I didn't get a similar splat there.

So, although this patch is superficially sensible, it may tend to hide
bugs: code that calls register_sysctl() when CONFIG_SYSCTL=n is suspicious and probably needs review... no?

I think your analysis for this code is correct, we waste a lot of memory if we do it like this. However in the general case where we register a statically allocated 'struct ctl_table', it wouldn't be an issue, because gcc could then eliminate all the dead code.

Quoted 6 lines

Adding a CONFIG_SYSCTL #ifdef or Kconfig dependency would probably be reasonable for armv8_deprecated.c, for the rest of the kernel, having that wrapper is probably better.

I don't really care how this gets fixed, as long as some solution gets merged.

Well, since your patch makes things more consistent, I'm happy to

The armv8_deprecated code looks suspicious in any case, so I'll propose a fix for that separately -- adding a Kconfig dependency seems simplest.

Cheers
---Dave

#4 lore raw
Quoted 38 lines · Dave Martin
Quoted 30 lines · Arnd Bergmann
Quoted 16 lines · Dave Martin
Quoted 6 lines · Arnd Bergmann

The register_sysctl() function has been around for five years with commit fea478d4101a ("sysctl: Add register_sysctl for normal sysctl users") but now that arm64 started using it, I ran into a compile error:

arch/arm64/kernel/armv8_deprecated.c: In function 'register_insn_emulation_sysctl':
arch/arm64/kernel/armv8_deprecated.c:257:2: error: implicit declaration of function 'register_sysctl'

Hmmm, looks like I missed this combination in testing.

I wonder whether ARMV8_DEPRECATED without SYSCTL is really a good idea
though: in that config, we build a lot of dead code and leak some memory today. The default emulation is still potentially useful, but all the support for runtime twiddling of the emulation modes becomes useless.

Quoted 7 lines

For parallel reasons, the SVE sysctl stuff is protected by #ifdef CONFIG_SYSCTL, which is why I didn't get a similar splat there.

So, although this patch is superficially sensible, it may tend to hide
bugs: code that calls register_sysctl() when CONFIG_SYSCTL=n is suspicious and probably needs review... no?

I think your analysis for this code is correct, we waste a lot of memory if we do it like this. However in the general case where we register a statically allocated 'struct ctl_table', it wouldn't be an issue, because gcc could then eliminate all the dead code.

Quoted 6 lines

Adding a CONFIG_SYSCTL #ifdef or Kconfig dependency would probably be reasonable for armv8_deprecated.c, for the rest of the kernel, having that wrapper is probably better.

I don't really care how this gets fixed, as long as some solution gets merged.

Quoted 7 lines

Well, since your patch makes things more consistent, I'm happy to

The armv8_deprecated code looks suspicious in any case, so I'll propose a fix for that separately -- adding a Kconfig dependency seems simplest.

Thanks, your other patch looks good too (replied with an Ack there).

Andrew, can you pick up my patch into -mm then? It seems we still want it anyway, but there is no longer a dependency with the arm64 tree, so no reason to pick merge it there.

Arnd

Acked-by on v1 1/1
#5 lore raw
In reply to Arnd Bergmann
Quoted 7 lines · Arnd Bergmann

The register_sysctl() function has been around for five years with commit fea478d4101a ("sysctl: Add register_sysctl for normal sysctl users") but now that arm64 started using it, I ran into a compile error:

arch/arm64/kernel/armv8_deprecated.c: In function 'register_insn_emulation_sysctl':
arch/arm64/kernel/armv8_deprecated.c:257:2: error: implicit declaration of function 'register_sysctl'

Quoted 8 lines

This adds a inline function like we already have for register_sysctl_paths() and register_sysctl_table().

Fixes 38b9aeb32fa7 ("arm64: Port deprecated instruction emulation to new sysctl interface")

---
This should probably get merged through the arm64 tree to avoid bisection problems.

Sure, that sounds fine.

Thanks!

-Kees

Quoted 23 lines
---
 include/linux/sysctl.h | 5 +++++
 1 file changed, 5 insertions(+)
include/linux/sysctl.h +5 -1
index fabe15e51c56..992bc9948232 100644
@@ -216,6 +216,11 @@ static inline struct ctl_table_header *register_sysctl_paths(
        return NULL;
 }
 
+static inline struct ctl_table_header *register_sysctl(const char *path, struct ctl_table *table)
+{
+       return NULL;
+}
+
 static inline void unregister_sysctl_table(struct ctl_table_header * table)
 {
 }
--

2.9.0

Signature · 2 lines
Kees Cook
Pixel Security
Acked-by on v1 1/1
#6 lore raw
In reply to Arnd Bergmann
Quoted 10 lines · Arnd Bergmann

The register_sysctl() function has been around for five years with commit fea478d4101a ("sysctl: Add register_sysctl for normal sysctl users") but now that arm64 started using it, I ran into a compile error:

arch/arm64/kernel/armv8_deprecated.c: In function 'register_insn_emulation_sysctl':
arch/arm64/kernel/armv8_deprecated.c:257:2: error: implicit declaration of function 'register_sysctl'

This adds a inline function like we already have for register_sysctl_paths() and register_sysctl_table().

Quoted 8 lines
Fixes 38b9aeb32fa7 ("arm64: Port deprecated instruction emulation to new sysctl interface")

---
This should probably get merged through the arm64 tree to avoid bisection problems.

---
 include/linux/sysctl.h | 5 +++++
 1 file changed, 5 insertions(+)

Assuming Andrew can pick this up, so:

Will

Quoted 19 lines
include/linux/sysctl.h +5 -0
index fabe15e51c56..992bc9948232 100644
@@ -216,6 +216,11 @@ static inline struct ctl_table_header *register_sysctl_paths(
 	return NULL;
 }
 
+static inline struct ctl_table_header *register_sysctl(const char *path, struct ctl_table *table)
+{
+	return NULL;
+}
+
 static inline void unregister_sysctl_table(struct ctl_table_header * table)
 {
 }
Signature · 1 line
2.9.0