Skip to contentSkip to conversation

amdgpu/dc: fix non-ansi function decls.

PATCH In review Dave Airlie 4 participants 5 messages Nov 6, 2017 – Nov 7, 2017 2 messages not in the archive

Subsystems (3)
DRM drivers Radeon and amdgpu DRM drivers AMD display core
lore
Share & tools
lore

Dave Airlie

author
#0 lore raw

PATCH 1/1 amdgpu/dc: fix non-ansi function decls.

From: Dave Airlie <[email protected]>

smatch reported:
drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce80/command_table_helper_dce80.c:351:71: warning: non-ANSI function declaration of function 'dal_cmd_tbl_helper_dce80_get_table' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce110/command_table_helper_dce110.c:361:72: warning: non-ANSI function declaration of function 'dal_cmd_tbl_helper_dce110_get_table' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce112/command_table_helper_dce112.c:415:72: warning: non-ANSI function declaration of function 'dal_cmd_tbl_helper_dce112_get_table' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce112/command_table_helper2_dce112.c:415:73: warning: non-ANSI function declaration of function 'dal_cmd_tbl_helper_dce112_get_table2' drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_surface.c:148:34: warning: non-ANSI function declaration of function 'dc_create_gamma' drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_surface.c:178:50: warning: non-ANSI function declaration of function 'dc_create_transfer_func'

This fixes them.

Signed-off-by Dave Airlie <[email protected]>
---
 .../gpu/drm/amd/display/dc/bios/dce110/command_table_helper_dce110.c  | 2 +-
 .../gpu/drm/amd/display/dc/bios/dce112/command_table_helper2_dce112.c | 2 +-
 .../gpu/drm/amd/display/dc/bios/dce112/command_table_helper_dce112.c  | 2 +-
 .../gpu/drm/amd/display/dc/bios/dce80/command_table_helper_dce80.c    | 2 +-
 drivers/gpu/drm/amd/display/dc/core/dc_surface.c                      | 4 ++--
 5 files changed, 6 insertions(+), 6 deletions(-)
drivers/gpu/drm/amd/display/dc/bios/dce110/command_table_helper_dce110.c +1 -1
index 8049320..ca24154 100644
@@ -358,7 +358,7 @@ static const struct command_table_helper command_table_helper_funcs = {
  * const struct command_table_helper **h - [out] struct of functions
  *
  */
-const struct command_table_helper *dal_cmd_tbl_helper_dce110_get_table()
+const struct command_table_helper *dal_cmd_tbl_helper_dce110_get_table(void)
 {
 	return &command_table_helper_funcs;
 }
drivers/gpu/drm/amd/display/dc/bios/dce112/command_table_helper2_dce112.c +1 -1
index d342cde..0237ae5 100644
@@ -412,7 +412,7 @@ static const struct command_table_helper command_table_helper_funcs = {
  * const struct command_table_helper **h - [out] struct of functions
  *
  */
-const struct command_table_helper *dal_cmd_tbl_helper_dce112_get_table2()
+const struct command_table_helper *dal_cmd_tbl_helper_dce112_get_table2(void)
 {
 	return &command_table_helper_funcs;
 }
drivers/gpu/drm/amd/display/dc/bios/dce112/command_table_helper_dce112.c +1 -1
index 48e5996..452034f 100644
@@ -412,7 +412,7 @@ static const struct command_table_helper command_table_helper_funcs = {
  * const struct command_table_helper **h - [out] struct of functions
  *
  */
-const struct command_table_helper *dal_cmd_tbl_helper_dce112_get_table()
+const struct command_table_helper *dal_cmd_tbl_helper_dce112_get_table(void)
 {
 	return &command_table_helper_funcs;
 }
drivers/gpu/drm/amd/display/dc/bios/dce80/command_table_helper_dce80.c +1 -1
index 295e16e..8b30b55 100644
@@ -348,7 +348,7 @@ static const struct command_table_helper command_table_helper_funcs = {
 		dal_cmd_table_helper_encoder_mode_bp_to_atom,
 };
 
-const struct command_table_helper *dal_cmd_tbl_helper_dce80_get_table()
+const struct command_table_helper *dal_cmd_tbl_helper_dce80_get_table(void)
 {
 	return &command_table_helper_funcs;
 }
drivers/gpu/drm/amd/display/dc/core/dc_surface.c +2 -2
index 5aa2270..ade5b8e 100644
@@ -145,7 +145,7 @@ void dc_gamma_release(struct dc_gamma **gamma)
 	*gamma = NULL;
 }
 
-struct dc_gamma *dc_create_gamma()
+struct dc_gamma *dc_create_gamma(void)
 {
 	struct dc_gamma *gamma = kzalloc(sizeof(*gamma), GFP_KERNEL);
 

@@ -175,7 +175,7 @@ void dc_transfer_func_release(struct dc_transfer_func *tf)
 	kref_put(&tf->refcount, dc_transfer_func_free);
 }
 
-struct dc_transfer_func *dc_create_transfer_func()
+struct dc_transfer_func *dc_create_transfer_func(void)
 {
 	struct dc_transfer_func *tf = kzalloc(sizeof(*tf), GFP_KERNEL);
Signature · 6 lines
2.9.5

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20171106191712.19535-1-airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

#2 lore raw

Am 06.11.2017 um 20:17 schrieb Dave Airlie:

Quoted 26 lines

From: Dave Airlie <[email protected]>

smatch reported:
drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce80/command_table_helper_dce80.c:351:71: warning: non-ANSI function declaration of function 'dal_cmd_tbl_helper_dce80_get_table' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce110/command_table_helper_dce110.c:361:72: warning: non-ANSI function declaration of function 'dal_cmd_tbl_helper_dce110_get_table' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce112/command_table_helper_dce112.c:415:72: warning: non-ANSI function declaration of function 'dal_cmd_tbl_helper_dce112_get_table' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce112/command_table_helper2_dce112.c:415:73: warning: non-ANSI function declaration of function 'dal_cmd_tbl_helper_dce112_get_table2' drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_surface.c:148:34: warning: non-ANSI function declaration of function 'dc_create_gamma' drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_surface.c:178:50: warning: non-ANSI function declaration of function 'dc_create_transfer_func'

This fixes them.

Signed-off-by Dave Airlie <[email protected]>
---
  .../gpu/drm/amd/display/dc/bios/dce110/command_table_helper_dce110.c  | 2 +-
  .../gpu/drm/amd/display/dc/bios/dce112/command_table_helper2_dce112.c | 2 +-
  .../gpu/drm/amd/display/dc/bios/dce112/command_table_helper_dce112.c  | 2 +-
  .../gpu/drm/amd/display/dc/bios/dce80/command_table_helper_dce80.c    | 2 +-
  drivers/gpu/drm/amd/display/dc/core/dc_surface.c                      | 4 ++--
  5 files changed, 6 insertions(+), 6 deletions(-)
drivers/gpu/drm/amd/display/dc/bios/dce110/command_table_helper_dce110.c +0 -0
index 8049320..ca24154 100644

drivers/gpu/drm/amd/display/dc/bios/dce110/command_table_helper_dce110.c static const struct command_table_helper command_table_helper_funcs = { · line 364

Quoted 8 lines
drivers/gpu/drm/amd/display/dc/bios/dce110/command_table_helper_dce110.c +1 -1
@@ -358,7 +358,7 @@ static const struct command_table_helper command_table_helper_funcs = {
   * const struct command_table_helper **h - [out] struct of functions
   *
   */
-const struct command_table_helper *dal_cmd_tbl_helper_dce110_get_table()
+const struct command_table_helper *dal_cmd_tbl_helper_dce110_get_table(void)
  {
  	return &command_table_helper_funcs;
  }

BTW may I ask what those accessors functions are good for? That looks just like a LOC increase to me.

Why not export the command_table_helper_funcs directly?

Regards,
Christian.

Quoted 53 lines
drivers/gpu/drm/amd/display/dc/bios/dce112/command_table_helper2_dce112.c +1 -1
index d342cde..0237ae5 100644
@@ -412,7 +412,7 @@ static const struct command_table_helper command_table_helper_funcs = {
   * const struct command_table_helper **h - [out] struct of functions
   *
   */
-const struct command_table_helper *dal_cmd_tbl_helper_dce112_get_table2()
+const struct command_table_helper *dal_cmd_tbl_helper_dce112_get_table2(void)
  {
  	return &command_table_helper_funcs;
  }
drivers/gpu/drm/amd/display/dc/bios/dce112/command_table_helper_dce112.c +1 -1
index 48e5996..452034f 100644
@@ -412,7 +412,7 @@ static const struct command_table_helper command_table_helper_funcs = {
   * const struct command_table_helper **h - [out] struct of functions
   *
   */
-const struct command_table_helper *dal_cmd_tbl_helper_dce112_get_table()
+const struct command_table_helper *dal_cmd_tbl_helper_dce112_get_table(void)
  {
  	return &command_table_helper_funcs;
  }
drivers/gpu/drm/amd/display/dc/bios/dce80/command_table_helper_dce80.c +1 -1
index 295e16e..8b30b55 100644
@@ -348,7 +348,7 @@ static const struct command_table_helper command_table_helper_funcs = {
  		dal_cmd_table_helper_encoder_mode_bp_to_atom,
  };
 
-const struct command_table_helper *dal_cmd_tbl_helper_dce80_get_table()
+const struct command_table_helper *dal_cmd_tbl_helper_dce80_get_table(void)
  {
  	return &command_table_helper_funcs;
  }
drivers/gpu/drm/amd/display/dc/core/dc_surface.c +1 -1
index 5aa2270..ade5b8e 100644
@@ -145,7 +145,7 @@ void dc_gamma_release(struct dc_gamma **gamma)
  	*gamma = NULL;
  }
 
-struct dc_gamma *dc_create_gamma()
+struct dc_gamma *dc_create_gamma(void)
  {
  	struct dc_gamma *gamma = kzalloc(sizeof(*gamma), GFP_KERNEL);

drivers/gpu/drm/amd/display/dc/core/dc_surface.c void dc_transfer_func_release(struct dc_transfer_func *tf) · line 181

Quoted 8 lines
drivers/gpu/drm/amd/display/dc/core/dc_surface.c +1 -1
@@ -175,7 +175,7 @@ void dc_transfer_func_release(struct dc_transfer_func *tf)
  	kref_put(&tf->refcount, dc_transfer_func_free);
  }
 
-struct dc_transfer_func *dc_create_transfer_func()
+struct dc_transfer_func *dc_create_transfer_func(void)
  {
  	struct dc_transfer_func *tf = kzalloc(sizeof(*tf), GFP_KERNEL);

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): f0d1452f-7854-2f1c-2953-d10ba074c8e7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

#4 lore raw
Quoted 44 lines · Christian König

Am 06.11.2017 um 20:17 schrieb Dave Airlie:

Quoted 37 lines

From: Dave Airlie <[email protected]>

smatch reported:
drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce80/command_table_helper_dce80.c:351:71: warning: non-ANSI function declaration of function 'dal_cmd_tbl_helper_dce80_get_table' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce110/command_table_helper_dce110.c:361:72: warning: non-ANSI function declaration of function 'dal_cmd_tbl_helper_dce110_get_table' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce112/command_table_helper_dce112.c:415:72: warning: non-ANSI function declaration of function 'dal_cmd_tbl_helper_dce112_get_table' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce112/command_table_helper2_dce112.c:415:73: warning: non-ANSI function declaration of function 'dal_cmd_tbl_helper_dce112_get_table2' drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_surface.c:148:34: warning: non-ANSI function declaration of function 'dc_create_gamma' drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_surface.c:178:50: warning: non-ANSI function declaration of function 'dc_create_transfer_func'

This fixes them.

Signed-off-by Dave Airlie <[email protected]>

---
.../gpu/drm/amd/display/dc/bios/dce110/command_table_helper_dce110.c | 2 +- .../gpu/drm/amd/display/dc/bios/dce112/command_table_helper2_dce112.c | 2 +- .../gpu/drm/amd/display/dc/bios/dce112/command_table_helper_dce112.c | 2 +- .../gpu/drm/amd/display/dc/bios/dce80/command_table_helper_dce80.c | 2 +- drivers/gpu/drm/amd/display/dc/core/dc_surface.c | 4 ++--

  5 files changed, 6 insertions(+), 6 deletions(-)
drivers/gpu/drm/amd/display/dc/bios/dce110/command_table_helper_dce110.c +0 -0

index 8049320..ca24154 100644
---
a/drivers/gpu/drm/amd/display/dc/bios/dce110/command_table_helper_dce110.c
+++
b/drivers/gpu/drm/amd/display/dc/bios/dce110/command_table_helper_dce110.c

drivers/gpu/drm/amd/display/dc/bios/dce110/command_table_helper_dce110.c +1 -1
@@ -358,7 +358,7 @@ static const struct command_table_helper 
 command_table_helper_funcs = {
   * const struct command_table_helper **h - [out] struct of functions
   *
   */
-const struct command_table_helper 
 *dal_cmd_tbl_helper_dce110_get_table()
+const struct command_table_helper 
 *dal_cmd_tbl_helper_dce110_get_table(void)
Quoted 3 lines
  {
      return &command_table_helper_funcs;
  }

BTW may I ask what those accessors functions are good for? That looks just like a LOC increase to me.

Quoted 1 line

Why not export the command_table_helper_funcs directly?

The command_table_helper_funcs struct is ASIC specific, so some of it's functions are statically defined inside ASIC specific file, but as far as I can see the call site for the wrappers dal_bios_parser_init_cmd_tbl_helper/dal_bios_parser_init_cmd_tbl_helper2, always call them explicitly and not as a function pointer so it's should be possible to expose them to bypass the wrapper. Another option is to get rid of the switch case and call them through a function pointer.

Thanks,
Andrey

Quoted 76 lines

Regards,
Christian.

Quoted 72 lines
drivers/gpu/drm/amd/display/dc/bios/dce112/command_table_helper2_dce112.c +0 -0

index d342cde..0237ae5 100644
---
a/drivers/gpu/drm/amd/display/dc/bios/dce112/command_table_helper2_dce112.c
+++
b/drivers/gpu/drm/amd/display/dc/bios/dce112/command_table_helper2_dce112.c

drivers/gpu/drm/amd/display/dc/bios/dce112/command_table_helper2_dce112.c +1 -1
@@ -412,7 +412,7 @@ static const struct command_table_helper 
 command_table_helper_funcs = {
   * const struct command_table_helper **h - [out] struct of functions
   *
   */
-const struct command_table_helper 
 *dal_cmd_tbl_helper_dce112_get_table2()
+const struct command_table_helper 
 *dal_cmd_tbl_helper_dce112_get_table2(void)

  {
      return &command_table_helper_funcs;
  }
drivers/gpu/drm/amd/display/dc/bios/dce112/command_table_helper_dce112.c +0 -0

index 48e5996..452034f 100644
---
a/drivers/gpu/drm/amd/display/dc/bios/dce112/command_table_helper_dce112.c
+++
b/drivers/gpu/drm/amd/display/dc/bios/dce112/command_table_helper_dce112.c

drivers/gpu/drm/amd/display/dc/bios/dce112/command_table_helper_dce112.c +1 -1
@@ -412,7 +412,7 @@ static const struct command_table_helper 
 command_table_helper_funcs = {
   * const struct command_table_helper **h - [out] struct of functions
   *
   */
-const struct command_table_helper 
 *dal_cmd_tbl_helper_dce112_get_table()
+const struct command_table_helper 
 *dal_cmd_tbl_helper_dce112_get_table(void)

  {
      return &command_table_helper_funcs;
  }
drivers/gpu/drm/amd/display/dc/bios/dce80/command_table_helper_dce80.c +0 -1
index 295e16e..8b30b55 100644
---

a/drivers/gpu/drm/amd/display/dc/bios/dce80/command_table_helper_dce80.c
+++
b/drivers/gpu/drm/amd/display/dc/bios/dce80/command_table_helper_dce80.c

drivers/gpu/drm/amd/display/dc/bios/dce80/command_table_helper_dce80.c +1 -0
@@ -348,7 +348,7 @@ static const struct command_table_helper 
 command_table_helper_funcs = {
          dal_cmd_table_helper_encoder_mode_bp_to_atom,
  };
  -const struct command_table_helper 
 *dal_cmd_tbl_helper_dce80_get_table()
+const struct command_table_helper 
 *dal_cmd_tbl_helper_dce80_get_table(void)
  {
      return &command_table_helper_funcs;
  }
drivers/gpu/drm/amd/display/dc/core/dc_surface.c +1 -0
index 5aa2270..ade5b8e 100644
@@ -145,7 +145,7 @@ void dc_gamma_release(struct dc_gamma **gamma)
      *gamma = NULL;
  }
  -struct dc_gamma *dc_create_gamma()
+struct dc_gamma *dc_create_gamma(void)
  {
      struct dc_gamma *gamma = kzalloc(sizeof(*gamma), GFP_KERNEL);
  @@ -175,7 +175,7 @@ void dc_transfer_func_release(struct

dc_transfer_func *tf)

      kref_put(&tf->refcount, dc_transfer_func_free);

}
-struct dc_transfer_func *dc_create_transfer_func()
+struct dc_transfer_func *dc_create_transfer_func(void)

Quoted 8 lines
Quoted 2 lines
  {
      struct dc_transfer_func *tf = kzalloc(sizeof(*tf), GFP_KERNEL);

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#5 lore raw
In reply to a message not in the archive
Quoted 38 lines · Christian König

Am 06.11.2017 um 20:17 schrieb Dave Airlie:

Quoted 26 lines

From: Dave Airlie <[email protected]>

smatch reported:
drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce80/command_table_helper_dce80.c:351:71: warning: non-ANSI function declaration of function 'dal_cmd_tbl_helper_dce80_get_table' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce110/command_table_helper_dce110.c:361:72: warning: non-ANSI function declaration of function 'dal_cmd_tbl_helper_dce110_get_table' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce112/command_table_helper_dce112.c:415:72: warning: non-ANSI function declaration of function 'dal_cmd_tbl_helper_dce112_get_table' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce112/command_table_helper2_dce112.c:415:73: warning: non-ANSI function declaration of function 'dal_cmd_tbl_helper_dce112_get_table2' drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_surface.c:148:34: warning: non-ANSI function declaration of function 'dc_create_gamma' drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_surface.c:178:50: warning: non-ANSI function declaration of function 'dc_create_transfer_func'

This fixes them.

Signed-off-by Dave Airlie <[email protected]>

---
  .../gpu/drm/amd/display/dc/bios/dce110/command_table_helper_dce110.c  | 2 +- .../gpu/drm/amd/display/dc/bios/dce112/command_table_helper2_dce112.c | 2 +- .../gpu/drm/amd/display/dc/bios/dce112/command_table_helper_dce112.c  | 2 +- .../gpu/drm/amd/display/dc/bios/dce80/command_table_helper_dce80.c    | 2 +- drivers/gpu/drm/amd/display/dc/core/dc_surface.c                      | 4 ++--

  5 files changed, 6 insertions(+), 6 deletions(-)
drivers/gpu/drm/amd/display/dc/bios/dce110/command_table_helper_dce110.c +0 -0
index 8049320..ca24154 100644

drivers/gpu/drm/amd/display/dc/bios/dce110/command_table_helper_dce110.c static const struct command_table_helper command_table_helper_funcs = { · line 364

Quoted 8 lines
drivers/gpu/drm/amd/display/dc/bios/dce110/command_table_helper_dce110.c +1 -1
@@ -358,7 +358,7 @@ static const struct command_table_helper command_table_helper_funcs = {
    * const struct command_table_helper **h - [out] struct of functions
    *
    */
-const struct command_table_helper *dal_cmd_tbl_helper_dce110_get_table()
+const struct command_table_helper *dal_cmd_tbl_helper_dce110_get_table(void)
   {
       return &command_table_helper_funcs;
   }

BTW may I ask what those accessors functions are good for? That looks just like a LOC increase to me.

Quoted 2 lines

Why not export the command_table_helper_funcs directly?

Good point. This doesn't really serve much purpose. Feel free to send a patch.

Harry

Quoted 58 lines

Regards,
Christian.

Quoted 55 lines
drivers/gpu/drm/amd/display/dc/bios/dce112/command_table_helper2_dce112.c +1 -1
index d342cde..0237ae5 100644
@@ -412,7 +412,7 @@ static const struct command_table_helper command_table_helper_funcs = {
    * const struct command_table_helper **h - [out] struct of functions
    *
    */
-const struct command_table_helper *dal_cmd_tbl_helper_dce112_get_table2()
+const struct command_table_helper *dal_cmd_tbl_helper_dce112_get_table2(void)
   {
       return &command_table_helper_funcs;
   }
drivers/gpu/drm/amd/display/dc/bios/dce112/command_table_helper_dce112.c +1 -1
index 48e5996..452034f 100644
@@ -412,7 +412,7 @@ static const struct command_table_helper command_table_helper_funcs = {
    * const struct command_table_helper **h - [out] struct of functions
    *
    */
-const struct command_table_helper *dal_cmd_tbl_helper_dce112_get_table()
+const struct command_table_helper *dal_cmd_tbl_helper_dce112_get_table(void)
   {
       return &command_table_helper_funcs;
   }
drivers/gpu/drm/amd/display/dc/bios/dce80/command_table_helper_dce80.c +1 -0
index 295e16e..8b30b55 100644
@@ -348,7 +348,7 @@ static const struct command_table_helper command_table_helper_funcs = {
           dal_cmd_table_helper_encoder_mode_bp_to_atom,
   };
   -const struct command_table_helper *dal_cmd_tbl_helper_dce80_get_table()
+const struct command_table_helper *dal_cmd_tbl_helper_dce80_get_table(void)
   {
       return &command_table_helper_funcs;
   }
drivers/gpu/drm/amd/display/dc/core/dc_surface.c +1 -0
index 5aa2270..ade5b8e 100644
@@ -145,7 +145,7 @@ void dc_gamma_release(struct dc_gamma **gamma)
       *gamma = NULL;
   }
   -struct dc_gamma *dc_create_gamma()
+struct dc_gamma *dc_create_gamma(void)
   {
       struct dc_gamma *gamma = kzalloc(sizeof(*gamma), GFP_KERNEL);
   @@ -175,7 +175,7 @@ void dc_transfer_func_release(struct dc_transfer_func *tf)

      kref_put(&tf->refcount, dc_transfer_func_free); }
  -struct dc_transfer_func *dc_create_transfer_func() +struct dc_transfer_func *dc_create_transfer_func(void) {

Quoted 8 lines
Quoted 2 lines

      struct dc_transfer_func *tf = kzalloc(sizeof(*tf), GFP_KERNEL);

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reviewed-by
#6 lore raw
In reply to a message not in the archive
Quoted 10 lines · Dave Airlie

From: Dave Airlie <[email protected]>

smatch reported:
drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce80/command_table_helper_dce80.c:351:71: warning: non-ANSI function declaration of function 'dal_cmd_tbl_helper_dce80_get_table' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce110/command_table_helper_dce110.c:361:72: warning: non-ANSI function declaration of function 'dal_cmd_tbl_helper_dce110_get_table' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce112/command_table_helper_dce112.c:415:72: warning: non-ANSI function declaration of function 'dal_cmd_tbl_helper_dce112_get_table' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce112/command_table_helper2_dce112.c:415:73: warning: non-ANSI function declaration of function 'dal_cmd_tbl_helper_dce112_get_table2' drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_surface.c:148:34: warning: non-ANSI function declaration of function 'dc_create_gamma' drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_surface.c:178:50: warning: non-ANSI function declaration of function 'dc_create_transfer_func'

Quoted 3 lines

This fixes them.

Signed-off-by Dave Airlie <[email protected]>
Reviewed-by Harry Wentland <[email protected]>

Harry

Quoted 75 lines
---
 .../gpu/drm/amd/display/dc/bios/dce110/command_table_helper_dce110.c  | 2 +-
 .../gpu/drm/amd/display/dc/bios/dce112/command_table_helper2_dce112.c | 2 +-
 .../gpu/drm/amd/display/dc/bios/dce112/command_table_helper_dce112.c  | 2 +-
 .../gpu/drm/amd/display/dc/bios/dce80/command_table_helper_dce80.c    | 2 +-
 drivers/gpu/drm/amd/display/dc/core/dc_surface.c                      | 4 ++--
 5 files changed, 6 insertions(+), 6 deletions(-)
drivers/gpu/drm/amd/display/dc/bios/dce110/command_table_helper_dce110.c +1 -1
index 8049320..ca24154 100644
@@ -358,7 +358,7 @@ static const struct command_table_helper command_table_helper_funcs = {
  * const struct command_table_helper **h - [out] struct of functions
  *
  */
-const struct command_table_helper *dal_cmd_tbl_helper_dce110_get_table()
+const struct command_table_helper *dal_cmd_tbl_helper_dce110_get_table(void)
 {
 	return &command_table_helper_funcs;
 }
drivers/gpu/drm/amd/display/dc/bios/dce112/command_table_helper2_dce112.c +1 -1
index d342cde..0237ae5 100644
@@ -412,7 +412,7 @@ static const struct command_table_helper command_table_helper_funcs = {
  * const struct command_table_helper **h - [out] struct of functions
  *
  */
-const struct command_table_helper *dal_cmd_tbl_helper_dce112_get_table2()
+const struct command_table_helper *dal_cmd_tbl_helper_dce112_get_table2(void)
 {
 	return &command_table_helper_funcs;
 }
drivers/gpu/drm/amd/display/dc/bios/dce112/command_table_helper_dce112.c +1 -1
index 48e5996..452034f 100644
@@ -412,7 +412,7 @@ static const struct command_table_helper command_table_helper_funcs = {
  * const struct command_table_helper **h - [out] struct of functions
  *
  */
-const struct command_table_helper *dal_cmd_tbl_helper_dce112_get_table()
+const struct command_table_helper *dal_cmd_tbl_helper_dce112_get_table(void)
 {
 	return &command_table_helper_funcs;
 }
drivers/gpu/drm/amd/display/dc/bios/dce80/command_table_helper_dce80.c +1 -1
index 295e16e..8b30b55 100644
@@ -348,7 +348,7 @@ static const struct command_table_helper command_table_helper_funcs = {
 		dal_cmd_table_helper_encoder_mode_bp_to_atom,
 };
 
-const struct command_table_helper *dal_cmd_tbl_helper_dce80_get_table()
+const struct command_table_helper *dal_cmd_tbl_helper_dce80_get_table(void)
 {
 	return &command_table_helper_funcs;
 }
drivers/gpu/drm/amd/display/dc/core/dc_surface.c +1 -1
index 5aa2270..ade5b8e 100644
@@ -145,7 +145,7 @@ void dc_gamma_release(struct dc_gamma **gamma)
 	*gamma = NULL;
 }
 
-struct dc_gamma *dc_create_gamma()
+struct dc_gamma *dc_create_gamma(void)
 {
 	struct dc_gamma *gamma = kzalloc(sizeof(*gamma), GFP_KERNEL);

drivers/gpu/drm/amd/display/dc/core/dc_surface.c void dc_transfer_func_release(struct dc_transfer_func *tf) · line 181

Quoted 8 lines
drivers/gpu/drm/amd/display/dc/core/dc_surface.c +1 -1
@@ -175,7 +175,7 @@ void dc_transfer_func_release(struct dc_transfer_func *tf)
 	kref_put(&tf->refcount, dc_transfer_func_free);
 }
 
-struct dc_transfer_func *dc_create_transfer_func()
+struct dc_transfer_func *dc_create_transfer_func(void)
 {
 	struct dc_transfer_func *tf = kzalloc(sizeof(*tf), GFP_KERNEL);

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx