Skip to contentSkip to conversation

Fix segfault on "lldptool -t -i eth2 -V PFC -c enabled"

PATCH RESEND In review Sowmini Varadhan 4 participants 6 messages Nov 7, 2017 – Nov 8, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 Fix segfault on "lldptool -t -i eth2 -V PFC -c enabled"

We are trying to use DCBX via lldpad for some of our applications, and finding/fixing bugs and enhancements as we go.

However our attempts to upstream these fixes is encountering silence from the lldp-devel list e.g.,
http://lists.open-lldp.org/pipermail/lldp-devel/2017-October/001252.html

Any suggestions on available options for the care and feeding of lldpad?

There must be other users/maintainers of DCBX implementations- could you please share your experiences in this space?

--Sowmini

#1 lore raw
Quoted 11 lines · Sowmini Varadhan

We are trying to use DCBX via lldpad for some of our applications, and finding/fixing bugs and enhancements as we go.

However our attempts to upstream these fixes is encountering silence from the lldp-devel list e.g.,
http://lists.open-lldp.org/pipermail/lldp-devel/2017-October/001252.html

Any suggestions on available options for the care and feeding of lldpad?

There must be other users/maintainers of DCBX implementations- could you please share your experiences in this space?

Latest commits to the open-lldp repo come from intel.com, suse.de, redhat.com and cisco.com so maybe try contacting someone in these orgs.

My repo on github contains updates to Debian packaging that unfortunately also stalled at some point.

Signature · 1 line
Valentin
#2 lore raw
In reply to Sowmini Varadhan
Quoted 4 lines · Sowmini Varadhan

We are trying to use DCBX via lldpad for some of our applications, and finding/fixing bugs and enhancements as we go.

Quoted 9 lines

However our attempts to upstream these fixes is encountering silence from the lldp-devel list e.g.,
http://lists.open-lldp.org/pipermail/lldp-devel/2017-October/001252.html

Any suggestions on available options for the care and feeding of lldpad?

There must be other users/maintainers of DCBX implementations- could you please share your experiences in this space?

We tried to get the list maintainership moved to over to us by the time Intel decided to drop FCoE. But for some reasons this never worked out, so while the list is technically alive we don't have any means of managing it.
Maybe we should be moving it to somewhere else.
But yes, we _do_ take fixes for it.

Cheers,

Hannes

Signature · 5 lines
Dr. Hannes Reinecke		   Teamlead Storage & Networking
[email protected]			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
#3 lore raw
Quoted 5 lines · Hannes Reinecke

We tried to get the list maintainership moved to over to us by the time Intel decided to drop FCoE. But for some reasons this never worked out, so while the list is technically alive we don't have any means of managing it.
Maybe we should be moving it to somewhere else.

I'd support that.. any thoughts on where to move it to?

Quoted 1 line

But yes, we _do_ take fixes for it.

I just tried setting up a git pull-request for this to Valentin's repo, I'm not sure if I followed procedures correctly (sending text patches to a list comes more naturally to me, and I may have fat-fingered something)

To whom should I send this patch?

We also have a couple of other patches in the pipeline that we are testing, so setting up a mailing list would be welcomed!

--Sowmini

#4 lore raw
Quoted 8 lines · Sowmini Varadhan

I just tried setting up a git pull-request for this to Valentin's repo, I'm not sure if I followed procedures correctly (sending text patches to a list comes more naturally to me, and I may have fat-fingered something)

To whom should I send this patch?

We also have a couple of other patches in the pipeline that we are testing, so setting up a mailing list would be welcomed!

Right, but my repo is just for Debian packaging :) We would need a SUSE repo or email address where to send patches - I also have few small fixes for lldpad and fcoe waiting.

Signature · 1 line
Valentin
#5 lore raw
Quoted 5 lines · Valentin Vidic
Quoted 4 lines · Sowmini Varadhan

I just tried setting up a git pull-request for this to Valentin's repo, I'm not sure if I followed procedures correctly (sending text patches to a list comes more naturally to me, and I may have fat-fingered something)

Quoted 9 lines
Quoted 4 lines

To whom should I send this patch?

We also have a couple of other patches in the pipeline that we are testing, so setting up a mailing list would be welcomed!

Right, but my repo is just for Debian packaging :) We would need a SUSE repo or email address where to send patches - I also have few small fixes for lldpad and fcoe waiting.

I also heard Mellanox folks have few patches so looping them as well. IMO email alone will not be enough and a public repo needed so that latest sources can be available for people developing/using it.

Hannes, you mentioned that you are taking fixes. Is your repo public where you are applying this fixes. Sorry if I missed that part.

Regards,
Santosh