Skip to contentSkip to conversation

net: ethernet: bgmac: mark expected switch fall-through

PATCH Applied Gustavo A. R. Silva 2 participants 2 messages Nov 8, 2017 – Nov 11, 2017

Subsystems (3)
Networking Network drivers Broadcom iproc gbit Ethernet driver
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 net: ethernet: bgmac: mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 1397972

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/net/ethernet/broadcom/bgmac-platform.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/broadcom/bgmac-platform.c +1 -0
index d937083d..894eda5 100644
@@ -131,6 +131,7 @@ static void bgmac_nicpm_speed_set(struct net_device *net_dev)
 	switch (bgmac->net_dev->phydev->speed) {
 	default:
 		netdev_err(net_dev, "Unsupported speed. Defaulting to 1000Mb\n");
+		/* fall through */
 	case SPEED_1000:
 		val |= NICPM_IOMUX_CTRL_SPD_1000M << NICPM_IOMUX_CTRL_SPD_SHIFT;
 		break;
Signature · 1 line
2.7.4