kobject: add SPDX identifiers to all kobject files
Subsystems (7)
Greg Kroah-Hartman
maintainerPATCH 1/5 kobject: add SPDX identifiers to all kobject files
It's good to have SPDX identifiers in all files to make it easier to audit the kernel tree for correct licenses.
Update the kobject files files with the correct SPDX license identifier based on the license text in the file itself. The SPDX identifier is a legally binding shorthand, which can be used instead of the full boiler plate text.
This work is based on a script and data from Thomas Gleixner, Philippe Ombredanne, and Kate Stewart.
--- include/linux/kobject.h | 1 + include/linux/kobject_ns.h | 1 + lib/kobject.c | 1 + lib/kobject_uevent.c | 1 + samples/kobject/kobject-example.c | 1 + samples/kobject/kset-example.c | 1 + 6 files changed, 6 insertions(+)
include/linux/kobject.h +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * kobject.h - generic kernel object infrastructure. *
include/linux/kobject_ns.h +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* Kernel object name space definitions * * Copyright (c) 2002-2003 Patrick Mochel
lib/kobject.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * kobject.c - library routines for handling generic kernel objects *
lib/kobject_uevent.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * kernel userspace event delivery *
samples/kobject/kobject-example.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * Sample kobject implementation *
samples/kobject/kset-example.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * Sample kset and ktype implementation *
Signature · 1 line
2.15.0
Greg Kroah-Hartman
maintainerPATCH 2/5 kobject: Remove redundant license text
Now that the SPDX tag is in all kobject files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all.
This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL license text. And there's unneeded stuff like the address (sometimes incorrect) for the FSF which is never needed.
No copyright headers or other non-license-description text was removed.
--- include/linux/kobject.h | 2 -- include/linux/kobject_ns.h | 2 -- lib/kobject.c | 3 --- lib/kobject_uevent.c | 2 -- samples/kobject/kobject-example.c | 3 --- samples/kobject/kset-example.c | 3 --- 6 files changed, 15 deletions(-)
include/linux/kobject.h +0 -2
@@ -7,8 +7,6 @@* Copyright (c) 2006-2008 Greg Kroah-Hartman <[email protected]> * Copyright (c) 2006-2008 Novell Inc. * -* This file is released under the GPLv2. -* * Please read Documentation/kobject.txt before using the kobject * interface, ESPECIALLY the parts about reference counts and object * destructors.
include/linux/kobject_ns.h +0 -2
@@ -8,8 +8,6 @@* * Split from kobject.h by David Howells ([email protected]) * -* This file is released under the GPLv2. -* * Please read Documentation/kobject.txt before using the kobject * interface, ESPECIALLY the parts about reference counts and object * destructors.
lib/kobject.c +0 -3
@@ -6,9 +6,6 @@* Copyright (c) 2006-2007 Greg Kroah-Hartman <[email protected]> * Copyright (c) 2006-2007 Novell Inc. * -* This file is released under the GPLv2. -* -* * Please see the file Documentation/kobject.txt for critical information * about using the kobject interface. */
lib/kobject_uevent.c +0 -2
@@ -6,8 +6,6 @@* Copyright (C) 2004 Novell, Inc. All rights reserved. * Copyright (C) 2004 IBM, Inc. All rights reserved. * -* Licensed under the GNU GPL v2. -* * Authors: * Robert Love <[email protected]> * Kay Sievers <[email protected]>
samples/kobject/kobject-example.c +0 -3
@@ -4,9 +4,6 @@* * Copyright (C) 2004-2007 Greg Kroah-Hartman <[email protected]> * Copyright (C) 2007 Novell Inc. -* -* Released under the GPL version 2 only. -* */ #include <linux/kobject.h> #include <linux/string.h>
samples/kobject/kset-example.c +0 -3
@@ -4,9 +4,6 @@* * Copyright (C) 2004-2007 Greg Kroah-Hartman <[email protected]> * Copyright (C) 2007 Novell Inc. -* -* Released under the GPL version 2 only. -* */ #include <linux/kobject.h> #include <linux/string.h>
Signature · 1 line
2.15.0
Greg Kroah-Hartman
maintainerPATCH 3/5 driver core: add SPDX identifiers to all driver core files
In reply to Greg Kroah-HartmanIt's good to have SPDX identifiers in all files to make it easier to audit the kernel tree for correct licenses.
Update the driver core files files with the correct SPDX license identifier based on the license text in the file itself. The SPDX identifier is a legally binding shorthand, which can be used instead of the full boiler plate text.
This work is based on a script and data from Thomas Gleixner, Philippe Ombredanne, and Kate Stewart.
--- drivers/base/attribute_container.c | 1 + drivers/base/bus.c | 1 + drivers/base/cacheinfo.c | 1 + drivers/base/class.c | 1 + drivers/base/component.c | 1 + drivers/base/container.c | 1 + drivers/base/core.c | 1 + drivers/base/cpu.c | 1 + drivers/base/dd.c | 1 + drivers/base/devcoredump.c | 1 + drivers/base/devres.c | 1 + drivers/base/dma-contiguous.c | 1 + drivers/base/dma-mapping.c | 1 + drivers/base/driver.c | 1 + drivers/base/firmware.c | 1 + drivers/base/firmware_class.c | 1 + drivers/base/hypervisor.c | 1 + drivers/base/init.c | 1 + drivers/base/isa.c | 1 + drivers/base/map.c | 1 + drivers/base/module.c | 1 + drivers/base/pinctrl.c | 1 + drivers/base/platform-msi.c | 1 + drivers/base/platform.c | 1 + drivers/base/property.c | 1 + drivers/base/soc.c | 1 + drivers/base/syscore.c | 1 + drivers/base/test/test_async_driver_probe.c | 1 + drivers/base/topology.c | 1 + drivers/base/transport_class.c | 1 + include/linux/device.h | 1 + 31 files changed, 31 insertions(+)
drivers/base/attribute_container.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * attribute_container.c - implementation of a simple container for classes *
drivers/base/bus.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * bus.c - bus driver management *
drivers/base/cacheinfo.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * cacheinfo support - processor cache information via sysfs *
drivers/base/class.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * class.c - basic device class management *
drivers/base/component.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * Componentized device handling. *
drivers/base/container.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * System bus type for containers. *
drivers/base/core.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * drivers/base/core.c - core driver model code (device registration, etc) *
drivers/base/cpu.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * CPU subsystem support */
drivers/base/dd.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * drivers/base/dd.c - The core device/driver interactions. *
drivers/base/devcoredump.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * This file is provided under the GPLv2 license. *
drivers/base/devres.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * drivers/base/devres.c - device resource management *
drivers/base/dma-contiguous.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0+ /* * Contiguous Memory Allocator for DMA mapping framework * Copyright (c) 2010-2011 by Samsung Electronics.
drivers/base/dma-mapping.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * drivers/base/dma-mapping.c - arch-independent dma-mapping routines *
drivers/base/driver.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * driver.c - centralized device driver management *
drivers/base/firmware.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * firmware.c - firmware subsystem hoohaw. *
drivers/base/firmware_class.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * firmware_class.c - Multi purpose firmware loading support *
drivers/base/hypervisor.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * hypervisor.c - /sys/hypervisor subsystem. *
drivers/base/init.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * Copyright (c) 2002-3 Patrick Mochel * Copyright (c) 2002-3 Open Source Development Labs
drivers/base/isa.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * ISA bus. */
drivers/base/map.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * linux/drivers/base/map.c *
drivers/base/module.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * module.c - module sysfs fun for drivers *
drivers/base/pinctrl.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * Driver core interface to the pinctrl subsystem. *
drivers/base/platform-msi.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * MSI framework for platform devices *
drivers/base/platform.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * platform.c - platform 'pseudo' bus for legacy devices *
drivers/base/property.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * property.c - Unified device property interface. *
drivers/base/soc.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * Copyright (C) ST-Ericsson SA 2011 *
drivers/base/syscore.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * syscore.c - Execution of system core operations. *
drivers/base/test/test_async_driver_probe.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * Copyright (C) 2014 Google, Inc. *
drivers/base/topology.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0+ /* * driver/base/topology.c - Populate sysfs with cpu topology information *
drivers/base/transport_class.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * transport_class.c - implementation of generic transport classes * using attribute_containers
include/linux/device.h +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * device.h - generic, centralized driver model *
Signature · 1 line
2.15.0
Re: [PATCH 3/5] driver core: add SPDX identifiers to all driver core files
Quoted 11 lines · Greg Kroah-Hartman
It's good to have SPDX identifiers in all files to make it easier to audit the kernel tree for correct licenses.
Update the driver core files files with the correct SPDX license identifier based on the license text in the file itself. The SPDX identifier is a legally binding shorthand, which can be used instead of the full boiler plate text.
This work is based on a script and data from Thomas Gleixner, Philippe Ombredanne, and Kate Stewart.
Quoted 8 lines
Cc Greg Kroah-Hartman <[email protected]>Cc Johannes Berg <[email protected]>Cc "Luis R. Rodriguez" <[email protected]>Cc William Breathitt Gray <[email protected]>Cc Thomas Gleixner <[email protected]>Cc Kate Stewart <[email protected]>Cc Philippe Ombredanne <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
Although I'm the current maintainer of drivers/base/isa.c, I believe Rene Herman was the original author of this file. I'm CCing Rene for input regarding this file as I'm not sure if GPL-2.0 was intended or instead a more permissive license.
William Breathitt Gray
Greg Kroah-Hartman
maintainerPATCH 4/5 drivers: core: arch_topology.c: move SPDX tag to top of the file
In reply to Greg Kroah-Hartmanarch_topology.c had a SPDX tag in it, so move it to the top of the file like the rest of the kernel files have it.
Also remove the redundant license text as it is not needed if the SPDX tag is in the file, as the tag identifies the license in a specific and legally-defined manner.
This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL license text. And there's unneeded stuff like the address (sometimes incorrect) for the FSF which is never needed.
No copyright headers or other non-license-description text was removed.
--- drivers/base/arch_topology.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)
drivers/base/arch_topology.c +1 -7
@@ -1,15 +1,9 @@ +// SPDX-License-Identifier: GPL-2.0 /* * Arch specific cpu topology information * * Copyright (C) 2016, ARM Ltd. * Written by: Juri Lelli, ARM Ltd. -* -* This file is subject to the terms and conditions of the GNU General Public -* License. See the file "COPYING" in the main directory of this archive -* for more details. -* -* Released under the GPLv2 only. -* SPDX-License-Identifier: GPL-2.0 */ #include <linux/acpi.h>
Signature · 1 line
2.15.0
Greg Kroah-Hartman
maintainerPATCH 5/5 driver core: Remove redundant license text
In reply to Greg Kroah-HartmanNow that the SPDX tag is in all driver core files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all.
This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL license text. And there's unneeded stuff like the address (sometimes incorrect) for the FSF which is never needed.
No copyright headers or other non-license-description text was removed.
--- drivers/base/attribute_container.c | 2 -- drivers/base/bus.c | 3 --- drivers/base/cacheinfo.c | 12 ------------ drivers/base/class.c | 3 --- drivers/base/component.c | 4 ---- drivers/base/container.c | 4 ---- drivers/base/core.c | 3 --- drivers/base/dd.c | 2 -- drivers/base/devcoredump.c | 16 ---------------- drivers/base/devres.c | 2 -- drivers/base/dma-contiguous.c | 5 ----- drivers/base/dma-mapping.c | 2 -- drivers/base/driver.c | 3 --- drivers/base/firmware.c | 2 -- drivers/base/hypervisor.c | 2 -- drivers/base/init.c | 2 -- drivers/base/map.c | 1 - drivers/base/module.c | 3 --- drivers/base/pinctrl.c | 2 -- drivers/base/platform-msi.c | 12 ------------ drivers/base/platform.c | 2 -- drivers/base/property.c | 4 ---- drivers/base/soc.c | 1 - drivers/base/syscore.c | 2 -- drivers/base/test/test_async_driver_probe.c | 9 --------- drivers/base/topology.c | 16 ---------------- drivers/base/transport_class.c | 2 -- include/linux/device.h | 2 -- 28 files changed, 123 deletions(-)
drivers/base/attribute_container.c +0 -2
@@ -4,8 +4,6 @@* * Copyright (c) 2005 - James Bottomley <[email protected]> * -* This file is licensed under GPLv2 -* * The basic idea here is to enable a device to be attached to an * aritrary numer of classes without having to allocate storage for them. * Instead, the contained classes select the devices they need to attach
drivers/base/bus.c +0 -3
@@ -6,9 +6,6 @@* Copyright (c) 2002-3 Open Source Development Labs * Copyright (c) 2007 Greg Kroah-Hartman <[email protected]> * Copyright (c) 2007 Novell Inc. -* -* This file is released under the GPLv2 -* */ #include <linux/async.h>
drivers/base/cacheinfo.c +0 -12
@@ -4,18 +4,6 @@* * Based on arch/x86/kernel/cpu/intel_cacheinfo.c * Author: Sudeep Holla <[email protected]> -* -* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License version 2 as -* published by the Free Software Foundation. -* -* This program is distributed "as is" WITHOUT ANY WARRANTY of any -* kind, whether express or implied; without even the implied warranty -* of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -* GNU General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program. If not, see <http://www.gnu.org/licenses/>. */ #define pr_fmt (fmt) KBUILD_MODNAME ": " fmt
drivers/base/class.c +0 -3
@@ -6,9 +6,6 @@* Copyright (c) 2002-3 Open Source Development Labs * Copyright (c) 2003-2004 Greg Kroah-Hartman * Copyright (c) 2003-2004 IBM Corp. -* -* This file is released under the GPLv2 -* */ #include <linux/device.h>
drivers/base/component.c +0 -4
@@ -2,10 +2,6 @@/* * Componentized device handling. * -* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License version 2 as -* published by the Free Software Foundation. -* * This is work in progress. We gather up the component devices into a list, * and bind them when instructed. At the moment, we're specific to the DRM * subsystem, and only handles one master device, but this doesn't have to be
drivers/base/container.c +0 -4
@@ -4,10 +4,6 @@* * Copyright (C) 2013, Intel Corporation * Author: Rafael J. Wysocki <[email protected]> -* -* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License version 2 as -* published by the Free Software Foundation. */ #include <linux/container.h>
drivers/base/core.c +0 -3
@@ -6,9 +6,6 @@* Copyright (c) 2002-3 Open Source Development Labs * Copyright (c) 2006 Greg Kroah-Hartman <[email protected]> * Copyright (c) 2006 Novell, Inc. -* -* This file is released under the GPLv2 -* */ #include <linux/device.h>
drivers/base/dd.c +0 -2
@@ -14,8 +14,6 @@* Copyright (c) 2002-3 Open Source Development Labs * Copyright (c) 2007-2009 Greg Kroah-Hartman <[email protected]> * Copyright (c) 2007-2009 Novell Inc. -* -* This file is released under the GPLv2 */ #include <linux/device.h>
drivers/base/devcoredump.c +0 -16
@@ -1,24 +1,8 @@// SPDX-License-Identifier: GPL-2.0 /* -* This file is provided under the GPLv2 license. -* -* GPL LICENSE SUMMARY -* * Copyright(c) 2014 Intel Mobile Communications GmbH * Copyright(c) 2015 Intel Deutschland GmbH * -* This program is free software; you can redistribute it and/or modify -* it under the terms of version 2 of the GNU General Public License as -* published by the Free Software Foundation. -* -* This program is distributed in the hope that it will be useful, but -* WITHOUT ANY WARRANTY; without even the implied warranty of -* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -* General Public License for more details. -* -* The full GNU General Public License is included in this distribution -* in the file called COPYING. -* * Contact Information: * Intel Linux Wireless <[email protected]> * Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497
drivers/base/devres.c +0 -2
@@ -4,8 +4,6 @@* * Copyright (c) 2006 SUSE Linux Products GmbH * Copyright (c) 2006 Tejun Heo <[email protected]> -* -* This file is released under the GPLv2. */ #include <linux/device.h>
drivers/base/dma-contiguous.c +0 -5
@@ -5,11 +5,6 @@* Written by: * Marek Szyprowski <[email protected]> * Michal Nazarewicz <[email protected]> -* -* This program is free software; you can redistribute it and/or -* modify it under the terms of the GNU General Public License as -* published by the Free Software Foundation; either version 2 of the -* License or (at your optional) any later version of the license. */ #define pr_fmt (fmt) "cma: " fmt
drivers/base/dma-mapping.c +0 -2
@@ -4,8 +4,6 @@* * Copyright (c) 2006 SUSE Linux Products GmbH * Copyright (c) 2006 Tejun Heo <[email protected]> -* -* This file is released under the GPLv2. */ #include <linux/acpi.h>
drivers/base/driver.c +0 -3
@@ -6,9 +6,6 @@* Copyright (c) 2002-3 Open Source Development Labs * Copyright (c) 2007 Greg Kroah-Hartman <[email protected]> * Copyright (c) 2007 Novell Inc. -* -* This file is released under the GPLv2 -* */ #include <linux/device.h>
drivers/base/firmware.c +0 -2
@@ -6,8 +6,6 @@* Copyright (c) 2002-3 Open Source Development Labs * Copyright (c) 2007 Greg Kroah-Hartman <[email protected]> * Copyright (c) 2007 Novell Inc. -* -* This file is released under the GPLv2 */ #include <linux/kobject.h> #include <linux/module.h>
drivers/base/hypervisor.c +0 -2
@@ -5,8 +5,6 @@* Copyright (C) IBM Corp. 2006 * Copyright (C) 2007 Greg Kroah-Hartman <[email protected]> * Copyright (C) 2007 Novell Inc. -* -* This file is released under the GPLv2 */ #include <linux/kobject.h>
drivers/base/init.c +0 -2
@@ -2,8 +2,6 @@/* * Copyright (c) 2002-3 Patrick Mochel * Copyright (c) 2002-3 Open Source Development Labs -* -* This file is released under the GPLv2 */ #include <linux/device.h>
drivers/base/map.c +0 -1
@@ -3,7 +3,6 @@* linux/drivers/base/map.c * * (C) Copyright Al Viro 2002,2003 -* Released under GPL v2. * * NOTE: data structure needs to be changed. It works, but for large dev_t * it will be too slow. It is isolated, though, so these changes will be
drivers/base/module.c +0 -3
@@ -1,9 +1,6 @@// SPDX-License-Identifier: GPL-2.0 /* * module.c - module sysfs fun for drivers -* -* This file is released under the GPLv2 -* */ #include <linux/device.h> #include <linux/module.h>
drivers/base/pinctrl.c +0 -2
@@ -7,8 +7,6 @@* Based on bits of regulator core, gpio core and clk core * * Author: Linus Walleij <[email protected]> -* -* License terms: GNU General Public License (GPL) version 2 */ #include <linux/device.h>
drivers/base/platform-msi.c +0 -12
@@ -4,18 +4,6 @@* * Copyright (C) 2015 ARM Limited, All Rights Reserved. * Author: Marc Zyngier <[email protected]> -* -* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License version 2 as -* published by the Free Software Foundation. -* -* This program is distributed in the hope that it will be useful, -* but WITHOUT ANY WARRANTY; without even the implied warranty of -* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -* GNU General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program. If not, see <http://www.gnu.org/licenses/>. */ #include <linux/device.h>
drivers/base/platform.c +0 -2
@@ -5,8 +5,6 @@* Copyright (c) 2002-3 Patrick Mochel * Copyright (c) 2002-3 Open Source Development Labs * -* This file is released under the GPLv2 -* * Please see Documentation/driver-model/platform.txt for more * information. */
drivers/base/property.c +0 -4
@@ -5,10 +5,6 @@* Copyright (C) 2014, Intel Corporation * Authors: Rafael J. Wysocki <[email protected]> * Mika Westerberg <[email protected]> -* -* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License version 2 as -* published by the Free Software Foundation. */ #include <linux/acpi.h>
drivers/base/soc.c +0 -1
@@ -3,7 +3,6 @@* Copyright (C) ST-Ericsson SA 2011 * * Author: Lee Jones <[email protected]> for ST-Ericsson. -* License terms: GNU General Public License (GPL), version 2 */ #include <linux/sysfs.h>
drivers/base/syscore.c +0 -2
@@ -3,8 +3,6 @@* syscore.c - Execution of system core operations. * * Copyright (C) 2011 Rafael J. Wysocki <[email protected]>, Novell Inc. -* -* This file is released under the GPLv2. */ #include <linux/syscore_ops.h>
drivers/base/test/test_async_driver_probe.c +0 -9
@@ -1,15 +1,6 @@// SPDX-License-Identifier: GPL-2.0 /* * Copyright (C) 2014 Google, Inc. -* -* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License version 2 as -* published by the Free Software Foundation. -* -* This program is distributed in the hope that it will be useful, -* but WITHOUT ANY WARRANTY; without even the implied warranty of -* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -* GNU General Public License for more details. */ #define pr_fmt (fmt) KBUILD_MODNAME ": " fmt
drivers/base/topology.c +0 -16
@@ -7,22 +7,6 @@* Copyright (C) 2006, Intel Corp. * * All rights reserved. -* -* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License as published by -* the Free Software Foundation; either version 2 of the License, or -* (at your option) any later version. -* -* This program is distributed in the hope that it will be useful, but -* WITHOUT ANY WARRANTY; without even the implied warranty of -* MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or -* NON INFRINGEMENT. See the GNU General Public License for more -* details. -* -* You should have received a copy of the GNU General Public License -* along with this program; if not, write to the Free Software -* Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. -* */ #include <linux/mm.h> #include <linux/cpu.h>
drivers/base/transport_class.c +0 -2
@@ -5,8 +5,6 @@* * Copyright (c) 2005 - James Bottomley <[email protected]> * -* This file is licensed under GPLv2 -* * The basic idea here is to allow any "device controller" (which * would most often be a Host Bus Adapter to use the services of one * or more tranport classes for performing transport specific
include/linux/device.h +0 -2
@@ -6,8 +6,6 @@* Copyright (c) 2004-2009 Greg Kroah-Hartman <[email protected]> * Copyright (c) 2008-2009 Novell Inc. * -* This file is released under the GPLv2 -* * See Documentation/driver-model/ for more information. */
Signature · 1 line
2.15.0
Re: [PATCH 5/5] driver core: Remove redundant license text
Quoted 2 lines · Greg Kroah-Hartman
Now that the SPDX tag is in all driver core files, that identifies the license in a specific and legally-defined manner.
Takashi and Jiri mentioned that the effort to add SPDX tags to files which did not have licensing was discussed at the maintainers summit and it was agreed upon there that this made sense. That is wonderful.
Naturally, even despite this, some still have their own questions about this work [0]. And some others seem to actually have pointed out that the work might have some technical issues [1] likely worth considering.
[0] https://lkml.kernel.org/r/[email protected]
[1] https://lkml.kernel.org/r/20171108171938.7df66c65@alans-desktop
Quoted 1 line
So the extra GPL text wording can be removed
Highlight *removed*
Quoted 1 line
as it is no longer needed at all.
This secondary however was not.
The only sort of explain about this came from Philippe Ombredanne recently [2] on the generic effort questioned by Christoph.
[2] https://lkml.kernel.org/r/CAOFm3uFLRCZwtw4F884Rd=5=yZnX_ibzBzyiC4f+=5iju4k81Q@mail.gmail.com
But this begs the question that if there is still questions, issues pointed out, and request for a bit more open discussion about the *first* SPDX effort of adding a tag to files which have no license, if there was *any* due process for creating consensus for also going along with this *secondary* SPDX effort of license *simplification* by replacing old boiler plate license tags with an SPDX tag.
At least internally within SUSE I can say so far that we are surprised by these patches and work. We did not know, and this is the first of communication of such effort.
Don't get me wrong, these simplifications make perfect sense to me! But in dealing with licensing considerations before on Linux I've learned through feedback from you, Alan, and Ted and others to also be *extremely* careful and sensitive about licensing annotation matters, and this type of change seems to likely deserve a bit more community consensus than what this seems to be getting.
Not even an RFC. So why rush this work in?
Quoted 4 lines
This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL license text. And there's unneeded stuff like the address (sometimes incorrect) for the FSF which is never needed.
Completely agreed, all this stuff is rather silly, however which tag is used, when, and how seems to have never been discussed and vetted anywhere to my knowledge.
Below I leave two examples of the patch, but leave in place the diffstat.
Quoted 28 lines
No copyright headers or other non-license-description text was removed.
Cc Greg Kroah-Hartman <[email protected]>Cc Johannes Berg <[email protected]>Cc "Luis R. Rodriguez" <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>--- drivers/base/attribute_container.c | 2 -- drivers/base/bus.c | 3 --- drivers/base/cacheinfo.c | 12 ------------ drivers/base/class.c | 3 --- drivers/base/component.c | 4 ---- drivers/base/container.c | 4 ---- drivers/base/core.c | 3 --- drivers/base/dd.c | 2 -- drivers/base/devcoredump.c | 16 ---------------- drivers/base/devres.c | 2 -- drivers/base/dma-contiguous.c | 5 ----- drivers/base/dma-mapping.c | 2 -- drivers/base/driver.c | 3 --- drivers/base/firmware.c | 2 -- drivers/base/hypervisor.c | 2 -- drivers/base/init.c | 2 -- drivers/base/map.c | 1 - drivers/base/module.c | 3 --- drivers/base/pinctrl.c | 2 -- drivers/base/platform-msi.c | 12 ------------ drivers/base/platform.c | 2 --
Quoted 8 lines
drivers/base/property.c | 4 ---- drivers/base/soc.c | 1 - drivers/base/syscore.c | 2 -- drivers/base/test/test_async_driver_probe.c | 9 --------- drivers/base/topology.c | 16 ---------------- drivers/base/transport_class.c | 2 -- include/linux/device.h | 2 -- 28 files changed, 123 deletions(-)
<-- snip -->
Quoted 13 lines
drivers/base/cacheinfo.c +0
-5@@ -4,18 +4,6 @@* * Based on arch/x86/kernel/cpu/intel_cacheinfo.c * Author: Sudeep Holla <[email protected]> -* -* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License version 2 as -* published by the Free Software Foundation. -*
drivers/base/cacheinfo.c line 9
Quoted 10 lines
drivers/base/cacheinfo.c +0
-7-* This program is distributed "as is" WITHOUT ANY WARRANTY of any -* kind, whether express or implied; without even the implied warranty -* of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -* GNU General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program. If not, see <http://www.gnu.org/licenses/>. */ #define pr_fmt (fmt) KBUILD_MODNAME ": " fmt
<-- snip -->
drivers/base/firmware.c line 11
Quoted 13 lines
drivers/base/firmware.c +0
-2@@ -6,8 +6,6 @@* Copyright (c) 2002-3 Open Source Development Labs * Copyright (c) 2007 Greg Kroah-Hartman <[email protected]> * Copyright (c) 2007 Novell Inc. -* -* This file is released under the GPLv2 */ #include <linux/kobject.h> #include <linux/module.h>
Luis
Greg Kroah-Hartman
maintainerRe: [PATCH 5/5] driver core: Remove redundant license text
Quoted 15 lines · Luis R. Rodriguez
Quoted 2 lines · Greg Kroah-Hartman
Now that the SPDX tag is in all driver core files, that identifies the license in a specific and legally-defined manner.
Takashi and Jiri mentioned that the effort to add SPDX tags to files which did not have licensing was discussed at the maintainers summit and it was agreed upon there that this made sense. That is wonderful.
Naturally, even despite this, some still have their own questions about this work [0]. And some others seem to actually have pointed out that the work might have some technical issues [1] likely worth considering.
[0] https://lkml.kernel.org/r/[email protected]
[1] https://lkml.kernel.org/r/20171108171938.7df66c65@alans-desktop
Quoted 7 lines
Quoted 1 line
So the extra GPL text wording can be removed
Highlight *removed*
Quoted 1 line
as it is no longer needed at all.
This secondary however was not.
Was not what? Discussed? Yes it was. I think the lwn.net article even says so.
Quoted 11 lines
But this begs the question that if there is still questions, issues pointed out, and request for a bit more open discussion about the *first* SPDX effort of adding a tag to files which have no license, if there was *any* due process for creating consensus for also going along with this *secondary* SPDX effort of license *simplification* by replacing old boiler plate license tags with an SPDX tag.
At least internally within SUSE I can say so far that we are surprised by these patches and work. We did not know, and this is the first of communication of such effort.
Quoted 8 lines
Don't get me wrong, these simplifications make perfect sense to me! But in dealing with licensing considerations before on Linux I've learned through feedback from you, Alan, and Ted and others to also be *extremely* careful and sensitive about licensing annotation matters, and this type of change seems to likely deserve a bit more community consensus than what this seems to be getting.
Not even an RFC. So why rush this work in?
I don't post RFCs :)
As for "rush", not really, might as well do it sometime, so I've created a bunch of patches and merged some of them. It's going to be a lot of work, someone had to start it :)
Thomas is working on a document to describe this, hopefully it will be done soon.
Quoted 8 lines
Quoted 4 lines
This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL license text. And there's unneeded stuff like the address (sometimes incorrect) for the FSF which is never needed.
Completely agreed, all this stuff is rather silly, however which tag is used, when, and how seems to have never been discussed and vetted anywhere to my knowledge.
"which" tag is just SPDX, that's easy. As for "when and how", I don't understand the question.
Quoted 1 line
Below I leave two examples of the patch, but leave in place the diffstat.
I don't understand, do you object to the patches? Do you not think they should be merged? If so, please let me know.
thanks,
greg k-h
Re: [PATCH 5/5] driver core: Remove redundant license text
Quoted 2 lines · Greg Kroah-Hartman
Was not what? Discussed? Yes it was. I think the lwn.net article even says so.
There is absolutely no public track record of any discussion. And if there was any it seems like a large number of the biggest contributors and copyright holders in the kernel were excluded.
So please state what was decided, where it was deciced, who decided it and why as a start.
This whole debacle is not how we normally communicate big changes in the kernel community, and that is double worrisome because it is an important area with legal implications.
Quoted 2 lines
"which" tag is just SPDX, that's easy. As for "when and how", I don't understand the question.
And where is our defintion of SPDX in our kernel tree? As said in another thread, yes I can google it. But that doesn't provide a stable defintion, nevermind that we do not even have a pointer to it from anywhere in the tree.
If your use of SPDX is apparently fine because people must know I'll just invent my own tags and mandate them [1].
[1] not that I have anything about the SPDX tags in particular, it's just the way you rush them in without even defining them for us.
Re: [PATCH 5/5] driver core: Remove redundant license text
Quoted 7 lines · Christoph Hellwig
Quoted 2 lines · Greg Kroah-Hartman
Was not what? Discussed? Yes it was. I think the lwn.net article even says so.
There is absolutely no public track record of any discussion. And if there was any it seems like a large number of the biggest contributors and copyright holders in the kernel were excluded.
Yes, and excluded I feel, and it is very alienating. The first I knew about this was when I got a bunch of git conflicts. That's really not an acceptable way to find out about this.
My interactions since with GregKH seems to be "I'm doing this, you don't have any say in it." TBH, the idea of approaching a solicitor to review whether GregKH's unilateral action is legal has crossed my mind.
Quoted 15 lines
So please state what was decided, where it was deciced, who decided it and why as a start.
This whole debacle is not how we normally communicate big changes in the kernel community, and that is double worrisome because it is an important area with legal implications.
Quoted 2 lines
"which" tag is just SPDX, that's easy. As for "when and how", I don't understand the question.
And where is our defintion of SPDX in our kernel tree? As said in another thread, yes I can google it. But that doesn't provide a stable defintion, nevermind that we do not even have a pointer to it from anywhere in the tree.
Quoted 6 lines
If your use of SPDX is apparently fine because people must know I'll just invent my own tags and mandate them [1].
[1] not that I have anything about the SPDX tags in particular, it's just the way you rush them in without even defining them for us.
Thank you, Christoph, for voicing my concerns. I'm very concerned by the "indirection" problem, and I've mentioned that in a private email to Linus. However, Linus omitted replying to that point.
We know that the SPDX tags are defined on some website, but by switching to the tags, it gives that website a lot of power over their meaning, and I really don't like that.
We can say "oh yes, it's obvious" but obvious doesn't come into it in the court room when solicitors are arguing over the meaning of a term.
Consider what would happen if someone creates "Gerald's Philosophical License v2" and the SPDX domain (for whatever reason) ends up being owned by that person, and they put up a website that apparently defines a new set of SPDX tags, where "GPLv2" means their own license. Where is the legal definition that the "GPLv2" SPDX tag means the license we know today?
I'd be more comfortable if we could have something in the kernel tree that identifies the SPDX tags and their meaning, maybe with the _standard_ file header for that license included, so there is no argument about what any particular SPDX tag means.
Linus did an excellent job of explaining to me (privately) /why/ the change is being done, but I strongly disagree that the way it is being done and the timing of the first round of changes was ideal - I believe the first round of changes happened at the worst possible moment. However, that bit is now water under the bridge, and we have to live with that change in terms of the git conflicts now.
Signature · 2 lines
Russell King ARM architecture Linux Kernel maintainer