Input: sidewinder - mark expected switch fall-throughs
Subsystems (2)
PATCH 1/1 Input: sidewinder - mark expected switch fall-throughs
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Addresses-Coverity-ID: 114763
Addresses-Coverity-ID: 114764
Addresses-Coverity-ID: 114765
Addresses-Coverity-ID: 114766
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- drivers/input/joystick/sidewinder.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/input/joystick/sidewinder.c +5 -5
@@ -672,16 +672,16 @@ static int sw_connect(struct gameport *gameport, struct gameport_driver *drv)switch (i * m) {case 60 : - sw->number++; + sw->number++;/* fall through */ case 45 :/* Ambiguous packet length */ if (j <=40 ) {/* ID length less or eq 40 -> FSP */ case 43 : sw->type =SW_ID_FSP ;break ; } - sw->number++; + sw->number++;/* fall through */ case 30 : - sw->number++; + sw->number++;/* fall through */ case 15 : sw->type =SW_ID_GP ;break ;
@@ -697,9 +697,9 @@ static int sw_connect(struct gameport *gameport, struct gameport_driver *drv) sw->type =SW_ID_PP ;break ;case 66 : - sw->bits =3 ; + sw->bits =3 ;/* fall through */ case 198 : - sw->length =22 ; + sw->length =22 ;/* fall through */ case 64 : sw->type =SW_ID_3DP ;if (j ==160 )
Signature · 1 line
2.7.4
Quoted 8 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Addresses-Coverity-ID: 114763
Addresses-Coverity-ID: 114764
Addresses-Coverity-ID: 114765
Addresses-Coverity-ID: 114766Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied, thank you.
Quoted 43 lines
--- drivers/input/joystick/sidewinder.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)drivers/input/joystick/sidewinder.c +5
-5@@ -672,16 +672,16 @@ static int sw_connect(struct gameport *gameport, struct gameport_driver *drv)switch (i * m) {case 60 : - sw->number++; + sw->number++;/* fall through */ case 45 :/* Ambiguous packet length */ if (j <=40 ) {/* ID length less or eq 40 -> FSP */ case 43 : sw->type =SW_ID_FSP ;break ; } - sw->number++; + sw->number++;/* fall through */ case 30 : - sw->number++; + sw->number++;/* fall through */ case 15 : sw->type =SW_ID_GP ;break ;@@ -697,9 +697,9 @@ static int sw_connect(struct gameport *gameport, struct gameport_driver *drv) sw->type =SW_ID_PP ;break ;case 66 : - sw->bits =3 ; + sw->bits =3 ;/* fall through */ case 198 : - sw->length =22 ; + sw->length =22 ;/* fall through */ case 64 : sw->type =SW_ID_3DP ;if (j ==160 )Signature · 1 line
2.7.4
Signature · 1 line
Dmitry