Input: gamecon - mark expected switch fall-throughs
Subsystems (2)
PATCH 1/1 Input: gamecon - mark expected switch fall-throughs
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Addresses-Coverity-ID: 114761
Addresses-Coverity-ID: 114762
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- drivers/input/joystick/gamecon.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/input/joystick/gamecon.c +3 -0
@@ -654,6 +654,7 @@ static void gc_psx_report_one(struct gc_pad *pad, unsigned char psx_type,input_report_key (dev,BTN_THUMBL , ~data[0 ] &0x04 );input_report_key (dev,BTN_THUMBR , ~data[0 ] &0x02 ); +/* fall through */ case GC_PSX_NEGCON :case GC_PSX_ANALOG :
@@ -887,6 +888,7 @@ static int gc_setup_pad(struct gc *gc, int idx, int pad_type)case GC_SNES :for (i =4 ; i <8 ; i++)__set_bit (gc_snes_btn[i], input_dev->keybit); +/* fall through */ case GC_NES :for (i =0 ; i <4 ; i++)__set_bit (gc_snes_btn[i], input_dev->keybit);
@@ -894,6 +896,7 @@ static int gc_setup_pad(struct gc *gc, int idx, int pad_type)case GC_MULTI2 :__set_bit (BTN_THUMB , input_dev->keybit); +/* fall through */ case GC_MULTI :__set_bit (BTN_TRIGGER , input_dev->keybit);break ;
Signature · 1 line
2.7.4
Quoted 6 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Addresses-Coverity-ID: 114761
Addresses-Coverity-ID: 114762Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied, thank you.
Quoted 35 lines
--- drivers/input/joystick/gamecon.c | 3 +++ 1 file changed, 3 insertions(+)drivers/input/joystick/gamecon.c +3
-0@@ -654,6 +654,7 @@ static void gc_psx_report_one(struct gc_pad *pad, unsigned char psx_type,input_report_key (dev,BTN_THUMBL , ~data[0 ] &0x04 );input_report_key (dev,BTN_THUMBR , ~data[0 ] &0x02 ); +/* fall through */ case GC_PSX_NEGCON :case GC_PSX_ANALOG :@@ -887,6 +888,7 @@ static int gc_setup_pad(struct gc *gc, int idx, int pad_type)case GC_SNES :for (i =4 ; i <8 ; i++)__set_bit (gc_snes_btn[i], input_dev->keybit); +/* fall through */ case GC_NES :for (i =0 ; i <4 ; i++)__set_bit (gc_snes_btn[i], input_dev->keybit);@@ -894,6 +896,7 @@ static int gc_setup_pad(struct gc *gc, int idx, int pad_type)case GC_MULTI2 :__set_bit (BTN_THUMB , input_dev->keybit); +/* fall through */ case GC_MULTI :__set_bit (BTN_TRIGGER , input_dev->keybit);break ;Signature · 1 line
2.7.4
Signature · 1 line
Dmitry