Skip to contentSkip to conversation

net: 8390: pcnet_cs: mark expected switch fall-through

PATCH Applied Gustavo A. R. Silva 2 participants 2 messages Nov 9, 2017 – Nov 11, 2017

Subsystems (4)
Networking Network drivers Pcmcia 8390 network drivers
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 net: 8390: pcnet_cs: mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 114891

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/net/ethernet/8390/pcnet_cs.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/8390/pcnet_cs.c +1 -0
index eae9827..bcad4a7 100644
@@ -1107,6 +1107,7 @@ static int ei_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
     switch (cmd) {
     case SIOCGMIIPHY:
 	data->phy_id = info->phy_id;
+	/* fall through */
     case SIOCGMIIREG:		/* Read MII PHY register. */
 	data->val_out = mdio_read(mii_addr, data->phy_id, data->reg_num & 0x1f);
 	return 0;
Signature · 1 line
2.7.4