Skip to contentSkip to conversation

perf evsel: Fix up leftover perf_evsel_stat usage via evsel->priv

tip:perf/core tip-bot for Arnaldo Carvalho de Melo 1 participant 2 messages Nov 18, 2017 – Nov 29, 2017 1 message not in the archive perf events

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Commit-ID:  82806c3aae7496d6974429f3bd43ebeeef18b9b2
Gitweb:     https://git.kernel.org/tip/82806c3aae7496d6974429f3bd43ebeeef18b9b2
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Thu, 9 Nov 2017 12:03:40 -0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Thu, 16 Nov 2017 14:49:53 -0300

perf evsel: Fix up leftover perf_evsel_stat usage via evsel->priv

I forgot one conversion, which got noticed by Thomas when running:

  $ perf stat  -e '{cpu-clock,instructions}' kill
  kill: not enough arguments
  Segmentation fault (core dumped)
  $

Fix it, those stats are in evsel->stats, not anymore in evsel->priv.

Cc Adrian Hunter <[email protected]>
Cc Andi Kleen <[email protected]>
Cc David Ahern <[email protected]>
Cc Hendrik Brueckner <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Wang Nan <[email protected]>
Fixes e669e833da8d ("perf evsel: Restore evsel->priv as a tool private area")
---
 tools/perf/util/evsel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/evsel.c +1 -1
index 4376cdf..cb9bcdb 100644
@@ -1377,7 +1377,7 @@ perf_evsel__process_group_data(struct perf_evsel *leader,
 static int
 perf_evsel__read_group(struct perf_evsel *leader, int cpu, int thread)
 {
-	struct perf_stat_evsel *ps = leader->priv;
+	struct perf_stat_evsel *ps = leader->stats;
 	u64 read_format = leader->attr.read_format;
 	int size = perf_evsel__read_size(leader);
 	u64 *data = ps->group_data;
#2 lore raw
In reply to a message not in the archive
perf evsel: Fix up leftover perf_evsel_stat usage via evsel->priv
Commit-ID:  8e2d8e204247aa9eeb87893f6b8bf0cf29428b31
Gitweb:     https://git.kernel.org/tip/8e2d8e204247aa9eeb87893f6b8bf0cf29428b31
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Thu, 9 Nov 2017 12:03:40 -0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Tue, 28 Nov 2017 14:20:32 -0300

perf evsel: Fix up leftover perf_evsel_stat usage via evsel->priv

I forgot one conversion, which got noticed by Thomas when running:

  $ perf stat  -e '{cpu-clock,instructions}' kill
  kill: not enough arguments
  Segmentation fault (core dumped)
  $

Fix it, those stats are in evsel->stats, not anymore in evsel->priv.

Cc Adrian Hunter <[email protected]>
Cc Andi Kleen <[email protected]>
Cc David Ahern <[email protected]>
Cc Hendrik Brueckner <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Wang Nan <[email protected]>
Fixes e669e833da8d ("perf evsel: Restore evsel->priv as a tool private area")
---
 tools/perf/util/evsel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/evsel.c +1 -1
index bfde6a7..d5fbcf8 100644
@@ -1375,7 +1375,7 @@ perf_evsel__process_group_data(struct perf_evsel *leader,
 static int
 perf_evsel__read_group(struct perf_evsel *leader, int cpu, int thread)
 {
-	struct perf_stat_evsel *ps = leader->priv;
+	struct perf_stat_evsel *ps = leader->stats;
 	u64 read_format = leader->attr.read_format;
 	int size = perf_evsel__read_size(leader);
 	u64 *data = ps->group_data;