Skip to contentSkip to conversation

python-numpy: disable for ARCompact

PATCH New Evgeniy Didin 2 participants 4 messages Nov 9, 2017 – Nov 11, 2017

lore
Share & tools
lore
#0 lore raw

cover python-numpy: disable for ARCompact

Python-numpy is not compiling for ARCompact due toolchain issue, so it is necessary to disable this package. Before disabling the layout of BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS variable should be reconstructed to more convenient form. First patch reconstucts layout of this variable, second patch disables python-numpy for ARCompact architecture.

Note this series replaces recently patches which were sent separately.

Cc Alexey Brodkin <[email protected]>
Cc arc-buildroot at synopsys.com
Cc Thomas Petazzoni <[email protected]>

Evgeniy Didin (2):
python-numpy: reformat config
python-numpy: disable for ARCompact

 package/python-numpy/Config.in | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/2 python-numpy: reformat config

Current BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS variable layout going to be inconvenient and ugly for adding new architectures or restricting specific architectures. Lets reformat layout of this variable.

Cc Alexey Brodkin <[email protected]>
Cc arc-buildroot at synopsys.com
Cc Thomas Petazzoni <[email protected]>
---
 package/python-numpy/Config.in | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)
package/python-numpy/Config.in +11 -3
index 859542f584..5abe04bde9 100644
@@ -1,9 +1,17 @@
 config BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS
 	bool
 	# Numpy has some CPU specific code
-	default y if BR2_arc || BR2_aarch64 || BR2_arm || BR2_armeb || BR2_i386 \
-		|| BR2_mips || BR2_mipsel || BR2_powerpc || BR2_powerpc64 \
-		|| BR2_sh || BR2_x86_64
+	default y if BR2_arc 
+	default y if BR2_aarch64
+	default y if BR2_arm 
+	default y if BR2_armeb
+	default y if BR2_i386 
+	default y if BR2_mips
+	default y if BR2_mipsel
+	default y if BR2_powerpc
+	default y if BR2_powerpc64 
+	default y if BR2_sh 
+	default y if BR2_x86_64
 
 config BR2_PACKAGE_PYTHON_NUMPY
 	bool "python-numpy"
Signature · 1 line
2.11.0
#2 lore raw

PATCH v2 2/2 python-numpy: disable for ARCompact

In reply to Evgeniy Didin

This package fails when building for ARCompact due to toolchain issue.

Marking this with special comment "#ARC toolchain issues for ARCompact"
as the package is to be enabled as soon as the issue with the ARC toolchain is resolved. Fixes:

        http://autobuild.buildroot.net/results/4c4/4c4eaa90335756448007ae3c5ae3839fb17d4442//

The same compiler error appears building "trousers" package for ARCompact. This package is already disabled for ARC.

Cc Alexey Brodkin <[email protected]>
Cc arc-buildroot at synopsys.com
Cc Thomas Petazzoni <[email protected]>

---
Changes since v1:
-Removed duplicate entry in BR2_PACKAGE_PYTHON_NUMPY -Now disables python-numpy accordingly to new format

 package/python-numpy/Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/python-numpy/Config.in +2 -1
index 5abe04bde9..1405218b1c 100644
@@ -1,7 +1,8 @@
 config BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS
 	bool
 	# Numpy has some CPU specific code
-	default y if BR2_arc 
+	# ARC toolchain issues for ARCompact
+	default y if BR2_arc && !(BR2_arc770d || BR2_arc750d)
 	default y if BR2_aarch64
 	default y if BR2_arm 
 	default y if BR2_armeb
Signature · 1 line
2.11.0
#3 lore raw

cover python-numpy: disable for ARCompact

In reply to Evgeniy Didin

Hello,

Quoted 3 lines · Evgeniy Didin

Evgeniy Didin (2):
python-numpy: reformat config
python-numpy: disable for ARCompact

Both applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com