Skip to contentSkip to conversation

rsi: rsi_91x_ps: remove redundant code in str_psstate

PATCH In review Gustavo A. R. Silva 2 participants 2 messages Nov 6, 2017 – Nov 10, 2017

Subsystems (3)
Networking Network drivers Redpine wireless driver
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 rsi: rsi_91x_ps: remove redundant code in str_psstate

"INVALID_STATE" is already being returned in the default case and this code cannot be reached.

Addresses-Coverity-ID: 1398384

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/net/wireless/rsi/rsi_91x_ps.c | 1 -
 1 file changed, 1 deletion(-)
drivers/net/wireless/rsi/rsi_91x_ps.c +0 -1
index 523f532..01472fa 100644
@@ -36,7 +36,6 @@ char *str_psstate(enum ps_state state)
 	default:
 		return "INVALID_STATE";
 	}
-	return "INVALID_STATE";
 }
 
 static inline void rsi_modify_ps_state(struct rsi_hw *adapter,
Signature · 1 line
2.7.4
#1 lore raw
Quoted 5 lines · Gustavo A. R. Silva

"INVALID_STATE" is already being returned in the default case and this code cannot be reached.

Addresses-Coverity-ID: 1398384

Signed-off-by Gustavo A. R. Silva <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

4775ae7afec6 rsi: rsi_91x_ps: remove redundant code in str_psstate

Signature · 3 lines
https://patchwork.kernel.org/patch/10044571/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches