Skip to contentSkip to conversation

app/testpmd: remove port status check from TM node add cli

PATCH Applied Jasvinder Singh 3 participants 3 messages Nov 10, 2017 – Nov 11, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 app/testpmd: remove port status check from TM node add cli

Currently, testpmd CLI doesn't permit to add leaf and non-leaf node when port is started. It doesn't work in case of i40e device as DCB configuration is deleted when port is stopped. Therefore, removes the port status check before invoking leaf and nonleaf node API in the cli. If needed, device can add port status check at the driver layer.

---
 app/test-pmd/cmdline_tm.c | 12 ------------
 1 file changed, 12 deletions(-)
app/test-pmd/cmdline_tm.c +0 -12
index 4acef98..803fae4 100644
@@ -1599,12 +1599,6 @@ static void cmd_add_port_tm_nonleaf_node_parsed(void *parsed_result,
 	if (port_id_is_invalid(port_id, ENABLED_WARN))
 		return;
 
-	/* Port status */
-	if (port_is_started(port_id)) {
-		printf(" Port %u not stopped (error)\n", port_id);
-		return;
-	}
-
 	memset(&np, 0, sizeof(struct rte_tm_node_params));
 
 	/* Node parameters */
@@ -1759,12 +1753,6 @@ static void cmd_add_port_tm_leaf_node_parsed(void *parsed_result,
 	if (port_id_is_invalid(port_id, ENABLED_WARN))
 		return;
 
-	/* Port status */
-	if (port_is_started(port_id)) {
-		printf(" Port %u not stopped (error)\n", port_id);
-		return;
-	}
-
 	memset(&np, 0, sizeof(struct rte_tm_node_params));
 
 	/* Node parameters */
Signature · 1 line
2.9.3
Acked-by on v1 1/1
#1 lore raw

Hi,

Quoted 9 lines

-----Original Message-----
From: Singh, Jasvinder
Sent: Friday, November 10, 2017 6:31 PM
To: [email protected]
Cc: Lu, Wenzhuo <[email protected]>; Pei, Yulong <[email protected]>; Yigit, Ferruh <[email protected]>
Subject: [PATCH] app/testpmd: remove port status check from TM node add cli

Quoted 7 lines

Currently, testpmd CLI doesn't permit to add leaf and non-leaf node when port is started. It doesn't work in case of i40e device as DCB configuration is deleted when port is stopped. Therefore, removes the port status check before invoking leaf and nonleaf node API in the cli.
If needed, device can add port status check at the driver layer.

#2 lore raw
Quoted 8 lines
Quoted 7 lines

Currently, testpmd CLI doesn't permit to add leaf and non-leaf node when port is started. It doesn't work in case of i40e device as DCB configuration is deleted when port is stopped. Therefore, removes the port status check before invoking leaf and nonleaf node API in the cli.
If needed, device can add port status check at the driver layer.

Applied, thanks