Skip to contentSkip to conversation

cmd: sf: remove useless pointer assignment

PATCH New Baruch Siach 2 participants 2 messages Nov 9, 2017 – Nov 10, 2017

lore
Share & tools
lore

Baruch Siach

author
#0 lore raw

PATCH 1/1 cmd: sf: remove useless pointer assignment

The 'flash' pointer is assigned unconditionally a few lines below, and is not used before that.

Signed-off-by Baruch Siach <[email protected]>
---
 cmd/sf.c | 1 -
 1 file changed, 1 deletion(-)
cmd/sf.c +0 -1
index f971eec781cc..9be8a89bc84c 100644
@@ -126,7 +126,6 @@ static int do_spi_flash_probe(int argc, char * const argv[])
 	if (!ret) {
 		device_remove(new, DM_REMOVE_NORMAL);
 	}
-	flash = NULL;
 	ret = spi_flash_probe_bus_cs(bus, cs, speed, mode, &new);
 	if (ret) {
 		printf("Failed to initialize SPI flash at %u:%u (error %d)\n",
Signature · 1 line
2.14.2
#1 lore raw

PATCH 1/1 cmd: sf: remove useless pointer assignment

Quoted 20 lines · On Thu, 9 Nov 2017 13:49:59 +0200 Baruch Siach <[email protected]> wrote:

The 'flash' pointer is assigned unconditionally a few lines below, and is not used before that.

Signed-off-by Baruch Siach <[email protected]>
---
 cmd/sf.c | 1 -
 1 file changed, 1 deletion(-)
cmd/sf.c +0 -1
index f971eec781cc..9be8a89bc84c 100644
@@ -126,7 +126,6 @@ static int do_spi_flash_probe(int argc, char *
 const argv[]) if (!ret) {
 		device_remove(new, DM_REMOVE_NORMAL);
 	}
-	flash = NULL;
 	ret = spi_flash_probe_bus_cs(bus, cs, speed, mode, &new);
 	if (ret) {
 		printf("Failed to initialize SPI flash at %u:%u
Quoted 1 line

(error %d)\n",

Reviewed-by Lukasz Majewski <[email protected]>

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171110/a71c9006/attachment.sig>