orangefs: call op_release sooner when creating inodes
Subsystems (2)
Martin Brandenburg
reviewerPATCH 1/1 orangefs: call op_release sooner when creating inodes
Prevents holding an unnecessary op while the kernel processes another op and yields the CPU.
Signed-off-by Martin Brandenburg <[email protected]>
--- fs/orangefs/namei.c | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-)
fs/orangefs/namei.c +15 -9
@@ -21,6 +21,7 @@ static int orangefs_create(struct inode *dir, {struct orangefs_inode_s *parent =ORANGEFS_I (dir);struct orangefs_kernel_op_s *new_op; +struct orangefs_object_kref ref;struct inode *inode;struct iattr iattr;int ret;
@@ -55,8 +56,10 @@ static int orangefs_create(struct inode *dir,if (ret <0 ) goto out; - inode =orangefs_new_inode (dir->i_sb, dir,S_IFREG | mode,0 , - &new_op->downcall.resp.create.refn); + ref = new_op->downcall.resp.create.refn; +op_release (new_op); + + inode =orangefs_new_inode (dir->i_sb, dir,S_IFREG | mode,0 , &ref);if (IS_ERR (inode)) { gossip_err("%s: Failed to allocate inode for file :%pd:\n", __func__,
@@ -89,7 +92,6 @@ static int orangefs_create(struct inode *dir,mark_inode_dirty_sync (dir); ret =0 ; out: -op_release (new_op); gossip_debug(GOSSIP_NAME_DEBUG, "%s: %pd: returning %d\n", __func__,
@@ -271,6 +273,7 @@ static int orangefs_symlink(struct inode *dir, {struct orangefs_inode_s *parent =ORANGEFS_I (dir);struct orangefs_kernel_op_s *new_op; +struct orangefs_object_kref ref;struct inode *inode;struct iattr iattr;int mode =755 ;
@@ -313,8 +316,10 @@ static int orangefs_symlink(struct inode *dir, goto out; } - inode =orangefs_new_inode (dir->i_sb, dir,S_IFLNK | mode,0 , - &new_op->downcall.resp.sym.refn); + ref = new_op->downcall.resp.sym.refn; +op_release (new_op); + + inode =orangefs_new_inode (dir->i_sb, dir,S_IFLNK | mode,0 , &ref);if (IS_ERR (inode)) {gossip_err ("*** Failed to allocate orangefs symlink inode\n" );
@@ -344,7 +349,6 @@ static int orangefs_symlink(struct inode *dir,mark_inode_dirty_sync (dir); ret =0 ; out: -op_release (new_op);return ret; }
@@ -352,6 +356,7 @@ static int orangefs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode {struct orangefs_inode_s *parent =ORANGEFS_I (dir);struct orangefs_kernel_op_s *new_op; +struct orangefs_object_kref ref;struct inode *inode;struct iattr iattr;int ret;
@@ -382,8 +387,10 @@ static int orangefs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode goto out; } - inode =orangefs_new_inode (dir->i_sb, dir,S_IFDIR | mode,0 , - &new_op->downcall.resp.mkdir.refn); + ref = new_op->downcall.resp.mkdir.refn; +op_release (new_op); + + inode =orangefs_new_inode (dir->i_sb, dir,S_IFDIR | mode,0 , &ref);if (IS_ERR (inode)) {gossip_err ("*** Failed to allocate orangefs dir inode\n" ); ret =PTR_ERR (inode);
@@ -415,7 +422,6 @@ static int orangefs_mkdir(struct inode *dir, struct dentry *dentry, umode_t modeorangefs_inode_setattr (dir, &iattr);mark_inode_dirty_sync (dir); out: -op_release (new_op);return ret; }
Signature · 1 line
2.15.0