of: Document exactly what of_find_node_by_name() puts
PATCH 1/1 of: Document exactly what of_find_node_by_name() puts
It isn't clear if this function of_node_put()s the 'from' argument, or the node it finds in the search. Clearly indicate which variable is touched.
--- drivers/of/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/of/base.c +1 -1
@@ -866,7 +866,7 @@ EXPORT_SYMBOL(of_find_node_opts_by_path);* @from: The node to start searching from or NULL, the node * you pass will not be searched, only the next one * will; typically, you pass what the previous call -* returned. of_node_put() will be called on it +* returned. of_node_put() will be called on @from. * @name: The name string to match against * * Returns a node pointer with refcount incremented, use
Signature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
drivers/of/base.c EXPORT_SYMBOL(of_find_node_opts_by_path);> * @from: The node to start searching from or NULL, the node
Quoted 14 lines · Stephen Boyd
It isn't clear if this function of_node_put()s the 'from' argument, or the node it finds in the search. Clearly indicate which variable is touched.
Signed-off-by Stephen Boyd <[email protected]>--- drivers/of/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/of/base.c +0
-0@@ -866,7 +866,7 @@ EXPORT_SYMBOL(of_find_node_opts_by_path);> * @from: The node to start searching from or NULL, the node
* @from: The node to start searching from or %NULL; the node
drivers/of/base.c EXPORT_SYMBOL(of_find_node_opts_by_path); · line 868
Quoted 2 lines
drivers/of/base.c +0
-0* you pass will not be searched, only the next one * will; typically, you pass what the previous call
* will. Typically, you pass what the previous call
Quoted 6 lines
drivers/of/base.c +1
-1-* returned. of_node_put() will be called on it +* returned. of_node_put() will be called on @from. * @name: The name string to match against * * Returns a node pointer with refcount incremented, use
Signature · 1 line
~Randy
Quoted 18 lines · Randy Dunlap
drivers/of/base.c EXPORT_SYMBOL(of_find_node_opts_by_path);> * @from: The node to start searching from or NULL, the node
Quoted 14 lines · Stephen Boyd
It isn't clear if this function of_node_put()s the 'from' argument, or the node it finds in the search. Clearly indicate which variable is touched.
Signed-off-by Stephen Boyd <[email protected]>--- drivers/of/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/of/base.c +0
-0@@ -866,7 +866,7 @@ EXPORT_SYMBOL(of_find_node_opts_by_path);> * @from: The node to start searching from or NULL, the node* @from: The node to start searching from or %NULL; the node
Quoted 5 lines
drivers/of/base.c EXPORT_SYMBOL(of_find_node_opts_by_path); · line 868
Quoted 2 lines
drivers/of/base.c +0
-0* you pass will not be searched, only the next one * will; typically, you pass what the previous call * will. Typically, you pass what the previous call
Rob, do you want me to fold this in?
Signature · 6 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 19 lines · Stephen Boyd
Quoted 18 lines · Randy Dunlap
drivers/of/base.c EXPORT_SYMBOL(of_find_node_opts_by_path);> * @from: The node to start searching from or NULL, the node
Quoted 14 lines · Stephen Boyd
It isn't clear if this function of_node_put()s the 'from' argument, or the node it finds in the search. Clearly indicate which variable is touched.
Signed-off-by Stephen Boyd <[email protected]>--- drivers/of/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/of/base.c +0
-0@@ -866,7 +866,7 @@ EXPORT_SYMBOL(of_find_node_opts_by_path);> * @from: The node to start searching from or NULL, the node* @from: The node to start searching from or %NULL; the node
Quoted 7 lines
Quoted 5 lines
drivers/of/base.c EXPORT_SYMBOL(of_find_node_opts_by_path); · line 868
Quoted 2 lines
drivers/of/base.c +0
-0* you pass will not be searched, only the next one * will; typically, you pass what the previous call * will. Typically, you pass what the previous call
Rob, do you want me to fold this in?
Yes, please.
Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html