Skip to contentSkip to conversation

omap3-n900: enable autofocus

PATCH In review Pavel Machek 3 participants 4 messages Nov 12, 2017 – Nov 13, 2017 Device tree bindings

lore
Share & tools
lore

Pavel Machek

author
#0 lore raw

PATCH 1/1 omap3-n900: enable autofocus

Connect auto-focus coil to the camera sensor, so that it can be used by camera applications.

Signed-off-by Pavel Machek <[email protected]>
arch/arm/boot/dts/omap3-n900.dts +2 -0
index 669c51c..59cc743 100644
@@ -778,6 +778,8 @@
 
 		reset-gpio = <&gpio4 6 GPIO_ACTIVE_HIGH>; /* 102 */
 
+		lens-focus = <&ad5820>;
+
 		port {
 			csi_cam1: endpoint {
 				bus-type = <3>; /* CCP2 */
Signature · 9 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20171112/2c191d7b/attachment.sig>
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · On Sunday 12 November 2017 12:25:29 Pavel Machek wrote:

Connect auto-focus coil to the camera sensor, so that it can be used by camera applications.

Signed-off-by Pavel Machek <[email protected]>
Acked-by Pali Roh?r <[email protected]>
Quoted 14 lines
arch/arm/boot/dts/omap3-n900.dts +2 -0
index 669c51c..59cc743 100644
@@ -778,6 +778,8 @@
 
 		reset-gpio = <&gpio4 6 GPIO_ACTIVE_HIGH>; /* 102 */
 
+		lens-focus = <&ad5820>;
+
 		port {
 			csi_cam1: endpoint {
 				bus-type = <3>; /* CCP2 */
Signature · 2 lines
Pali Roh?r
pali.rohar at gmail.com
Reviewed-by on v1 1/1
#2 lore raw
In reply to Pavel Machek

Hi,

Quoted 5 lines · Pavel Machek

Connect auto-focus coil to the camera sensor, so that it can be used by camera applications.

Signed-off-by Pavel Machek <[email protected]>

I think you should replace auto-focus with lens-focus. This is not automatic. Otherwise:

Reviewed-by Sebastian Reichel <[email protected]>

-- Sebastian

Quoted 17 lines
arch/arm/boot/dts/omap3-n900.dts +2 -0
index 669c51c..59cc743 100644
@@ -778,6 +778,8 @@
 
 		reset-gpio = <&gpio4 6 GPIO_ACTIVE_HIGH>; /* 102 */
 
+		lens-focus = <&ad5820>;
+
 		port {
 			csi_cam1: endpoint {
 				bus-type = <3>; /* CCP2 */
Signature · 3 lines
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20171112/8566b3fa/attachment.sig>

author
#3 lore raw
Quoted 11 lines · Sebastian Reichel

Hi,

Quoted 5 lines · Pavel Machek

Connect auto-focus coil to the camera sensor, so that it can be used by camera applications.

Signed-off-by Pavel Machek <[email protected]>

I think you should replace auto-focus with lens-focus. This is not automatic. Otherwise:

You are right... althrough the lens is really meant for auto-focus.

Anyway, I can send the updated patch if neccessary.

Best regards,
Pavel

Signature · 9 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20171113/202e3be5/attachment.sig>