perf help: Document missing options

Cc Jiri Olsa <[email protected]>

Cc Namhyung Kim <[email protected]>

Signed-off-by Sihyeon Jang <[email protected]>

---
 tools/perf/Documentation/perf-top.txt | 6 ++++++
 1 file changed, 6 insertions(+)

tools/perf/Documentation/perf-top.txt +6 -0

index 4353262..8a32cc7 100644
@@ -268,6 +268,12 @@ INTERACTIVE PROMPTING KEYS
 [S]::
 	Stop annotation, return to full profile display.
 
+[K]::
+	Hide kernel symbols.
+
+[U]::
+	Hide user symbols.
+
 [z]::
 	Toggle event count zeroing across display updates.
 

Signature · 1 line

2.7.4

Cc Jiri Olsa <[email protected]>

Cc Namhyung Kim <[email protected]>

Signed-off-by Sihyeon Jang <[email protected]>

---
 tools/perf/builtin-top.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

tools/perf/builtin-top.c +1 -1

index adfeeb4..6fe5001 100644
@@ -409,7 +409,7 @@ static void perf_top__print_mapped_keys(struct perf_top *top)
 	fprintf(stdout, "\t[S]     stop annotation.\n");
 
 	fprintf(stdout,
-		"\t[K]     hide kernel_symbols symbols.     \t(%s)\n",
+		"\t[K]     hide kernel symbols.             \t(%s)\n",
 		top->hide_kernel_symbols ? "yes" : "no");
 	fprintf(stdout,
 		"\t[U]     hide user symbols.               \t(%s)\n",

Signature · 1 line

2.7.4

Cc Jiri Olsa <[email protected]>

Cc Namhyung Kim <[email protected]>

Signed-off-by Sihyeon Jang <[email protected]>

---
 tools/perf/Documentation/perf-help.txt | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

tools/perf/Documentation/perf-help.txt +0 -0

index 5143918..bb605af 100644

tools/perf/Documentation/perf-help.txt +12 -0

 DESCRIPTION
 -----------

@@ -33,6 +33,18 @@ OPTIONS
 	Prints all the available commands on the standard output. This
 	option supersedes any other option.
 
+-i::
+--info::
+	Shows info page.
+
+-m::
+--man::
+	Shows man page.
+
+-w::
+--web::
+	Shows manual in web browser.
+
 PERF
 ----
 Part of the linkperf:perf[1] suite

Signature · 1 line

2.7.4

Em Sun, Nov 12, 2017 at 10:10:45AM +0900, Sihyeon Jang escreveu:

Quoted 13 lines

Cc Jiri Olsa <[email protected]>

Cc Namhyung Kim <[email protected]>

Signed-off-by Sihyeon Jang <[email protected]>

---
 tools/perf/Documentation/perf-help.txt | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

tools/perf/Documentation/perf-help.txt +0 -0

index 5143918..bb605af 100644
@@ -7,7 +7,7 @@ perf-help - display help information about perf
 

tools/perf/Documentation/perf-help.txt perf-help - display help information about perf · line 10

Quoted 4 lines

tools/perf/Documentation/perf-help.txt +1 -1

 SYNOPSIS
 --------
-'perf help' [-a|--all] [COMMAND]
+'perf help' [--all] [--man|--web|--info] [COMMAND]

Can you try figuring out if this actually works? I tried here and it doesn't, its an area we took "for free" when we copied the initial codebase from git.git, but I never looked at this area that much, now that I try:

[acme@jouet linux]$ perf help
Config with no key for man viewer: childrenError: wrong config key-value pair top.children=true [acme@jouet linux]$

Unsure if this is something that got broken by the 'perf config' patches, Taeung?

From 096b78b437b5758acc025498e88d73d9d471b3c0 Mon Sep 17 00:00:00 2001

Hi Arnaldo,

Quoted 14 lines · Arnaldo Carvalho de Melo

Em Sun, Nov 12, 2017 at 10:10:45AM +0900, Sihyeon Jang escreveu:

Quoted 13 lines

Cc Jiri Olsa <[email protected]>

Cc Namhyung Kim <[email protected]>

Signed-off-by Sihyeon Jang <[email protected]>

---
  tools/perf/Documentation/perf-help.txt | 14 +++++++++++++-
  1 file changed, 13 insertions(+), 1 deletion(-)

tools/perf/Documentation/perf-help.txt +0 -0

index 5143918..bb605af 100644
@@ -7,7 +7,7 @@ perf-help - display help information about perf
 

Quoted 9 lines

tools/perf/Documentation/perf-help.txt perf-help - display help information about perf · line 10

Quoted 4 lines

tools/perf/Documentation/perf-help.txt +1 -1

  SYNOPSIS
  --------
-'perf help' [-a|--all] [COMMAND]
+'perf help' [--all] [--man|--web|--info] [COMMAND]

Can you try figuring out if this actually works? I tried here and it doesn't, its an area we took "for free" when we copied the initial codebase from git.git, but I never looked at this area that much, now that I try:

Yeah, I'm not sure we need to keep it.

Quoted 7 lines

[acme@jouet linux]$ perf help
Config with no key for man viewer: childrenError: wrong config key-value pair top.children=true [acme@jouet linux]$

Unsure if this is something that got broken by the 'perf config' patches, Taeung?

Looks like a bug in 8e99b6d4533c ("tools include: Adopt strstarts() from the kernel").

Following patch should fix it:

Thanks,
Namhyung

From 096b78b437b5758acc025498e88d73d9d471b3c0 Mon Sep 17 00:00:00 2001
From: Namhyung Kim <[email protected]>
Date: Tue, 14 Nov 2017 09:10:43 +0900
Subject: [PATCH] perf help: Fix a bug during strstart() conversion

The commit 8e99b6d4533c changed prefixcmp() to strstart() but missed to change the return value in some place. It makes perf help print annoying output even for sane config items like below:

   $ perf help
   '.root': unsupported man viewer sub key.
   ...

Fixes 8e99b6d4533c ("tools include: Adopt strstarts() from the kernel")

Cc Taeung Song <[email protected]>

Signed-off-by Namhyung Kim <[email protected]>

---
  tools/perf/builtin-help.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

tools/perf/builtin-help.c +2 -2

index dbe4e4153bcf..ff51e5fc0daf 100644
@@ -283,7 +283,7 @@ static int perf_help_config(const char *var, const char *value, void *cb)
  		add_man_viewer(value);
  		return 0;
  	}
-	if (!strstarts(var, "man."))
+	if (strstarts(var, "man."))
  		return add_man_viewer_info(var, value);
 
  	return 0;

@@ -313,7 +313,7 @@ static const char *cmd_to_page(const char *perf_cmd)
 
  	if (!perf_cmd)
  		return "perf";
-	else if (!strstarts(perf_cmd, "perf"))
+	else if (strstarts(perf_cmd, "perf"))
  		return perf_cmd;
 
  	return asprintf(&s, "perf-%s", perf_cmd) < 0 ? NULL : s;

Hi Arnaldo and Namhyung :)

Quoted 40 lines · Namhyung Kim

Hi Arnaldo,

Quoted 8 lines · Arnaldo Carvalho de Melo

Em Sun, Nov 12, 2017 at 10:10:45AM +0900, Sihyeon Jang escreveu:

Quoted 7 lines

Cc Jiri Olsa <[email protected]>

Cc Namhyung Kim <[email protected]>

Signed-off-by Sihyeon Jang <[email protected]>

---
  tools/perf/Documentation/perf-help.txt | 14 +++++++++++++-
  1 file changed, 13 insertions(+), 1 deletion(-)

Quoted 14 lines

tools/perf/Documentation/perf-help.txt perf-help - display help information about perf · line 9

Quoted 9 lines

tools/perf/Documentation/perf-help.txt +1 -1

index 5143918..bb605af 100644
@@ -7,7 +7,7 @@ perf-help - display help information about perf
  SYNOPSIS
  --------
-'perf help' [-a|--all] [COMMAND]
+'perf help' [--all] [--man|--web|--info] [COMMAND]

Can you try figuring out if this actually works? I tried here and it doesn't, its an area we took "for free" when we copied the initial codebase from git.git, but I never looked at this area that much, now that I try:

Yeah, I'm not sure we need to keep it.

Quoted 7 lines

[acme@jouet linux]$ perf help
Config with no key for man viewer: childrenError: wrong config key-value pair top.children=true [acme@jouet linux]$

Unsure if this is something that got broken by the 'perf config' patches, Taeung?

Looks like a bug in 8e99b6d4533c ("tools include: Adopt strstarts() from the kernel").

Quoted 4 lines

Following patch should fix it:

Thanks,
Namhyung

I also checked this error and test the below patch. It seems that Namhyung already fixes it !!

Thanks,
Taeung

Quoted 42 lines

From 096b78b437b5758acc025498e88d73d9d471b3c0 Mon Sep 17 00:00:00 2001
From: Namhyung Kim <[email protected]>
Date: Tue, 14 Nov 2017 09:10:43 +0900
Subject: [PATCH] perf help: Fix a bug during strstart() conversion

The commit 8e99b6d4533c changed prefixcmp() to strstart() but missed to change the return value in some place. It makes perf help print annoying output even for sane config items like below:

   $ perf help
   '.root': unsupported man viewer sub key.
   ...

Fixes 8e99b6d4533c ("tools include: Adopt strstarts() from the kernel")

Cc Taeung Song <[email protected]>

Signed-off-by Namhyung Kim <[email protected]>

---
  tools/perf/builtin-help.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

tools/perf/builtin-help.c +2 -2

index dbe4e4153bcf..ff51e5fc0daf 100644
@@ -283,7 +283,7 @@ static int perf_help_config(const char *var, const char *value, void *cb)
  		add_man_viewer(value);
  		return 0;
  	}
-	if (!strstarts(var, "man."))
+	if (strstarts(var, "man."))
  		return add_man_viewer_info(var, value);
  	return 0;

@@ -313,7 +313,7 @@ static const char *cmd_to_page(const char *perf_cmd)
  	if (!perf_cmd)
  		return "perf";
-	else if (!strstarts(perf_cmd, "perf"))
+	else if (strstarts(perf_cmd, "perf"))
  		return perf_cmd;
  	return asprintf(&s, "perf-%s", perf_cmd) < 0 ? NULL : s;
 

Hi Arnaldo,

Quoted 14 lines · Arnaldo Carvalho de Melo

Em Sun, Nov 12, 2017 at 10:10:45AM +0900, Sihyeon Jang escreveu:

Quoted 13 lines

Cc Jiri Olsa <[email protected]>

Cc Namhyung Kim <[email protected]>

Signed-off-by Sihyeon Jang <[email protected]>

---
 tools/perf/Documentation/perf-help.txt | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

tools/perf/Documentation/perf-help.txt +0 -0

index 5143918..bb605af 100644
@@ -7,7 +7,7 @@ perf-help - display help information about perf
 

Quoted 9 lines

tools/perf/Documentation/perf-help.txt perf-help - display help information about perf · line 10

Quoted 4 lines

tools/perf/Documentation/perf-help.txt +1 -1

 SYNOPSIS
 --------
-'perf help' [-a|--all] [COMMAND]
+'perf help' [--all] [--man|--web|--info] [COMMAND]

Can you try figuring out if this actually works? I tried here and it doesn't, its an area we took "for free" when we copied the initial codebase from git.git, but I never looked at this area that much, now that I try:

Yeah, I'm not sure we need to keep it.

Quoted 5 lines

[acme@jouet linux]$ perf help
Config with no key for man viewer: childrenError: wrong config key-value pair top.children=true [acme@jouet linux]$

Quoted 2 lines

Unsure if this is something that got broken by the 'perf config' patches, Taeung?

Looks like a bug in 8e99b6d4533c ("tools include: Adopt strstarts() from the kernel").

Following patch should fix it:

Thanks,
Namhyung

Quoted 1 line

From 096b78b437b5758acc025498e88d73d9d471b3c0 Mon Sep 17 00:00:00 2001

From: Namhyung Kim <[email protected]>
Date: Tue, 14 Nov 2017 09:10:43 +0900
Subject: [PATCH] perf help: Fix a bug during strstart() conversion

The commit 8e99b6d4533c changed prefixcmp() to strstart() but missed to change the return value in some place. It makes perf help print annoying output even for sane config items like below:

  $ perf help
  '.root': unsupported man viewer sub key.
  ...

Fixes 8e99b6d4533c ("tools include: Adopt strstarts() from the kernel")

Cc Taeung Song <[email protected]>

Signed-off-by Namhyung Kim <[email protected]>

---
 tools/perf/builtin-help.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

tools/perf/builtin-help.c +2 -2

index dbe4e4153bcf..ff51e5fc0daf 100644
@@ -283,7 +283,7 @@ static int perf_help_config(const char *var, const char *value, void *cb)
 		add_man_viewer(value);
 		return 0;
 	}
-	if (!strstarts(var, "man."))
+	if (strstarts(var, "man."))
 		return add_man_viewer_info(var, value);
 
 	return 0;

@@ -313,7 +313,7 @@ static const char *cmd_to_page(const char *perf_cmd)
 
 	if (!perf_cmd)
 		return "perf";
-	else if (!strstarts(perf_cmd, "perf"))
+	else if (strstarts(perf_cmd, "perf"))
 		return perf_cmd;
 
 	return asprintf(&s, "perf-%s", perf_cmd) < 0 ? NULL : s;

Signature · 1 line

2.15.0