Skip to contentSkip to conversation

staging: pi433: pi433_if.c: fix if/else if and brace coding style issues

PATCH In review Chase Metzger 2 participants 2 messages Nov 14, 2017 – Nov 28, 2017 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: pi433: pi433_if.c: fix if/else if and brace coding style issues

Fix if/else if and braces in function DIO0_irq_handler to comply with the kernel coding style.

---
 drivers/staging/pi433/pi433_if.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
drivers/staging/pi433/pi433_if.c +3 -8
index d946838450d4..dee70c47629c 100644
@@ -133,19 +133,14 @@ static irqreturn_t DIO0_irq_handler(int irq, void *dev_id)
 {
 	struct pi433_device *device = dev_id;
 
-	if      (device->irq_state[DIO0] == DIO_PacketSent)
-	{
+	if      (device->irq_state[DIO0] == DIO_PacketSent) {
 		device->free_in_fifo = FIFO_SIZE;
 		dev_dbg(device->dev, "DIO0 irq: Packet sent\n");
 		wake_up_interruptible(&device->fifo_wait_queue);
-	}
-	else if (device->irq_state[DIO0] == DIO_Rssi_DIO0)
-	{
+	} else if (device->irq_state[DIO0] == DIO_Rssi_DIO0) {
 		dev_dbg(device->dev, "DIO0 irq: RSSI level over threshold\n");
 		wake_up_interruptible(&device->rx_wait_queue);
-	}
-	else if (device->irq_state[DIO0] == DIO_PayloadReady)
-	{
+	} else if (device->irq_state[DIO0] == DIO_PayloadReady) {
 		dev_dbg(device->dev, "DIO0 irq: PayloadReady\n");
 		device->free_in_fifo = 0;
 		wake_up_interruptible(&device->fifo_wait_queue);
Signature · 1 line
2.11.0
maintainer
#1 lore raw
Quoted 13 lines · Chase Metzger

Fix if/else if and braces in function DIO0_irq_handler to comply with the kernel coding style.

---
 drivers/staging/pi433/pi433_if.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
drivers/staging/pi433/pi433_if.c +0 -0
index d946838450d4..dee70c47629c 100644

drivers/staging/pi433/pi433_if.c static irqreturn_t DIO0_irq_handler(int irq, void *dev_id) · line 136

Quoted 6 lines
drivers/staging/pi433/pi433_if.c +1 -2
@@ -133,19 +133,14 @@ static irqreturn_t DIO0_irq_handler(int irq, void *dev_id)
 {
 	struct pi433_device *device = dev_id;
 
-	if      (device->irq_state[DIO0] == DIO_PacketSent)
-	{
+	if      (device->irq_state[DIO0] == DIO_PacketSent) {

When you are touching the line, be sure to fix the obvious space issue here as well.

thanks,

greg k-h