Skip to contentSkip to conversation

net-tools: correctly set COPTS and LOPTS

PATCH New Joe Slater 1 participant 1 message Nov 14, 2017

lore
Share & tools
lore

Joe Slater

author
#0 lore raw

PATCH 1/1 net-tools: correctly set COPTS and LOPTS

COPTS will be ignored if it is defined in the environment. It must be passed directly to make. To be consistent, we pass LOPTS that way, too.

---
 meta/recipes-extended/net-tools/net-tools_1.60-26.bb | 14 +++-----------
 1 file changed, 3 insertions(+), 11 deletions(-)
meta/recipes-extended/net-tools/net-tools_1.60-26.bb +3 -11
index c23d533..69c9af3 100644
@@ -81,20 +81,12 @@ do_configure() {
 
 do_compile() {
 	# net-tools use COPTS/LOPTS to allow adding custom options
-	export COPTS="$CFLAGS"
-	export LOPTS="$LDFLAGS"
-	unset CFLAGS
-	unset LDFLAGS
-
-	oe_runmake
+	oe_runmake COPTS="$CFLAGS" LOPTS="$LDFLAGS"
 }
 
 do_install() {
-	export COPTS="$CFLAGS"
-	export LOPTS="$LDFLAGS"
-	unset CFLAGS
-	unset LDFLAGS
-	oe_runmake 'BASEDIR=${D}' install
+	# We don't need COPTS or LOPTS, but let's be consistent.
+	oe_runmake COPTS="$CFLAGS" LOPTS="$LDFLAGS" 'BASEDIR=${D}' install
 
 	if [ "${base_bindir}" != "/bin" ]; then
 		mkdir -p ${D}/${base_bindir}
Signature · 1 line
2.7.4