Skip to contentSkip to conversation

ca-certificates: Add /etc to SYSROOT_DIRS

PATCH In review Patrick Vacek 3 participants 4 messages Nov 15, 2017 – Jul 6, 2018

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ca-certificates: Add /etc to SYSROOT_DIRS

From: Patrick Vacek <[email protected]>

For recipes that depend on native ca-certificates.crt, /etc should be added to the list of directories that automatically populate the sysroot, otherwise the file may not be there.

---
 meta/recipes-support/ca-certificates/ca-certificates_20170717.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-support/ca-certificates/ca-certificates_20170717.bb +1 -0
index 59e7d51437..52a1a07f68 100644
@@ -24,6 +24,7 @@ SRC_URI = "git://anonscm.debian.org/collab-maint/ca-certificates.git \
            file://sbindir.patch"
 
 S = "${WORKDIR}/git"
+SYSROOT_DIRS_class-native += "${sysconfdir}"
 
 inherit allarch
 
Signature · 1 line
2.11.0
#1 lore raw
Quoted 16 lines · Patrick Vacek

From: Patrick Vacek <[email protected]>

For recipes that depend on native ca-certificates.crt, /etc should be added to the list of directories that automatically populate the sysroot, otherwise the file may not be there.

---
 meta/recipes-support/ca-certificates/ca-certificates_20170717.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-support/ca-certificates/ca-certificates_20170717.bb +0 -0
index 59e7d51437..52a1a07f68 100644

meta/recipes-support/ca-certificates/ca-certificates_20170717.bb SRC_URI = "git://anonscm.debian.org/collab-maint/ca-certificates.git \ · line 27

Quoted 4 lines
meta/recipes-support/ca-certificates/ca-certificates_20170717.bb +1 -0
@@ -24,6 +24,7 @@ SRC_URI = "git://anonscm.debian.org/collab-maint/ca-certificates.git \
            file://sbindir.patch"
 
 S = "${WORKDIR}/git"
+SYSROOT_DIRS_class-native += "${sysconfdir}"

This change has now been merged, but unfortunately it looks wrong. This use of += with an over-ride doesn't achieve what you describe in the commit message (the += will append "${sysconfdir}" to the over-ride value and then the over-ride value will COMPLETELY REPLACE the original value of SYSROOT_DIRS, not add to it).

The change also appears to be unnecessary as ${sysconfdir} is appended to SYSROOT_DIRS for -native recipes by default (via SYSROOT_DIRS_NATIVE in staging.bbclass).

Exactly what issue were you trying to solve?

Quoted 11 lines
meta/recipes-support/ca-certificates/ca-certificates_20170717.bb +0 -1
 inherit allarch
 
--

2.11.0

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#2 lore raw

There's no problem in reverting the change, if there is no real need for it, just in case.

Alex

2018-07-06 5:28 GMT+02:00 Andre McCurdy <[email protected]>:

Quoted 51 lines
Quoted 16 lines · Patrick Vacek

From: Patrick Vacek <[email protected]>

For recipes that depend on native ca-certificates.crt, /etc should be added to the list of directories that automatically populate the sysroot, otherwise the file may not be there.

---
 meta/recipes-support/ca-certificates/ca-certificates_20170717.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-support/ca-certificates/ca-certificates_20170717.bb +0 -0
index 59e7d51437..52a1a07f68 100644

meta/recipes-support/ca-certificates/ca-certificates_20170717.bb SRC_URI = "git://anonscm.debian.org/collab-maint/ca-certificates.git \ · line 27

Quoted 4 lines
meta/recipes-support/ca-certificates/ca-certificates_20170717.bb +1 -0
@@ -24,6 +24,7 @@ SRC_URI = "git://anonscm.debian.org/collab-maint/ca-certificates.git \
            file://sbindir.patch"
 
 S = "${WORKDIR}/git"
+SYSROOT_DIRS_class-native += "${sysconfdir}"

This change has now been merged, but unfortunately it looks wrong. This use of += with an over-ride doesn't achieve what you describe in the commit message (the += will append "${sysconfdir}" to the over-ride value and then the over-ride value will COMPLETELY REPLACE the original value of SYSROOT_DIRS, not add to it).

The change also appears to be unnecessary as ${sysconfdir} is appended to SYSROOT_DIRS for -native recipes by default (via SYSROOT_DIRS_NATIVE in staging.bbclass).

Exactly what issue were you trying to solve?

Quoted 11 lines
meta/recipes-support/ca-certificates/ca-certificates_20170717.bb +0 -1
 inherit allarch
 
--

2.11.0

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#3 lore raw

Patrick's email is no longer valid, so we should probably just do the revert without expecting a clarification.

Alex

2018-07-06 6:57 GMT+02:00 Alexander Kanavin <[email protected]>:

Quoted 57 lines

There's no problem in reverting the change, if there is no real need for it, just in case.

Alex

2018-07-06 5:28 GMT+02:00 Andre McCurdy <[email protected]>:

Quoted 51 lines
Quoted 16 lines · Patrick Vacek

From: Patrick Vacek <[email protected]>

For recipes that depend on native ca-certificates.crt, /etc should be added to the list of directories that automatically populate the sysroot, otherwise the file may not be there.

---
 meta/recipes-support/ca-certificates/ca-certificates_20170717.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-support/ca-certificates/ca-certificates_20170717.bb +0 -0
index 59e7d51437..52a1a07f68 100644

meta/recipes-support/ca-certificates/ca-certificates_20170717.bb SRC_URI = "git://anonscm.debian.org/collab-maint/ca-certificates.git \ · line 27

Quoted 4 lines
meta/recipes-support/ca-certificates/ca-certificates_20170717.bb +1 -0
@@ -24,6 +24,7 @@ SRC_URI = "git://anonscm.debian.org/collab-maint/ca-certificates.git \
            file://sbindir.patch"
 
 S = "${WORKDIR}/git"
+SYSROOT_DIRS_class-native += "${sysconfdir}"

This change has now been merged, but unfortunately it looks wrong. This use of += with an over-ride doesn't achieve what you describe in the commit message (the += will append "${sysconfdir}" to the over-ride value and then the over-ride value will COMPLETELY REPLACE the original value of SYSROOT_DIRS, not add to it).

The change also appears to be unnecessary as ${sysconfdir} is appended to SYSROOT_DIRS for -native recipes by default (via SYSROOT_DIRS_NATIVE in staging.bbclass).

Exactly what issue were you trying to solve?

Quoted 11 lines
meta/recipes-support/ca-certificates/ca-certificates_20170717.bb +0 -1
 inherit allarch
 
--

2.11.0

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core