Skip to contentSkip to conversation

layer.conf: exclude libarchive (bsdtar) dependency from swupd-client

PATCH In review André Draszik 2 participants 3 messages Nov 16, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 layer.conf: exclude libarchive (bsdtar) dependency from swupd-client

From: André Draszik <[email protected]>

The swupd-client doesn't need to be rebuilt if libarchive changes, because swupd-client just invokes the command line utility bsdtar from the libarchive recipe, it doesn't link against libarchive.
The bsdtar binary changing doesn't matter, as bsdtar's ABI (command line argument handling) wouldn't be changing.

---
 conf/layer.conf | 1 +
 1 file changed, 1 insertion(+)
conf/layer.conf +1 -0
index 50e7558..3af6992 100644
@@ -14,4 +14,5 @@ LAYERVERSION_meta-swupd = "1"
 SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += "\
   oe-swupd-helpers->bash \
   oe-swupd-helpers->busybox \
+  swupd-client->libarchive \
 "
Signature · 1 line
2.15.0.rc1
#1 lore raw
Quoted 19 lines · André Draszik

From: André Draszik <[email protected]>

The swupd-client doesn't need to be rebuilt if libarchive changes, because swupd-client just invokes the command line utility bsdtar from the libarchive recipe, it doesn't link against libarchive.
The bsdtar binary changing doesn't matter, as bsdtar's ABI (command line argument handling) wouldn't be changing.

---
 conf/layer.conf | 1 +
 1 file changed, 1 insertion(+)
conf/layer.conf +0 -0
index 50e7558..3af6992 100644

conf/layer.conf LAYERVERSION_meta-swupd = "1" · line 18

Quoted 5 lines
conf/layer.conf +1 -0
@@ -14,4 +14,5 @@ LAYERVERSION_meta-swupd = "1"
 SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += "\
   oe-swupd-helpers->bash \
   oe-swupd-helpers->busybox \
+  swupd-client->libarchive \
 "

I hope I understood the description of SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS correctly...

Cheers,
Andre'

#2 lore raw
In reply to André Draszik
Quoted 8 lines · André Draszik

From: André Draszik <[email protected]>

The swupd-client doesn't need to be rebuilt if libarchive changes, because swupd-client just invokes the command line utility bsdtar from the libarchive recipe, it doesn't link against libarchive.
The bsdtar binary changing doesn't matter, as bsdtar's ABI (command line argument handling) wouldn't be changing.

This is about to change:
https://github.com/clearlinux/swupd-client/issues/285 is being workedon, see
https://github.com/clearlinux/swupd-client/pull/327

Quoted 14 lines

---
 conf/layer.conf | 1 +

 1 file changed, 1 insertion(+)
conf/layer.conf +1 -0
index 50e7558..3af6992 100644
@@ -14,4 +14,5 @@ LAYERVERSION_meta-swupd = "1"
  SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += "\
    oe-swupd-helpers->bash \
    oe-swupd-helpers->busybox \
+  swupd-client->libarchive \
Quoted 1 line

 "

For now this change is okay.

I just have one general problem: I'm not sure whether I should consider myself the maintainer who merges this. I know that I am listed as "tentative" maintainer, but it practice it hasn't been my job and I don't have time for it in my spare time either.

I did some work with swupd again recently, resulting in https://github.
com/pohly/meta-swupd/commits/master and https://github.com/intel/intel-
iot-refkit/pull/318, but that's just a temporary activity.

I understand that this isn't a tenable situation for those of you using meta-swupd; hopefully by the end of the year at the latest it'll be resolved.

Signature · 6 lines
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.