Skip to contentSkip to conversation

package/feh: Fix build issue with some older cross-compilers

PATCH New Petr Vorel 2 participants 4 messages Nov 16, 2017 – Dec 1, 2017

lore
Share & tools
lore

Petr Vorel

author
#0 lore raw

PATCH v3 1/3 package/feh: Fix build issue with some older cross-compilers

by adding -std=gnu99 to CFLAGS.

Fixes:
http://autobuild.buildroot.net/results/392b58cca2671e206c85a530221ce7b2d42f31fb/
http://autobuild.buildroot.net/results/94527fcd70fa85298c366537013c939534beead0/
http://autobuild.buildroot.net/results/bf31199cdaa18971a9b599c26fbefac73b2d6f30/
http://autobuild.buildroot.net/results/5b65c305b50664e02d5f8022278055c80739342d/
http://autobuild.buildroot.net/results/ed3b9fb8d09cd677af4b8825566877c552926ae5/

Signed-off-by Petr Vorel <[email protected]>
---
 package/feh/feh.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/feh/feh.mk +2 -2
index 3f4c410440..7211dc7bdd 100644
@@ -12,8 +12,8 @@ FEH_LICENSE = MIT
 FEH_LICENSE_FILES = COPYING
 
 define FEH_BUILD_CMDS
-	$(TARGET_MAKE_ENV) $(MAKE1) CC="$(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS)" \
-		-C $(@D) all
+	$(TARGET_MAKE_ENV) CFLAGS="$(TARGET_CFLAGS) -std=gnu99" $(MAKE1) \
+		CC="$(TARGET_CC) $(TARGET_LDFLAGS)" -C $(@D) all
 endef
 
 define FEH_INSTALL_TARGET_CMDS
Signature · 1 line
2.15.0
author
#1 lore raw

PATCH v3 2/3 package/feh: Cleanup build configuration

* build in parallel
* use TARGET_CONFIGURE_OPTS
* cleanup FEH_INSTALL_TARGET_CMDS

Signed-off-by Petr Vorel <[email protected]>
---
 package/feh/feh.mk | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
package/feh/feh.mk +3 -4
index 7211dc7bdd..3442f57197 100644
@@ -12,13 +12,12 @@ FEH_LICENSE = MIT
 FEH_LICENSE_FILES = COPYING
 
 define FEH_BUILD_CMDS
-	$(TARGET_MAKE_ENV) CFLAGS="$(TARGET_CFLAGS) -std=gnu99" $(MAKE1) \
-		CC="$(TARGET_CC) $(TARGET_LDFLAGS)" -C $(@D) all
+	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) CFLAGS="$(TARGET_CFLAGS) -std=gnu99" \
+		$(MAKE) -C $(@D) all
 endef
 
 define FEH_INSTALL_TARGET_CMDS
-	$(TARGET_MAKE_ENV) $(MAKE1) CC="$(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS) " \
-		PREFIX=/usr DESTDIR=$(TARGET_DIR) -C $(@D) install
+	$(TARGET_MAKE_ENV) $(MAKE) PREFIX=/usr DESTDIR=$(TARGET_DIR) -C $(@D) install
 endef
 
 $(eval $(generic-package))
Signature · 1 line
2.15.0
author
#2 lore raw

PATCH v3 3/3 package/feh: Bump to version 2.22.2

In reply to Petr Vorel
Signed-off-by Petr Vorel <[email protected]>
---
 package/feh/feh.hash | 2 +-
 package/feh/feh.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/feh/feh.hash +1 -1
index f3f7ceddd9..0f8ac8c0b0 100644
@@ -1,2 +1,2 @@
 # Locally calculated after checking pgp signature
-sha256 520481c9908d999f8f7546103b78ff9b11f41d25b0938f0a22f10aaa48beef2b  feh-2.21.tar.bz2
+sha256 05a81fbe0997f6274c7617efc351647be38e5244c2624bd203459025c9a68ecd  feh-2.22.2.tar.bz2
package/feh/feh.mk +1 -1
index 3442f57197..311cef3afb 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-FEH_VERSION = 2.21
+FEH_VERSION = 2.22.2
 FEH_SOURCE = feh-$(FEH_VERSION).tar.bz2
 FEH_SITE = http://feh.finalrewind.org
 FEH_DEPENDENCIES = libcurl imlib2 libpng xlib_libXinerama xlib_libXt
Signature · 1 line
2.15.0
#3 lore raw

PATCH v3 1/3 package/feh: Fix build issue with some older cross-compilers

In reply to Petr Vorel

Hello,

Quoted 9 lines · Petr Vorel

by adding -std=gnu99 to CFLAGS.

Fixes:
http://autobuild.buildroot.net/results/392b58cca2671e206c85a530221ce7b2d42f31fb/
http://autobuild.buildroot.net/results/94527fcd70fa85298c366537013c939534beead0/
http://autobuild.buildroot.net/results/bf31199cdaa18971a9b599c26fbefac73b2d6f30/
http://autobuild.buildroot.net/results/5b65c305b50664e02d5f8022278055c80739342d/
http://autobuild.buildroot.net/results/ed3b9fb8d09cd677af4b8825566877c552926ae5/

Quoted 4 lines
Signed-off-by Petr Vorel <[email protected]>
---
 package/feh/feh.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Seems like I had forgotten to notify you that PATCH 1/3 had been merged to master, it was part of the 2017.11 release.

And I've just applied PATCH 2/3 and 3/3 to master, they will be part of the next release.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com