Skip to contentSkip to conversation

ARM: dts: vf610-zii-dev-c: Fix switch EEPROM size

PATCH New Andrew Lunn 4 participants 6 messages Nov 9, 2017 – Nov 16, 2017 Device tree bindings

lore
Share & tools
lore

Andrew Lunn

author
#0 lore raw

PATCH 1/1 ARM: dts: vf610-zii-dev-c: Fix switch EEPROM size

The two Ethernet switches have an AT24C512 each. This is a 64K device, not 512 bytes as currently listed in the device tree.

Reported-by Chris Healy <[email protected]>
Signed-off-by Andrew Lunn <[email protected]>
---
 arch/arm/boot/dts/vf610-zii-dev-rev-c.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/vf610-zii-dev-rev-c.dts +2 -2
index db3b408ea55a..0c557a9e7e17 100644
@@ -73,7 +73,7 @@
 				#size-cells = <0>;
 				reg = <0>;
 				dsa,member = <0 0>;
-				eeprom-length = <512>;
+				eeprom-length = <65536>;
 				interrupt-parent = <&gpio0>;
 				interrupts = <27 IRQ_TYPE_LEVEL_LOW>;
 				interrupt-controller;

@@ -170,7 +170,7 @@
 				#size-cells = <0>;
 				reg = <0>;
 				dsa,member = <0 1>;
-				eeprom-length = <512>;
+				eeprom-length = <65536>;
 				interrupt-parent = <&gpio0>;
 				interrupts = <26 IRQ_TYPE_LEVEL_LOW>;
 				interrupt-controller;
Signature · 1 line
2.15.0
#1 lore raw

PATCH 1/1 ARM: dts: vf610-zii-dev-c: Fix switch EEPROM size

Reviewed-by Chris Healy <[email protected]>
Quoted 34 lines · Andrew Lunn

The two Ethernet switches have an AT24C512 each. This is a 64K device, not 512 bytes as currently listed in the device tree.

Reported-by Chris Healy <[email protected]>
Signed-off-by Andrew Lunn <[email protected]>
---
 arch/arm/boot/dts/vf610-zii-dev-rev-c.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/vf610-zii-dev-rev-c.dts +2 -3
index db3b408ea55a..0c557a9e7e17 100644
@@ -73,7 +73,7 @@
                                #size-cells = <0>;
                                reg = <0>;
                                dsa,member = <0 0>;
-                               eeprom-length = <512>;
+                               eeprom-length = <65536>;
                                interrupt-parent = <&gpio0>;
                                interrupts = <27 IRQ_TYPE_LEVEL_LOW>;
                                interrupt-controller;

@@ -170,7 +170,7 @@
                                #size-cells = <0>;
                                reg = <0>;
                                dsa,member = <0 1>;
-                               eeprom-length = <512>;
+                               eeprom-length = <65536>;
                                interrupt-parent = <&gpio0>;
                                interrupts = <26 IRQ_TYPE_LEVEL_LOW>;
                                interrupt-controller;
--

2.15.0

#2 lore raw

PATCH 1/1 ARM: dts: vf610-zii-dev-c: Fix switch EEPROM size

In reply to Andrew Lunn

Hi Andrew,

Quoted 14 lines · Andrew Lunn

The two Ethernet switches have an AT24C512 each. This is a 64K device, not 512 bytes as currently listed in the device tree.

Reported-by Chris Healy <[email protected]>
Signed-off-by Andrew Lunn <[email protected]>
---
 arch/arm/boot/dts/vf610-zii-dev-rev-c.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/vf610-zii-dev-rev-c.dts +0 -0
index db3b408ea55a..0c557a9e7e17 100644

arch/arm/boot/dts/vf610-zii-dev-rev-c.dts line 76

Quoted 5 lines
arch/arm/boot/dts/vf610-zii-dev-rev-c.dts +1 -1
@@ -73,7 +73,7 @@
                                #size-cells = <0>;
                                reg = <0>;
                                dsa,member = <0 0>;
-                               eeprom-length = <512>;
+                               eeprom-length = <65536>;

vf610-zii-dev-rev-b.dts also uses 512.

Should it be also changed or is it correct for the rev-b?

author
#3 lore raw

PATCH 1/1 ARM: dts: vf610-zii-dev-c: Fix switch EEPROM size

Hi Fabio

Quoted 3 lines

vf610-zii-dev-rev-b.dts also uses 512.

Should it be also changed or is it correct for the rev-b?

Rev-B is correct. Rev-C has a newer generation of Ethernet switch, which has a little microcontroller in it. That microcontroller gets its code from the EEPROM. So a bigger EEPROM is required.

Andrew

#4 lore raw

PATCH 1/1 ARM: dts: vf610-zii-dev-c: Fix switch EEPROM size

Quoted 9 lines · Andrew Lunn

Hi Fabio

Quoted 3 lines

vf610-zii-dev-rev-b.dts also uses 512.

Should it be also changed or is it correct for the rev-b?

Rev-B is correct. Rev-C has a newer generation of Ethernet switch, which has a little microcontroller in it. That microcontroller gets its code from the EEPROM. So a bigger EEPROM is required.

Thanks for the clarification:

Reviewed-by Fabio Estevam <[email protected]>