gpio: pca953x: fix vendor prefix for PCA9654

PATCH In review Sergei Shtylyov 4 participants 7 messages Nov 16, 2017 – Nov 30, 2017

Subsystems (2)

Device tree bindings GPIO

lore

Share & tools

lore

Sergei Shtylyov

author

2017-11-16 20:18 UTC #0 lore raw

PATCH 1/1 gpio: pca953x: fix vendor prefix for PCA9654

Despite commit 55020c8056a8 ("of: Add vendor prefix for ON Semiconductor Corp.") was made long ago, the latter commit 9f49f6dd0473 ("gpio: pca953x:
add onsemi,pca9654 id") made use of another, undocumented vendor prefix. Since such prefix doesn't seem to be used in any device trees, I think we can just fix the "compatible" string in the driver and the bindings and be done with that...

Fixes 9f49f6dd0473 ("gpio: pca953x: add onsemi,pca9654 id")

Signed-off-by Sergei Shtylyov <[email protected]>

---
The patch is against the 'fixes' branch of LinusW's 'linux-gpio.git' repo.

 Documentation/devicetree/bindings/gpio/gpio-pca953x.txt |    2 +-
 drivers/gpio/gpio-pca953x.c                             |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Documentation/devicetree/bindings/gpio/gpio-pca953x.txt +1 -1

Index: linux-gpio/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
===================================================================
@@ -27,7 +27,7 @@ Required properties:
 	ti,tca6424
 	ti,tca9539
 	ti,tca9554
-	onsemi,pca9654
+	onnn,pca9654
 	exar,xra1202
 
 Optional properties:

drivers/gpio/gpio-pca953x.c +1 -1

Index: linux-gpio/drivers/gpio/gpio-pca953x.c
===================================================================
@@ -947,7 +947,7 @@ static const struct of_device_id pca953x
 	{ .compatible = "ti,tca6416", .data = OF_953X(16, PCA_INT), },
 	{ .compatible = "ti,tca6424", .data = OF_953X(24, PCA_INT), },
 
-	{ .compatible = "onsemi,pca9654", .data = OF_953X( 8, PCA_INT), },
+	{ .compatible = "onnn,pca9654", .data = OF_953X( 8, PCA_INT), },
 
 	{ .compatible = "exar,xra1202", .data = OF_953X( 8, 0), },
 	{ }

Sergei Shtylyov

author

2017-11-16 20:32 UTC #1 lore raw

Quoted 2 lines · Sergei Shtylyov

Despite commit 55020c8056a8 ("of: Add vendor prefix for ON Semiconductor Corp.") was made long ago, the latter commit 9f49f6dd0473 ("gpio: pca953x:

Later, of course. Could be fixed while committing, I guess?

Quoted 7 lines

add onsemi,pca9654 id") made use of another, undocumented vendor prefix. Since such prefix doesn't seem to be used in any device trees, I think we can just fix the "compatible" string in the driver and the bindings and be done with that...
Fixes 9f49f6dd0473 ("gpio: pca953x: add onsemi,pca9654 id")
Signed-off-by Sergei Shtylyov <[email protected]>

[...]

MBR, Sergei

Geert Uytterhoeven

2017-11-17 09:06 UTC #2 lore raw

In reply to Sergei Shtylyov

Hi Sergei,

Quoted 3 lines · Sergei Shtylyov

Despite commit 55020c8056a8 ("of: Add vendor prefix for ON Semiconductor Corp.") was made long ago, the latter commit 9f49f6dd0473 ("gpio: pca953x:
add onsemi,pca9654 id") made use of another, undocumented vendor prefix.

Ouch...

Quoted 4 lines

Since such prefix doesn't seem to be used in any device trees, I think we can just fix the "compatible" string in the driver and the bindings and be done with that...

Quoted 8 lines

Fixes 9f49f6dd0473 ("gpio: pca953x: add onsemi,pca9654 id")
Signed-off-by Sergei Shtylyov <[email protected]>
---
The patch is against the 'fixes' branch of LinusW's 'linux-gpio.git' repo.
 Documentation/devicetree/bindings/gpio/gpio-pca953x.txt |    2 +-
 drivers/gpio/gpio-pca953x.c                             |    2 +-

There's another (different) one in Documentation/devicetree/bindings/misc/idt_89hpesx.txt

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Sergei Shtylyov

author

2017-11-17 10:47 UTC #3 lore raw

Quoted 13 lines · Geert Uytterhoeven

Quoted 3 lines
Despite commit 55020c8056a8 ("of: Add vendor prefix for ON Semiconductor Corp.") was made long ago, the latter commit 9f49f6dd0473 ("gpio: pca953x:
add onsemi,pca9654 id") made use of another, undocumented vendor prefix.
Ouch...
Quoted 7 lines
Since such prefix doesn't seem to be used in any device trees, I think we can just fix the "compatible" string in the driver and the bindings and be done with that...
Fixes 9f49f6dd0473 ("gpio: pca953x: add onsemi,pca9654 id")
Signed-off-by Sergei Shtylyov <[email protected]>

Quoted 8 lines

Quoted 5 lines
---
The patch is against the 'fixes' branch of LinusW's 'linux-gpio.git' repo.
  Documentation/devicetree/bindings/gpio/gpio-pca953x.txt |    2 +-
  drivers/gpio/gpio-pca953x.c                             |    2 +-
There's another (different) one in Documentation/devicetree/bindings/misc/idt_89hpesx.txt

Saw that. Do you think it also should be fixed (in this patch)?

Quoted 3 lines

Gr{oetje,eeting}s,
Geert

MBR, Sergei

Rob Herring

maintainer

2017-11-20 18:59 UTC #4 lore raw

Quoted 18 lines · Sergei Shtylyov

Quoted 16 lines · Geert Uytterhoeven
Quoted 3 lines
Despite commit 55020c8056a8 ("of: Add vendor prefix for ON Semiconductor Corp.") was made long ago, the latter commit 9f49f6dd0473 ("gpio: pca953x:
add onsemi,pca9654 id") made use of another, undocumented vendor prefix.
Ouch...
Quoted 10 lines
Since such prefix doesn't seem to be used in any device trees, I think we can just fix the "compatible" string in the driver and the bindings and be done with that...
Fixes 9f49f6dd0473 ("gpio: pca953x: add onsemi,pca9654 id")
Signed-off-by Sergei Shtylyov <[email protected]>
---
The patch is against the 'fixes' branch of LinusW's 'linux-gpio.git' repo.

Quoted 7 lines

Quoted 5 lines
Quoted 2 lines
  Documentation/devicetree/bindings/gpio/gpio-pca953x.txt |    2 +-
  drivers/gpio/gpio-pca953x.c                             |    2 +-
There's another (different) one in Documentation/devicetree/bindings/misc/idt_89hpesx.txt
Saw that. Do you think it also should be fixed (in this patch)?

IMO, separate.

Rob Herring

maintainer Acked-by on v1 1/1

2017-11-20 19:01 UTC #5 lore raw

In reply to Sergei Shtylyov

Quoted 10 lines · Sergei Shtylyov

Despite commit 55020c8056a8 ("of: Add vendor prefix for ON Semiconductor Corp.") was made long ago, the latter commit 9f49f6dd0473 ("gpio: pca953x:
add onsemi,pca9654 id") made use of another, undocumented vendor prefix. Since such prefix doesn't seem to be used in any device trees, I think we can just fix the "compatible" string in the driver and the bindings and be done with that...
Fixes 9f49f6dd0473 ("gpio: pca953x: add onsemi,pca9654 id")
Signed-off-by Sergei Shtylyov <[email protected]>

Quoted 6 lines

---
The patch is against the 'fixes' branch of LinusW's 'linux-gpio.git' repo.

 Documentation/devicetree/bindings/gpio/gpio-pca953x.txt |    2 +-
 drivers/gpio/gpio-pca953x.c                             |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Acked-by Rob Herring <[email protected]>

Linus Walleij

2017-11-30 13:38 UTC #6 lore raw

In reply to Sergei Shtylyov

Quoted 9 lines · Sergei Shtylyov

Despite commit 55020c8056a8 ("of: Add vendor prefix for ON Semiconductor Corp.") was made long ago, the latter commit 9f49f6dd0473 ("gpio: pca953x:
add onsemi,pca9654 id") made use of another, undocumented vendor prefix. Since such prefix doesn't seem to be used in any device trees, I think we can just fix the "compatible" string in the driver and the bindings and be done with that...
Fixes 9f49f6dd0473 ("gpio: pca953x: add onsemi,pca9654 id")
Signed-off-by Sergei Shtylyov <[email protected]>

Patch applied with Rob's ACK.

Thanks for spotting this in time.

Yours,
Linus Walleij