Skip to contentSkip to conversation

media: mtk-vcodec: add missing MODULE_LICENSE/DESCRIPTION

PATCH Superseded Jesse Chan 3 participants 5 messages Nov 20, 2017 – Nov 22, 2017

Subsystems (2)
Media (V4L/DVB) Arm MediaTek
lore
Share & tools
lore

Jesse Chan

author
#0 lore raw

PATCH 1/1 media: mtk-vcodec: add missing MODULE_LICENSE/DESCRIPTION

Signed-off-by Jesse Chan <[email protected]>
---
 drivers/media/platform/mtk-vcodec/mtk_vcodec_intr.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/media/platform/mtk-vcodec/mtk_vcodec_intr.c +3 -0
index 113b2097f061..d8212d759067 100644
@@ -51,3 +51,6 @@ int mtk_vcodec_wait_for_done_ctx(struct mtk_vcodec_ctx  *ctx, int command,
 	return status;
 }
 EXPORT_SYMBOL(mtk_vcodec_wait_for_done_ctx);
+
+MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("Mediatek video codec driver");
Signature · 1 line
2.14.1
author
#1 lore raw

PATCH v2 1/1 media: mtk-vcodec: add missing MODULE_LICENSE/DESCRIPTION

Signed-off-by Jesse Chan <[email protected]>

---
Change in v2:
- fix a mistake

 drivers/media/platform/mtk-vcodec/mtk_vcodec_util.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/media/platform/mtk-vcodec/mtk_vcodec_util.c +3 -0
index 46768c056193..0c28d0b995cc 100644
@@ -115,3 +115,6 @@ struct mtk_vcodec_ctx *mtk_vcodec_get_curr_ctx(struct mtk_vcodec_dev *dev)
 	return ctx;
 }
 EXPORT_SYMBOL(mtk_vcodec_get_curr_ctx);
+
+MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("Mediatek video codec driver");
Signature · 1 line
2.14.1
author
#2 lore raw

PATCH v3 1/1 media: mtk-vcodec: add missing MODULE_LICENSE/DESCRIPTION

This change resolves a new compile-time warning
when built as a loadable module:

WARNING: modpost: missing MODULE_LICENSE() in drivers/media/platform/mtk-vcodec/mtk-vcodec-common.o see include/linux/module.h for more information

This adds the license as "GPL v2", which matches the header of the file.

MODULE_DESCRIPTION is also added.

Signed-off-by Jesse Chan <[email protected]>
---
 drivers/media/platform/mtk-vcodec/mtk_vcodec_util.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/media/platform/mtk-vcodec/mtk_vcodec_util.c +3 -0
index 46768c056193..0c28d0b995cc 100644
@@ -115,3 +115,6 @@ struct mtk_vcodec_ctx *mtk_vcodec_get_curr_ctx(struct mtk_vcodec_dev *dev)
 	return ctx;
 }
 EXPORT_SYMBOL(mtk_vcodec_get_curr_ctx);
+
+MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("Mediatek video codec driver");
Signature · 1 line
2.14.1
build bot
#3 lore raw
In reply to Jesse Chan
Thank you for the patch! Yet something to improve:

Hi Jesse,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.14 next-20171121]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Jesse-Chan/media-mtk-vcodec-add-missing-MODULE_LICENSE-DESCRIPTION/20171122-124620
base:   git://linuxtv.org/media_tree.git master
config: xtensa-allmodconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 4.9.0

reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=xtensa

All errors (new ones prefixed by >>):

>> drivers/media/platform/mtk-vcodec/mtk_vcodec_intr.c:55:16: error: expected declaration specifiers or '...' before string constant
    MODULE_LICENSE("GPL v2");
                   ^
   drivers/media/platform/mtk-vcodec/mtk_vcodec_intr.c:56:20: error: expected declaration specifiers or '...' before string constant
    MODULE_DESCRIPTION("Mediatek video codec driver");
                       ^

vim +55 drivers/media/platform/mtk-vcodec/mtk_vcodec_intr.c

    54	
  > 55	MODULE_LICENSE("GPL v2");

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 51526 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20171122/78bae7d9/attachment-0001.gz>

#4 lore raw
Quoted 3 lines · kbuild test robot

Hi Jesse,

Thank you for the patch! Yet something to improve:

missing
#include <linux/module.h>

Jesse, did you build all of these driver changes?

Quoted 32 lines

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.14 next-20171121]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Jesse-Chan/media-mtk-vcodec-add-missing-MODULE_LICENSE-DESCRIPTION/20171122-124620
base:   git://linuxtv.org/media_tree.git master
config: xtensa-allmodconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 4.9.0

reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=xtensa

All errors (new ones prefixed by >>):

Quoted 1 line
Quoted 1 line

drivers/media/platform/mtk-vcodec/mtk_vcodec_intr.c:55:16: error: expected declaration specifiers or '...' before string constant

    MODULE_LICENSE("GPL v2");
                   ^
   drivers/media/platform/mtk-vcodec/mtk_vcodec_intr.c:56:20: error: expected declaration specifiers or '...' before string constant
    MODULE_DESCRIPTION("Mediatek video codec driver");
                       ^

vim +55 drivers/media/platform/mtk-vcodec/mtk_vcodec_intr.c

    54
Quoted 1 line

55 MODULE_LICENSE("GPL v2");

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Signature · 1 line
~Randy