Skip to contentSkip to conversation

mtd: nand: denali_pci: add missing MODULE_DESCRIPTION/AUTHOR/LICENSE

PATCH Applied Jesse Chan 3 participants 3 messages Nov 20, 2017 – Nov 30, 2017

Subsystems (2)
Memory technology devices (MTD) NAND flash
lore
Share & tools
lore

Jesse Chan

author
#0 lore raw

PATCH 1/1 mtd: nand: denali_pci: add missing MODULE_DESCRIPTION/AUTHOR/LICENSE

This change resolves a new compile-time warning
when built as a loadable module:

WARNING: modpost: missing MODULE_LICENSE() in drivers/mtd/nand/denali_pci.o see include/linux/module.h for more information

This adds the license as "GPL v2", which matches the header of the file.

MODULE_DESCRIPTION and MODULE_AUTHOR are also added.

Signed-off-by Jesse Chan <[email protected]>
---
 drivers/mtd/nand/denali_pci.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/mtd/nand/denali_pci.c +4 -0
index 81370c79aa48..7ad0db65a6fa 100644
@@ -124,3 +124,7 @@ static struct pci_driver denali_pci_driver = {
 };
 
 module_pci_driver(denali_pci_driver);
+
+MODULE_DESCRIPTION("PCI driver for Denali NAND controller");
+MODULE_AUTHOR("Intel Corporation and its suppliers");
+MODULE_LICENSE("GPL v2");
Signature · 1 line
2.14.1
Acked-by on v1 1/1
#1 lore raw

2017-11-21 5:57 GMT+09:00 Jesse Chan <[email protected]>:

Quoted 20 lines

This change resolves a new compile-time warning
when built as a loadable module:

WARNING: modpost: missing MODULE_LICENSE() in drivers/mtd/nand/denali_pci.o see include/linux/module.h for more information

This adds the license as "GPL v2", which matches the header of the file.

MODULE_DESCRIPTION and MODULE_AUTHOR are also added.

Signed-off-by Jesse Chan <[email protected]>
---
 drivers/mtd/nand/denali_pci.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/mtd/nand/denali_pci.c +0 -0
index 81370c79aa48..7ad0db65a6fa 100644

drivers/mtd/nand/denali_pci.c static struct pci_driver denali_pci_driver = { · line 130

Quoted 7 lines
drivers/mtd/nand/denali_pci.c +4 -0
@@ -124,3 +124,7 @@ static struct pci_driver denali_pci_driver = {
 };
 
 module_pci_driver(denali_pci_driver);
+
+MODULE_DESCRIPTION("PCI driver for Denali NAND controller");
+MODULE_AUTHOR("Intel Corporation and its suppliers");
+MODULE_LICENSE("GPL v2");
Acked-by Masahiro Yamada <[email protected]>
Signature · 2 lines
Best Regards
Masahiro Yamada
Applied
#2 lore raw
In reply to Jesse Chan
Quoted 10 lines · On Mon, 20 Nov 2017 12:57:13 -0800 Jesse Chan <[email protected]> wrote:

This change resolves a new compile-time warning
when built as a loadable module:

WARNING: modpost: missing MODULE_LICENSE() in drivers/mtd/nand/denali_pci.o see include/linux/module.h for more information

This adds the license as "GPL v2", which matches the header of the file.

MODULE_DESCRIPTION and MODULE_AUTHOR are also added.

Applied.

Thanks,

Boris

Quoted 17 lines
Signed-off-by Jesse Chan <[email protected]>
---
 drivers/mtd/nand/denali_pci.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/mtd/nand/denali_pci.c +4 -0
index 81370c79aa48..7ad0db65a6fa 100644
@@ -124,3 +124,7 @@ static struct pci_driver denali_pci_driver = {
 };
 
 module_pci_driver(denali_pci_driver);
+
+MODULE_DESCRIPTION("PCI driver for Denali NAND controller");
+MODULE_AUTHOR("Intel Corporation and its suppliers");
+MODULE_LICENSE("GPL v2");