Skip to contentSkip to conversation

mmc: renesas_sdhi: add missing MODULE_DESCRIPTION/AUTHOR/LICENSE

PATCH In review Jesse Chan 3 participants 4 messages Nov 20, 2017 – Nov 27, 2017

Subsystems (2)
MMC, SD and SDIO TMIO/SDHI MMC driver
lore
Share & tools
lore

Jesse Chan

author
#0 lore raw

PATCH 1/1 mmc: renesas_sdhi: add missing MODULE_DESCRIPTION/AUTHOR/LICENSE

This change resolves a new compile-time warning
when built as a loadable module:

WARNING: modpost: missing MODULE_LICENSE() in drivers/mmc/host/renesas_sdhi_core.o see include/linux/module.h for more information

This adds the license as "GPL v2", which matches the header of the file.

MODULE_DESCRIPTION and MODULE_AUTHOR are also added.

Signed-off-by Jesse Chan <[email protected]>
---
 drivers/mmc/host/renesas_sdhi.h               | 1 +
 drivers/mmc/host/renesas_sdhi_core.c          | 5 +++++
 drivers/mmc/host/renesas_sdhi_internal_dmac.c | 1 -
 drivers/mmc/host/renesas_sdhi_sys_dmac.c      | 1 -
 4 files changed, 6 insertions(+), 2 deletions(-)
drivers/mmc/host/renesas_sdhi.h +1 -0
index b9dfea5d8193..090cf86d7cd3 100644
@@ -13,6 +13,7 @@
 #define RENESAS_SDHI_H
 
 #include <linux/platform_device.h>
+#include <linux/module.h>
 #include "tmio_mmc.h"
 
 struct renesas_sdhi_scc {
drivers/mmc/host/renesas_sdhi_core.c +5 -0
index fcf7235d5742..0a0daa7a342f 100644
@@ -667,3 +667,8 @@ int renesas_sdhi_remove(struct platform_device *pdev)
 	return 0;
 }
 EXPORT_SYMBOL_GPL(renesas_sdhi_remove);
+
+MODULE_DESCRIPTION("Renesas SDHI driver");
+MODULE_AUTHOR("Phil Blundell <[email protected]>");
+MODULE_AUTHOR("Samuel Ortiz <[email protected]>");
+MODULE_LICENSE("GPL v2");
drivers/mmc/host/renesas_sdhi_internal_dmac.c +0 -1
index 41cbe84c1d18..a9b452b42fac 100644
@@ -15,7 +15,6 @@
 #include <linux/mfd/tmio.h>
 #include <linux/mmc/host.h>
 #include <linux/mod_devicetable.h>
-#include <linux/module.h>
 #include <linux/pagemap.h>
 #include <linux/scatterlist.h>
 #include <linux/sys_soc.h>
drivers/mmc/host/renesas_sdhi_sys_dmac.c +0 -1
index 9ab10436e4b8..fe6a09f14682 100644
@@ -17,7 +17,6 @@
 #include <linux/mfd/tmio.h>
 #include <linux/mmc/host.h>
 #include <linux/mod_devicetable.h>
-#include <linux/module.h>
 #include <linux/of_device.h>
 #include <linux/pagemap.h>
 #include <linux/scatterlist.h>
Signature · 1 line
2.14.1
#1 lore raw

2017-11-21 6:32 GMT+09:00 Jesse Chan <[email protected]>:

Quoted 23 lines

This change resolves a new compile-time warning
when built as a loadable module:

WARNING: modpost: missing MODULE_LICENSE() in drivers/mmc/host/renesas_sdhi_core.o see include/linux/module.h for more information

This adds the license as "GPL v2", which matches the header of the file.

MODULE_DESCRIPTION and MODULE_AUTHOR are also added.

Signed-off-by Jesse Chan <[email protected]>
---
 drivers/mmc/host/renesas_sdhi.h               | 1 +
 drivers/mmc/host/renesas_sdhi_core.c          | 5 +++++
 drivers/mmc/host/renesas_sdhi_internal_dmac.c | 1 -
 drivers/mmc/host/renesas_sdhi_sys_dmac.c      | 1 -
 4 files changed, 6 insertions(+), 2 deletions(-)
drivers/mmc/host/renesas_sdhi.h +0 -0
index b9dfea5d8193..090cf86d7cd3 100644

drivers/mmc/host/renesas_sdhi.h line 19

Quoted 7 lines
drivers/mmc/host/renesas_sdhi.h +1 -0
@@ -13,6 +13,7 @@
 #define RENESAS_SDHI_H
 
 #include <linux/platform_device.h>
+#include <linux/module.h>
 #include "tmio_mmc.h"
 
 struct renesas_sdhi_scc {

Why did you move <linux/module.h> to this header?

I do not see anything that requires <linux/module.h> in this header.

drivers/mmc/host/renesas_sdhi_core.c int renesas_sdhi_remove(struct platform_device *pdev) · line 674

Quoted 13 lines
drivers/mmc/host/renesas_sdhi_core.c +5 -0
index fcf7235d5742..0a0daa7a342f 100644
@@ -667,3 +667,8 @@ int renesas_sdhi_remove(struct platform_device *pdev)
        return 0;
 }
 EXPORT_SYMBOL_GPL(renesas_sdhi_remove);
+
+MODULE_DESCRIPTION("Renesas SDHI driver");
+MODULE_AUTHOR("Phil Blundell <[email protected]>");
+MODULE_AUTHOR("Samuel Ortiz <[email protected]>");
+MODULE_LICENSE("GPL v2");

Including <linux/module.h> from this file is fine.

Quoted 31 lines
drivers/mmc/host/renesas_sdhi_internal_dmac.c +0 -1
index 41cbe84c1d18..a9b452b42fac 100644
@@ -15,7 +15,6 @@
 #include <linux/mfd/tmio.h>
 #include <linux/mmc/host.h>
 #include <linux/mod_devicetable.h>
-#include <linux/module.h>
 #include <linux/pagemap.h>
 #include <linux/scatterlist.h>
 #include <linux/sys_soc.h>
drivers/mmc/host/renesas_sdhi_sys_dmac.c +0 -2
index 9ab10436e4b8..fe6a09f14682 100644
@@ -17,7 +17,6 @@
 #include <linux/mfd/tmio.h>
 #include <linux/mmc/host.h>
 #include <linux/mod_devicetable.h>
-#include <linux/module.h>
 #include <linux/of_device.h>
 #include <linux/pagemap.h>
 #include <linux/scatterlist.h>
--

2.14.1

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 2 lines
Best Regards
Masahiro Yamada
#2 lore raw
In reply to Jesse Chan

Hi Jesse,

Quoted 35 lines · Jesse Chan

This change resolves a new compile-time warning
when built as a loadable module:

WARNING: modpost: missing MODULE_LICENSE() in drivers/mmc/host/renesas_sdhi_core.o see include/linux/module.h for more information

This adds the license as "GPL v2", which matches the header of the file.

MODULE_DESCRIPTION and MODULE_AUTHOR are also added.

Signed-off-by Jesse Chan <[email protected]>
---
 drivers/mmc/host/renesas_sdhi.h               | 1 +
 drivers/mmc/host/renesas_sdhi_core.c          | 5 +++++
 drivers/mmc/host/renesas_sdhi_internal_dmac.c | 1 -
 drivers/mmc/host/renesas_sdhi_sys_dmac.c      | 1 -
 4 files changed, 6 insertions(+), 2 deletions(-)
drivers/mmc/host/renesas_sdhi.h +1 -0
index b9dfea5d8193..090cf86d7cd3 100644
@@ -13,6 +13,7 @@
 #define RENESAS_SDHI_H
 
 #include <linux/platform_device.h>
+#include <linux/module.h>
 #include "tmio_mmc.h"
 
 struct renesas_sdhi_scc {
drivers/mmc/host/renesas_sdhi_core.c +0 -0
index fcf7235d5742..0a0daa7a342f 100644

drivers/mmc/host/renesas_sdhi_core.c int renesas_sdhi_remove(struct platform_device *pdev) · line 674

Quoted 8 lines
drivers/mmc/host/renesas_sdhi_core.c +5 -0
@@ -667,3 +667,8 @@ int renesas_sdhi_remove(struct platform_device *pdev)
        return 0;
 }
 EXPORT_SYMBOL_GPL(renesas_sdhi_remove);
+
+MODULE_DESCRIPTION("Renesas SDHI driver");
+MODULE_AUTHOR("Phil Blundell <[email protected]>");
+MODULE_AUTHOR("Samuel Ortiz <[email protected]>");
+MODULE_LICENSE("GPL v2");

This doesn't look right to me. Before commit 9d08428afb722fed ("mmc:
renesas-sdhi: make renesas_sdhi_sys_dmac main module file"), the file had:

     MODULE_AUTHOR("Magnus Damm");
     MODULE_LICENSE("GPL v2");
Quoted 25 lines
drivers/mmc/host/renesas_sdhi_internal_dmac.c +0 -1
index 41cbe84c1d18..a9b452b42fac 100644
@@ -15,7 +15,6 @@
 #include <linux/mfd/tmio.h>
 #include <linux/mmc/host.h>
 #include <linux/mod_devicetable.h>
-#include <linux/module.h>
 #include <linux/pagemap.h>
 #include <linux/scatterlist.h>
 #include <linux/sys_soc.h>
drivers/mmc/host/renesas_sdhi_sys_dmac.c +0 -2
index 9ab10436e4b8..fe6a09f14682 100644
@@ -17,7 +17,6 @@
 #include <linux/mfd/tmio.h>
 #include <linux/mmc/host.h>
 #include <linux/mod_devicetable.h>
-#include <linux/module.h>
 #include <linux/of_device.h>
 #include <linux/pagemap.h>
 #include <linux/scatterlist.h>
--
Quoted 1 line

2.14.1

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

author
#3 lore raw

I copied authors from the header of file. I will correct this in next revision of patch.

Thanks for your feedback.

Sent from Samsung Focus

-------- Original message --------
From: Geert Uytterhoeven <[email protected]>
Date: 11/27/17 02:16 (GMT-08:00)
To: Jesse Chan <[email protected]>, Simon Horman <[email protected]>
Cc: Wolfram Sang <[email protected]>, Ulf Hansson <[email protected]>, Linux MMC List <[email protected]>, [email protected], Magnus Damm <[email protected]>, Linux-Renesas <[email protected]>
Subject: Re: [PATCH] mmc: renesas_sdhi: add missing MODULE_DESCRIPTION/AUTHOR/LICENSE

Hi Jesse,

Quoted 35 lines · Jesse Chan

This change resolves a new compile-time warning
when built as a loadable module:

WARNING: modpost: missing MODULE_LICENSE() in drivers/mmc/host/renesas_sdhi_core.o see include/linux/module.h for more information

This adds the license as "GPL v2", which matches the header of the file.

MODULE_DESCRIPTION and MODULE_AUTHOR are also added.

Signed-off-by Jesse Chan <[email protected]>
---
 drivers/mmc/host/renesas_sdhi.h               | 1 +
 drivers/mmc/host/renesas_sdhi_core.c          | 5 +++++
 drivers/mmc/host/renesas_sdhi_internal_dmac.c | 1 -
 drivers/mmc/host/renesas_sdhi_sys_dmac.c      | 1 -
 4 files changed, 6 insertions(+), 2 deletions(-)
drivers/mmc/host/renesas_sdhi.h +1 -0
index b9dfea5d8193..090cf86d7cd3 100644
@@ -13,6 +13,7 @@
 #define RENESAS_SDHI_H
 
 #include <linux/platform_device.h>
+#include <linux/module.h>
 #include "tmio_mmc.h"
 
 struct renesas_sdhi_scc {
drivers/mmc/host/renesas_sdhi_core.c +0 -0
index fcf7235d5742..0a0daa7a342f 100644

drivers/mmc/host/renesas_sdhi_core.c int renesas_sdhi_remove(struct platform_device *pdev) · line 674

Quoted 8 lines
drivers/mmc/host/renesas_sdhi_core.c +5 -0
@@ -667,3 +667,8 @@ int renesas_sdhi_remove(struct platform_device *pdev)
        return 0;
 }
 EXPORT_SYMBOL_GPL(renesas_sdhi_remove);
+
+MODULE_DESCRIPTION("Renesas SDHI driver");
+MODULE_AUTHOR("Phil Blundell <[email protected]>");
+MODULE_AUTHOR("Samuel Ortiz <[email protected]>");
+MODULE_LICENSE("GPL v2");

This doesn't look right to me. Before commit 9d08428afb722fed ("mmc:
renesas-sdhi: make renesas_sdhi_sys_dmac main module file"), the file had:

     MODULE_AUTHOR("Magnus Damm");
     MODULE_LICENSE("GPL v2");
Quoted 25 lines
drivers/mmc/host/renesas_sdhi_internal_dmac.c +0 -1
index 41cbe84c1d18..a9b452b42fac 100644
@@ -15,7 +15,6 @@
 #include <linux/mfd/tmio.h>
 #include <linux/mmc/host.h>
 #include <linux/mod_devicetable.h>
-#include <linux/module.h>
 #include <linux/pagemap.h>
 #include <linux/scatterlist.h>
 #include <linux/sys_soc.h>
drivers/mmc/host/renesas_sdhi_sys_dmac.c +0 -2
index 9ab10436e4b8..fe6a09f14682 100644
@@ -17,7 +17,6 @@
 #include <linux/mfd/tmio.h>
 #include <linux/mmc/host.h>
 #include <linux/mod_devicetable.h>
-#include <linux/module.h>
 #include <linux/of_device.h>
 #include <linux/pagemap.h>
 #include <linux/scatterlist.h>
--
Quoted 1 line

2.14.1

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds