Skip to contentSkip to conversation

phy: qcom-ufs: add missing MODULE_DESCRIPTION/LICENSE

PATCH In review Jesse Chan 3 participants 3 messages Nov 20, 2017 – Nov 21, 2017

Subsystems (2)
Arm Qualcomm mailing list Generic PHY framework
lore
Share & tools
lore

Jesse Chan

author
#0 lore raw

PATCH 1/1 phy: qcom-ufs: add missing MODULE_DESCRIPTION/LICENSE

This change resolves a new compile-time warning
when built as a loadable module:

WARNING: modpost: missing MODULE_LICENSE() in drivers/phy/qualcomm/phy-qcom-ufs.o see include/linux/module.h for more information

This adds the license as "GPL v2", which matches the header of the file.

MODULE_DESCRIPTION is also added.

Signed-off-by Jesse Chan <[email protected]>
---
 drivers/phy/qualcomm/phy-qcom-ufs.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/phy/qualcomm/phy-qcom-ufs.c +3 -0
index c5ff4525edef..124dc70f6986 100644
@@ -675,3 +675,6 @@ int ufs_qcom_phy_power_off(struct phy *generic_phy)
 	return 0;
 }
 EXPORT_SYMBOL_GPL(ufs_qcom_phy_power_off);
+
+MODULE_DESCRIPTION("Universal Flash Storage (UFS) QCOM PHY");
+MODULE_LICENSE("GPL v2");
Signature · 1 line
2.14.1
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Jesse Chan

This change resolves a new compile-time warning
when built as a loadable module:

WARNING: modpost: missing MODULE_LICENSE() in drivers/phy/qualcomm/phy-qcom-ufs.o see include/linux/module.h for more information

This adds the license as "GPL v2", which matches the header of the file.

MODULE_DESCRIPTION is also added.

Acked-by Bjorn Andersson <[email protected]>

Although I suspect that the plan was for the three ufs phy drivers to be one kernel module...

Regards,
Bjorn

Quoted 19 lines
Signed-off-by Jesse Chan <[email protected]>
---
 drivers/phy/qualcomm/phy-qcom-ufs.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/phy/qualcomm/phy-qcom-ufs.c +3 -0
index c5ff4525edef..124dc70f6986 100644
@@ -675,3 +675,6 @@ int ufs_qcom_phy_power_off(struct phy *generic_phy)
 	return 0;
 }
 EXPORT_SYMBOL_GPL(ufs_qcom_phy_power_off);
+
+MODULE_DESCRIPTION("Universal Flash Storage (UFS) QCOM PHY");
+MODULE_LICENSE("GPL v2");
Signature · 1 line
2.14.1
Reviewed-by on v1 1/1
#2 lore raw
In reply to Jesse Chan
Quoted 22 lines · Jesse Chan

This change resolves a new compile-time warning
when built as a loadable module:

WARNING: modpost: missing MODULE_LICENSE() in
drivers/phy/qualcomm/phy-qcom-ufs.o
see include/linux/module.h for more information

This adds the license as "GPL v2", which matches the header of the file.

MODULE_DESCRIPTION is also added.

Signed-off-by Jesse Chan <[email protected]>
---
 drivers/phy/qualcomm/phy-qcom-ufs.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/phy/qualcomm/phy-qcom-ufs.c +0 -0
index c5ff4525edef..124dc70f6986 100644

drivers/phy/qualcomm/phy-qcom-ufs.c int ufs_qcom_phy_power_off(struct phy *generic_phy) · line 680

Quoted 6 lines
drivers/phy/qualcomm/phy-qcom-ufs.c +3 -0
@@ -675,3 +675,6 @@ int ufs_qcom_phy_power_off(struct phy *generic_phy)
 	return 0;
 }
 EXPORT_SYMBOL_GPL(ufs_qcom_phy_power_off);
+
+MODULE_DESCRIPTION("Universal Flash Storage (UFS) QCOM PHY");
+MODULE_LICENSE("GPL v2");

Looks good to me.

Reviewed-by Subhash Jadavani <[email protected]>
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project