mt76: add new wireless driver for MediaTek MT76x2 PCIe chips
Subsystems (4)
Felix Fietkau
maintainerv7 cover mt76: add new wireless driver for MediaTek MT76x2 PCIe chips
Changes since v6:
- DT documentation fixes
- Add LED configuration
- PHY gain calibration fixes
- Endian fixes
- Tx status processing fixes
- EEPROM validation fixes
- IBSS RSN fix
- AP mode powersave delivery fix
Changes since v5:
- Adjust for mac80211 API changes
- EEPROM parsing fixes
- Ad-hoc mode WPA2 fixes
Changes since v4:
- Cleanups suggested by Stanislaw Gruszka
- Device tree fixes suggested by Rob Herring
- EEPROM MAC address parsing fix
Changes since v3:
- DFS fixes
- stability fixes
- use wiphy_read_of_freq_limits
Changes since v2:
- lots of checkpatch cleanups
- various tx path (and other) fixes
- use the new bitfield API
- documented device tree bindings
Felix Fietkau (3):
Documentation: dt: net: add mt76 wireless device binding
mt76: add common code shared between multiple chipsets
mt76: add driver code for MT76x2e
.../bindings/net/wireless/mediatek,mt76.txt | 24 + drivers/net/wireless/mediatek/Kconfig | 1 + drivers/net/wireless/mediatek/Makefile | 1 + drivers/net/wireless/mediatek/mt76/Kconfig | 10 + drivers/net/wireless/mediatek/mt76/Makefile | 15 + drivers/net/wireless/mediatek/mt76/debugfs.c | 76 ++ drivers/net/wireless/mediatek/mt76/dma.c | 451 ++++++++++++ drivers/net/wireless/mediatek/mt76/dma.h | 38 + drivers/net/wireless/mediatek/mt76/eeprom.c | 112 +++ drivers/net/wireless/mediatek/mt76/mac80211.c | 344 +++++++++ drivers/net/wireless/mediatek/mt76/mmio.c | 61 ++ drivers/net/wireless/mediatek/mt76/mt76.h | 355 ++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2.h | 223 ++++++ drivers/net/wireless/mediatek/mt76/mt76x2_core.c | 88 +++ .../net/wireless/mediatek/mt76/mt76x2_debugfs.c | 133 ++++ drivers/net/wireless/mediatek/mt76/mt76x2_dfs.c | 493 +++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_dfs.h | 80 +++ drivers/net/wireless/mediatek/mt76/mt76x2_dma.c | 184 +++++ drivers/net/wireless/mediatek/mt76/mt76x2_dma.h | 68 ++ drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c | 644 +++++++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.h | 181 +++++ drivers/net/wireless/mediatek/mt76/mt76x2_init.c | 784 +++++++++++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_mac.c | 738 +++++++++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_mac.h | 189 +++++ drivers/net/wireless/mediatek/mt76/mt76x2_main.c | 534 ++++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_mcu.c | 452 ++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_mcu.h | 136 ++++ drivers/net/wireless/mediatek/mt76/mt76x2_pci.c | 109 +++ drivers/net/wireless/mediatek/mt76/mt76x2_phy.c | 691 ++++++++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_regs.h | 566 +++++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_trace.c | 23 + drivers/net/wireless/mediatek/mt76/mt76x2_trace.h | 144 ++++ drivers/net/wireless/mediatek/mt76/mt76x2_tx.c | 255 +++++++ drivers/net/wireless/mediatek/mt76/trace.c | 23 + drivers/net/wireless/mediatek/mt76/trace.h | 71 ++ drivers/net/wireless/mediatek/mt76/tx.c | 511 ++++++++++++++ drivers/net/wireless/mediatek/mt76/util.c | 78 ++ drivers/net/wireless/mediatek/mt76/util.h | 44 ++ 38 files changed, 8930 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt create mode 100644 drivers/net/wireless/mediatek/mt76/Kconfig create mode 100644 drivers/net/wireless/mediatek/mt76/Makefile create mode 100644 drivers/net/wireless/mediatek/mt76/debugfs.c create mode 100644 drivers/net/wireless/mediatek/mt76/dma.c create mode 100644 drivers/net/wireless/mediatek/mt76/dma.h create mode 100644 drivers/net/wireless/mediatek/mt76/eeprom.c create mode 100644 drivers/net/wireless/mediatek/mt76/mac80211.c create mode 100644 drivers/net/wireless/mediatek/mt76/mmio.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_core.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_debugfs.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_dfs.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_dfs.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_dma.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_dma.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_init.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_mac.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_mac.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_main.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_mcu.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_mcu.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_pci.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_phy.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_regs.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_trace.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_trace.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_tx.c create mode 100644 drivers/net/wireless/mediatek/mt76/trace.c create mode 100644 drivers/net/wireless/mediatek/mt76/trace.h create mode 100644 drivers/net/wireless/mediatek/mt76/tx.c create mode 100644 drivers/net/wireless/mediatek/mt76/util.c create mode 100644 drivers/net/wireless/mediatek/mt76/util.h
Signature · 1 line
2.11.0
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH v7 1/3 dt-bindings: net: add mt76 wireless device binding
Add documentation describing how device tree can be used to configure wireless chips supported by the mt76 driver.
--- .../bindings/net/wireless/mediatek,mt76.txt | 32 ++++++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt
Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt new file +32 -0
@@ -0,0 +1,32 @@ +* MediaTek mt76xx devices + +This node provides properties for configuring the MediaTek mt76xx wireless +device. The node is expected to be specified as a child node of the PCI +controller to which the wireless chip is connected. + +Optional properties: + +- mac-address: See ethernet.txt in the parent directory +- local-mac-address: See ethernet.txt in the parent directory +- ieee80211-freq-limit: See ieee80211.txt +- mediatek,mtd-eeprom: Specify a MTD partition + offset containing EEPROM data + +Optional nodes: +- led: Properties for a connected LED + Optional properties: + - led-sources: See Documentation/devicetree/bindings/leds/common.txt + +&pcie { + pcie0 { + wifi@0,0 { + compatible = "mediatek,mt76"; + reg = <0x0000 0 0 0 0>; + ieee80211-freq-limit = <5000000 6000000>; + mediatek,mtd-eeprom = <&factory 0x8000>; + + led { + led-sources = <2>; + }; + }; + }; +};
Signature · 1 line
2.14.2
A message that is not in the archive (sent off-list or not yet received): [email protected]
Rob Herring
Acked-byRe: [PATCH v7 1/3] dt-bindings: net: add mt76 wireless device binding
Quoted 8 lines · Felix Fietkau
Add documentation describing how device tree can be used to configure wireless chips supported by the mt76 driver.
Signed-off-by Felix Fietkau <[email protected]>--- .../bindings/net/wireless/mediatek,mt76.txt | 32 ++++++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [v7,1/3] dt-bindings: net: add mt76 wireless device binding
In reply to a message not in the archiveQuoted 5 lines · Felix Fietkau
Add documentation describing how device tree can be used to configure wireless chips supported by the mt76 driver.
Signed-off-by Felix Fietkau <[email protected]>Acked-by Rob Herring <[email protected]>
Fails to compile:
drivers/net/wireless/mediatek/mt76/mac80211.c: In function ‘mt76_led_init’:drivers/net/wireless/mediatek/mt76/mac80211.c:111:7: error: implicit declaration of function ‘of_get_child_by_name’ [-Werror=implicit-function-declaration]
np = of_get_child_by_name(np, "led");
^
drivers/net/wireless/mediatek/mt76/mac80211.c:111:5: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
np = of_get_child_by_name(np, "led");
^
drivers/net/wireless/mediatek/mt76/mac80211.c:113:8: error: implicit declaration of function ‘of_property_read_u32’ [-Werror=implicit-function-declaration]
if (!of_property_read_u32(np, "led-sources", &led_pin))
^
drivers/net/wireless/mediatek/mt76/mac80211.c:115:17: error: implicit declaration of function ‘of_property_read_bool’ [-Werror=implicit-function-declaration]
dev->led_al = of_property_read_bool(np, "led-active-low");
^cc1: some warnings being treated as errors
make[5]: *** [drivers/net/wireless/mediatek/mt76/mac80211.o] Error 1
make[5]: *** Waiting for unfinished jobs....drivers/net/wireless/mediatek/mt76/mt76x2_mac.c: In function ‘mt76x2_mac_process_rate’:drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:49:20: error: ‘RX_FLAG_SHORTPRE’ undeclared (first use in this function)
status->flag |= RX_FLAG_SHORTPRE;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:49:20: note: each undeclared identifier is reported only once for each function it appears in
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:58:19: error: ‘RX_FLAG_HT_GF’ undeclared (first use in this function)
status->flag |= RX_FLAG_HT_GF;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:61:19: error: ‘RX_FLAG_HT’ undeclared (first use in this function)
status->flag |= RX_FLAG_HT;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:65:19: error: ‘RX_FLAG_VHT’ undeclared (first use in this function)
status->flag |= RX_FLAG_VHT;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:67:9: error: ‘struct ieee80211_rx_status’ has no member named ‘vht_nss’
status->vht_nss = FIELD_GET(MT_RATE_INDEX_VHT_NSS, idx) + 1;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:75:19: error: ‘RX_FLAG_LDPC’ undeclared (first use in this function)
status->flag |= RX_FLAG_LDPC;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:78:19: error: ‘RX_FLAG_SHORT_GI’ undeclared (first use in this function)
status->flag |= RX_FLAG_SHORT_GI;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:81:24: error: ‘RX_FLAG_STBC_SHIFT’ undeclared (first use in this function)
status->flag |= 1 << RX_FLAG_STBC_SHIFT;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:87:19: error: ‘RX_FLAG_40MHZ’ undeclared (first use in this function)
status->flag |= RX_FLAG_40MHZ;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:90:9: error: ‘struct ieee80211_rx_status’ has no member named ‘vht_flag’
status->vht_flag |= RX_VHT_FLAG_80MHZ;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:90:23: error: ‘RX_VHT_FLAG_80MHZ’ undeclared (first use in this function)
status->vht_flag |= RX_VHT_FLAG_80MHZ;
^make[5]: *** [drivers/net/wireless/mediatek/mt76/mt76x2_mac.o] Error 1 make[4]: *** [drivers/net/wireless/mediatek/mt76] Error 2 make[3]: *** [drivers/net/wireless/mediatek] Error 2 make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2
3 patches set to Changes Requested.
10067143 [v7,1/3] dt-bindings: net: add mt76 wireless device binding 10067141 [v7,2/3] mt76: add common code shared between multiple chipsets 10067145 [v7,3/3] mt76: add driver code for MT76x2e
Signature · 8 lines
https://patchwork.kernel.org/patch/10067143/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [v7,1/3] dt-bindings: net: add mt76 wireless device binding
In reply to Felix FietkauQuoted 5 lines · Felix Fietkau
Add documentation describing how device tree can be used to configure wireless chips supported by the mt76 driver.
Signed-off-by Felix Fietkau <[email protected]>Acked-by Rob Herring <[email protected]>
Fails to compile:
drivers/net/wireless/mediatek/mt76/mac80211.c: In function ‘mt76_led_init’:drivers/net/wireless/mediatek/mt76/mac80211.c:111:7: error: implicit declaration of function ‘of_get_child_by_name’ [-Werror=implicit-function-declaration]
np = of_get_child_by_name(np, "led");
^
drivers/net/wireless/mediatek/mt76/mac80211.c:111:5: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
np = of_get_child_by_name(np, "led");
^
drivers/net/wireless/mediatek/mt76/mac80211.c:113:8: error: implicit declaration of function ‘of_property_read_u32’ [-Werror=implicit-function-declaration]
if (!of_property_read_u32(np, "led-sources", &led_pin))
^
drivers/net/wireless/mediatek/mt76/mac80211.c:115:17: error: implicit declaration of function ‘of_property_read_bool’ [-Werror=implicit-function-declaration]
dev->led_al = of_property_read_bool(np, "led-active-low");
^cc1: some warnings being treated as errors
make[5]: *** [drivers/net/wireless/mediatek/mt76/mac80211.o] Error 1
make[5]: *** Waiting for unfinished jobs....drivers/net/wireless/mediatek/mt76/mt76x2_mac.c: In function ‘mt76x2_mac_process_rate’:drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:49:20: error: ‘RX_FLAG_SHORTPRE’ undeclared (first use in this function)
status->flag |= RX_FLAG_SHORTPRE;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:49:20: note: each undeclared identifier is reported only once for each function it appears in
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:58:19: error: ‘RX_FLAG_HT_GF’ undeclared (first use in this function)
status->flag |= RX_FLAG_HT_GF;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:61:19: error: ‘RX_FLAG_HT’ undeclared (first use in this function)
status->flag |= RX_FLAG_HT;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:65:19: error: ‘RX_FLAG_VHT’ undeclared (first use in this function)
status->flag |= RX_FLAG_VHT;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:67:9: error: ‘struct ieee80211_rx_status’ has no member named ‘vht_nss’
status->vht_nss = FIELD_GET(MT_RATE_INDEX_VHT_NSS, idx) + 1;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:75:19: error: ‘RX_FLAG_LDPC’ undeclared (first use in this function)
status->flag |= RX_FLAG_LDPC;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:78:19: error: ‘RX_FLAG_SHORT_GI’ undeclared (first use in this function)
status->flag |= RX_FLAG_SHORT_GI;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:81:24: error: ‘RX_FLAG_STBC_SHIFT’ undeclared (first use in this function)
status->flag |= 1 << RX_FLAG_STBC_SHIFT;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:87:19: error: ‘RX_FLAG_40MHZ’ undeclared (first use in this function)
status->flag |= RX_FLAG_40MHZ;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:90:9: error: ‘struct ieee80211_rx_status’ has no member named ‘vht_flag’
status->vht_flag |= RX_VHT_FLAG_80MHZ;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:90:23: error: ‘RX_VHT_FLAG_80MHZ’ undeclared (first use in this function)
status->vht_flag |= RX_VHT_FLAG_80MHZ;
^make[5]: *** [drivers/net/wireless/mediatek/mt76/mt76x2_mac.o] Error 1 make[4]: *** [drivers/net/wireless/mediatek/mt76] Error 2 make[3]: *** [drivers/net/wireless/mediatek] Error 2 make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2
3 patches set to Changes Requested.
10067143 [v7,1/3] dt-bindings: net: add mt76 wireless device binding 10067141 [v7,2/3] mt76: add common code shared between multiple chipsets 10067145 [v7,3/3] mt76: add driver code for MT76x2e
Signature · 3 lines
https://patchwork.kernel.org/patch/10067143/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): 20171121070837.AA354607EA-4h6buKAYkuurB/[email protected]
Re: [v7,1/3] dt-bindings: net: add mt76 wireless device binding
Quoted 8 lines · Kalle Valo
Quoted 5 lines · Felix Fietkau
Add documentation describing how device tree can be used to configure wireless chips supported by the mt76 driver.
Signed-off-by Felix Fietkau <[email protected]>Acked-by Rob Herring <[email protected]>
Quoted 6 lines
Fails to compile:
drivers/net/wireless/mediatek/mt76/mac80211.c: In function ‘mt76_led_init’:drivers/net/wireless/mediatek/mt76/mac80211.c:111:7: error: implicit declaration of function ‘of_get_child_by_name’ [-Werror=implicit-function-declaration]np = of_get_child_by_name(np, "led"); ^
Sorry about that, I must have mixed up something while updating the patches based on my git tree. Will send out a fixed version later today.
- Felix
Felix Fietkau
maintainerPATCH v7 2/3 mt76: add common code shared between multiple chipsets
In reply to Felix FietkauThis will be used by drivers for MT76x2e, MT7603e and MT7628
--- drivers/net/wireless/mediatek/mt76/debugfs.c | 77 ++++ drivers/net/wireless/mediatek/mt76/dma.c | 451 +++++++++++++++++++++++ drivers/net/wireless/mediatek/mt76/dma.h | 38 ++ drivers/net/wireless/mediatek/mt76/eeprom.c | 112 ++++++ drivers/net/wireless/mediatek/mt76/mac80211.c | 392 ++++++++++++++++++++ drivers/net/wireless/mediatek/mt76/mmio.c | 61 +++ drivers/net/wireless/mediatek/mt76/mt76.h | 360 ++++++++++++++++++ drivers/net/wireless/mediatek/mt76/trace.c | 23 ++ drivers/net/wireless/mediatek/mt76/trace.h | 71 ++++ drivers/net/wireless/mediatek/mt76/tx.c | 511 ++++++++++++++++++++++++++ drivers/net/wireless/mediatek/mt76/util.c | 78 ++++ drivers/net/wireless/mediatek/mt76/util.h | 44 +++ 12 files changed, 2218 insertions(+) create mode 100644 drivers/net/wireless/mediatek/mt76/debugfs.c create mode 100644 drivers/net/wireless/mediatek/mt76/dma.c create mode 100644 drivers/net/wireless/mediatek/mt76/dma.h create mode 100644 drivers/net/wireless/mediatek/mt76/eeprom.c create mode 100644 drivers/net/wireless/mediatek/mt76/mac80211.c create mode 100644 drivers/net/wireless/mediatek/mt76/mmio.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76.h create mode 100644 drivers/net/wireless/mediatek/mt76/trace.c create mode 100644 drivers/net/wireless/mediatek/mt76/trace.h create mode 100644 drivers/net/wireless/mediatek/mt76/tx.c create mode 100644 drivers/net/wireless/mediatek/mt76/util.c create mode 100644 drivers/net/wireless/mediatek/mt76/util.h
drivers/net/wireless/mediatek/mt76/debugfs.c new file +77 -0
@@ -0,0 +1,77 @@ +/* +* Copyright (C) 2016 Felix Fietkau <[email protected]> +* +* Permission to use, copy, modify, and/or distribute this software for any +* purpose with or without fee is hereby granted, provided that the above +* copyright notice and this permission notice appear in all copies. +* +* THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES +* WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF +* MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR +* ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES +* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN +* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF +* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. +*/ +#include "mt76.h" + +static int +mt76_reg_set (void *data,u64 val) +{ +struct mt76_dev *dev = data; + + dev->bus->wr (dev, dev->debugfs_reg, val); +return 0 ; +} + +static int +mt76_reg_get (void *data,u64 *val) +{ +struct mt76_dev *dev = data; + + *val = dev->bus->rr (dev, dev->debugfs_reg); +return 0 ; +} + +DEFINE_SIMPLE_ATTRIBUTE (fops_regval, mt76_reg_get, mt76_reg_set,"0x%08llx\n" ); + +static int +mt76_queues_read (struct seq_file *s,void *data) +{ +struct mt76_dev *dev =dev_get_drvdata (s->private); +int i; + +for (i =0 ; i <ARRAY_SIZE (dev->q_tx); i++) { +struct mt76_queue *q = &dev->q_tx[i]; + +if (!q->ndesc) +continue ; + +seq_printf (s, +"%d: queued=%d head=%d tail=%d swq_queued=%d\n" , + i, q->queued, q->head, q->tail, q->swq_queued); + } + +return 0 ; +} + +struct dentry *mt76_register_debugfs (struct mt76_dev *dev) +{ +struct dentry *dir; + + dir =debugfs_create_dir ("mt76" , dev->hw->wiphy->debugfsdir); +if (!dir) +return NULL ; + +debugfs_create_u8 ("led_pin" ,S_IRUSR |S_IWUSR , dir, &dev->led_pin); +debugfs_create_u32 ("regidx" ,S_IRUSR |S_IWUSR , dir, &dev->debugfs_reg); +debugfs_create_file ("regval" ,S_IRUSR |S_IWUSR , dir, dev, + &fops_regval); +debugfs_create_blob ("eeprom" ,S_IRUSR , dir, &dev->eeprom); +if (dev->otp.data) +debugfs_create_blob ("otp" ,S_IRUSR , dir, &dev->otp); +debugfs_create_devm_seqfile (dev->dev,"queues" , dir, mt76_queues_read); + +return dir; +} +EXPORT_SYMBOL_GPL (mt76_register_debugfs);
drivers/net/wireless/mediatek/mt76/dma.c new file +451 -0
451 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/dma.h new file +38 -0
@@ -0,0 +1,38 @@ +/* +* Copyright (C) 2016 Felix Fietkau <[email protected]> +* +* Permission to use, copy, modify, and/or distribute this software for any +* purpose with or without fee is hereby granted, provided that the above +* copyright notice and this permission notice appear in all copies. +* +* THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES +* WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF +* MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR +* ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES +* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN +* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF +* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. +*/ +#ifndef __MT76_DMA_H +#define __MT76_DMA_H + +#define MT_RING_SIZE 0x10 + +#define MT_DMA_CTL_SD_LEN1 GENMASK(13, 0) +#define MT_DMA_CTL_LAST_SEC1 BIT(14) +#define MT_DMA_CTL_BURST BIT(15) +#define MT_DMA_CTL_SD_LEN0 GENMASK(29, 16) +#define MT_DMA_CTL_LAST_SEC0 BIT(30) +#define MT_DMA_CTL_DMA_DONE BIT(31) + +struct mt76_desc { +__le32 buf0; +__le32 ctrl; +__le32 buf1; +__le32 info; +} __packed__aligned(4) ; + +int mt76_dma_attach (struct mt76_dev *dev); +void mt76_dma_cleanup (struct mt76_dev *dev); + +#endif
drivers/net/wireless/mediatek/mt76/eeprom.c new file +112 -0
112 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mac80211.c new file +392 -0
392 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mmio.c new file +61 -0
61 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76.h new file +360 -0
360 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/trace.c new file +23 -0
@@ -0,0 +1,23 @@ +/* +* Copyright (C) 2016 Felix Fietkau <[email protected]> +* +* Permission to use, copy, modify, and/or distribute this software for any +* purpose with or without fee is hereby granted, provided that the above +* copyright notice and this permission notice appear in all copies. +* +* THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES +* WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF +* MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR +* ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES +* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN +* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF +* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. +*/ + +#include <linux/module.h> + +#ifndef __CHECKER__ +#define CREATE_TRACE_POINTS +#include "trace.h" + +#endif
drivers/net/wireless/mediatek/mt76/trace.h new file +71 -0
71 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/tx.c new file +511 -0
511 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/util.c new file +78 -0
78 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/util.h new file +44 -0
44 lines not on this page · raw message
Signature · 1 line
2.14.2
Felix Fietkau
maintainerPATCH v7 3/3 mt76: add driver code for MT76x2e
In reply to Felix FietkauMT76x2e is a 2x2 PCIe 802.11ac chipset by MediaTek. This driver has full support for AP, station, ad-hoc, mesh and monitor mode.
--- drivers/net/wireless/mediatek/Kconfig | 1 + drivers/net/wireless/mediatek/Makefile | 1 + drivers/net/wireless/mediatek/mt76/Kconfig | 10 + drivers/net/wireless/mediatek/mt76/Makefile | 15 + drivers/net/wireless/mediatek/mt76/mt76x2.h | 227 ++++++ drivers/net/wireless/mediatek/mt76/mt76x2_core.c | 88 +++ .../net/wireless/mediatek/mt76/mt76x2_debugfs.c | 133 ++++ drivers/net/wireless/mediatek/mt76/mt76x2_dfs.c | 493 ++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_dfs.h | 80 ++ drivers/net/wireless/mediatek/mt76/mt76x2_dma.c | 183 +++++ drivers/net/wireless/mediatek/mt76/mt76x2_dma.h | 68 ++ drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c | 647 ++++++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.h | 182 +++++ drivers/net/wireless/mediatek/mt76/mt76x2_init.c | 839 +++++++++++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_mac.c | 755 ++++++++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_mac.h | 190 +++++ drivers/net/wireless/mediatek/mt76/mt76x2_main.c | 545 +++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_mcu.c | 451 +++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_mcu.h | 155 ++++ drivers/net/wireless/mediatek/mt76/mt76x2_pci.c | 110 +++ drivers/net/wireless/mediatek/mt76/mt76x2_phy.c | 758 +++++++++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_regs.h | 587 ++++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_trace.c | 23 + drivers/net/wireless/mediatek/mt76/mt76x2_trace.h | 144 ++++ drivers/net/wireless/mediatek/mt76/mt76x2_tx.c | 258 +++++++ 25 files changed, 6943 insertions(+) create mode 100644 drivers/net/wireless/mediatek/mt76/Kconfig create mode 100644 drivers/net/wireless/mediatek/mt76/Makefile create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_core.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_debugfs.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_dfs.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_dfs.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_dma.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_dma.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_init.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_mac.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_mac.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_main.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_mcu.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_mcu.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_pci.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_phy.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_regs.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_trace.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_trace.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_tx.c
drivers/net/wireless/mediatek/Kconfig +1 -0
@@ -11,4 +11,5 @@ config WLAN_VENDOR_MEDIATEK if WLAN_VENDOR_MEDIATEK source "drivers/net/wireless/mediatek/mt7601u/Kconfig" +source "drivers/net/wireless/mediatek/mt76/Kconfig" endif # WLAN_VENDOR_MEDIATEK
drivers/net/wireless/mediatek/Makefile +1 -0
@@ -1 +1,2 @@ obj-$(CONFIG_MT7601U) += mt7601u/ +obj-$(CONFIG_MT76_CORE) += mt76/
drivers/net/wireless/mediatek/mt76/Kconfig new file +10 -0
@@ -0,0 +1,10 @@ +config MT76_CORE + tristate + +config MT76x2E + tristate "MediaTek MT76x2E (PCIe) support" + select MT76_CORE + depends on MAC80211 + depends on PCI + ---help--- + This adds support for MT7612/MT7602/MT7662-based wireless PCIe devices.
drivers/net/wireless/mediatek/mt76/Makefile new file +15 -0
@@ -0,0 +1,15 @@ +obj-$(CONFIG_MT76_CORE) += mt76.o +obj-$(CONFIG_MT76x2E) += mt76x2e.o + +mt76-y := \ + mmio.o util.o trace.o dma.o mac80211.o debugfs.o eeprom.o tx.o + +CFLAGS_trace.o := -I$(src) + +mt76x2e-y := \ + mt76x2_pci.o mt76x2_dma.o \ + mt76x2_main.o mt76x2_init.o mt76x2_debugfs.o mt76x2_tx.o \ + mt76x2_core.o mt76x2_mac.o mt76x2_eeprom.o mt76x2_mcu.o mt76x2_phy.o \ + mt76x2_dfs.o mt76x2_trace.o + +CFLAGS_mt76x2_trace.o := -I$(src)
drivers/net/wireless/mediatek/mt76/mt76x2.h new file +227 -0
227 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_core.c new file +88 -0
88 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_debugfs.c new file +133 -0
133 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_dfs.c new file +493 -0
493 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_dfs.h new file +80 -0
80 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_dma.c new file +183 -0
183 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_dma.h new file +68 -0
68 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c new file +647 -0
647 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.h new file +182 -0
182 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_init.c new file +839 -0
839 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c new file +755 -0
28 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_mac.h new file +190 -0
190 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_main.c new file +545 -0
545 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_mcu.c new file +451 -0
451 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_mcu.h new file +155 -0
155 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_pci.c new file +110 -0
110 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_phy.c new file +758 -0
758 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_regs.h new file +587 -0
587 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_trace.c new file +23 -0
Lines of this file are not shown. View the raw message.
drivers/net/wireless/mediatek/mt76/mt76x2_trace.h new file +144 -0
144 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_tx.c new file +258 -0
258 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.14.2
Part of the diff is not shown here. View the raw message.
kbuild test robot
build botRe: [PATCH v7 3/3] mt76: add driver code for MT76x2e
I love your patch! Yet something to improve:
Hi Felix,
I love your patch! Yet something to improve:
[auto build test ERROR on wireless-drivers-next/master]
[also build test ERROR on v4.14 next-20171122]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Felix-Fietkau/dt-bindings-net-add-mt76-wireless-device-binding/20171123-125723 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: tile-allyesconfig (attached as .config) compiler: tilegx-linux-gcc (GCC) 4.6.2
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=tile
All errors (new ones prefixed by >>):
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c: In function 'mt76x2_mac_process_rate':
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:49:20: error: 'RX_FLAG_SHORTPRE' undeclared (first use in this function) drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:49:20: note: each undeclared identifier is reported only once for each function it appears in drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:58:19: error: 'RX_FLAG_HT_GF' undeclared (first use in this function) drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:61:19: error: 'RX_FLAG_HT' undeclared (first use in this function) drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:65:19: error: 'RX_FLAG_VHT' undeclared (first use in this function) drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:67:9: error: 'struct ieee80211_rx_status' has no member named 'vht_nss' drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:75:19: error: 'RX_FLAG_LDPC' undeclared (first use in this function) drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:78:19: error: 'RX_FLAG_SHORT_GI' undeclared (first use in this function) drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:81:24: error: 'RX_FLAG_STBC_SHIFT' undeclared (first use in this function) drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:87:19: error: 'RX_FLAG_40MHZ' undeclared (first use in this function)
>> drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:90:9: error: 'struct ieee80211_rx_status' has no member named 'vht_flag'
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:90:23: error: 'RX_VHT_FLAG_80MHZ' undeclared (first use in this function)
vim +90 drivers/net/wireless/mediatek/mt76/mt76x2_mac.c
30
31 static void
32 mt76x2_mac_process_rate(struct ieee80211_rx_status *status, u16 rate)
33 {
34 u8 idx = FIELD_GET(MT_RXWI_RATE_INDEX, rate);
35
36 switch (FIELD_GET(MT_RXWI_RATE_PHY, rate)) {
37 case MT_PHY_TYPE_OFDM:
38 if (idx >= 8)
39 idx = 0;
40
41 if (status->band == NL80211_BAND_2GHZ)
42 idx += 4;
43
44 status->rate_idx = idx;
45 return;
46 case MT_PHY_TYPE_CCK:
47 if (idx >= 8) {
48 idx -= 8;
> 49 status->flag |= RX_FLAG_SHORTPRE;
50 }
51
52 if (idx >= 4)
53 idx = 0;
54
55 status->rate_idx = idx;
56 return;
57 case MT_PHY_TYPE_HT_GF:
58 status->flag |= RX_FLAG_HT_GF;
59 /* fall through */
60 case MT_PHY_TYPE_HT:
61 status->flag |= RX_FLAG_HT;
62 status->rate_idx = idx;
63 break;
64 case MT_PHY_TYPE_VHT:
65 status->flag |= RX_FLAG_VHT;
66 status->rate_idx = FIELD_GET(MT_RATE_INDEX_VHT_IDX, idx);
67 status->vht_nss = FIELD_GET(MT_RATE_INDEX_VHT_NSS, idx) + 1;
68 break;
69 default:
70 WARN_ON(1);
71 return;
72 }
73
74 if (rate & MT_RXWI_RATE_LDPC)
75 status->flag |= RX_FLAG_LDPC;
76
77 if (rate & MT_RXWI_RATE_SGI)
78 status->flag |= RX_FLAG_SHORT_GI;
79
80 if (rate & MT_RXWI_RATE_STBC)
81 status->flag |= 1 << RX_FLAG_STBC_SHIFT;
82
83 switch (FIELD_GET(MT_RXWI_RATE_BW, rate)) {
84 case MT_PHY_BW_20:
85 break;
86 case MT_PHY_BW_40:
87 status->flag |= RX_FLAG_40MHZ;
88 break;
89 case MT_PHY_BW_80:
> 90 status->vht_flag |= RX_VHT_FLAG_80MHZ;
91 break;
92 default:
93 break;
94 }
95 }
96 ---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Re: [PATCH v7 3/3] mt76: add driver code for MT76x2e
Quoted 29 lines · kbuild test robot
I love your patch! Yet something to improve:
[auto build test ERROR on wireless-drivers-next/master]
[also build test ERROR on v4.14 next-20171122]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]url: https://github.com/0day-ci/linux/commits/Felix-Fietkau/dt-bindings-net-add-mt76-wireless-device-binding/20171123-125723 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: tile-allyesconfig (attached as .config) compiler: tilegx-linux-gcc (GCC) 4.6.2reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=tileAll errors (new ones prefixed by >>):
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c: In function 'mt76x2_mac_process_rate':
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:49:20: error: 'RX_FLAG_SHORTPRE' undeclared (first use in this function)drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:49:20: note: each undeclared identifier is reported only once for each function it appears indrivers/net/wireless/mediatek/mt76/mt76x2_mac.c:58:19: error: 'RX_FLAG_HT_GF' undeclared (first use in this function)drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:61:19: error: 'RX_FLAG_HT' undeclared (first use in this function)drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:65:19: error: 'RX_FLAG_VHT' undeclared (first use in this function)drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:67:9: error: 'structieee80211_rx_status' has no member named 'vht_nss'drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:75:19: error: 'RX_FLAG_LDPC' undeclared (first use in this function)drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:78:19: error: 'RX_FLAG_SHORT_GI' undeclared (first use in this function)drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:81:24: error: 'RX_FLAG_STBC_SHIFT' undeclared (first use in this function)drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:87:19: error: 'RX_FLAG_40MHZ' undeclared (first use in this function)
Quoted 2 lines
Quoted 1 line
Quoted 1 line
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:90:9: error: 'structieee80211_rx_status' has no member named 'vht_flag'
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:90:23: error: 'RX_VHT_FLAG_80MHZ' undeclared (first use in this function)
Felix fixed these in v8.
Signature · 1 line
Kalle Valo
kbuild test robot
build bot[PATCH] mt76: fix debugfs_simple_attr.cocci warnings
In reply to Felix Fietkaudrivers/net/wireless/mediatek/mt76/debugfs.c:36:0-23: WARNING: fops_regval should be defined with DEFINE_DEBUGFS_ATTRIBUTE
drivers/net/wireless/mediatek/mt76/debugfs.c:36:0-23: WARNING: fops_regval should be defined with DEFINE_DEBUGFS_ATTRIBUTE
Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE for debugfs files.
Semantic patch information:
Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() imposes some significant overhead as compared to DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().
Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
---
Please take the patch only if it's a positive warning. Thanks!
debugfs.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/net/wireless/mediatek/mt76/debugfs.c +4 -3
@@ -33,7 +33,8 @@ mt76_reg_get(void *data, u64 *val)return 0 ; } -DEFINE_SIMPLE_ATTRIBUTE (fops_regval, mt76_reg_get, mt76_reg_set,"0x%08llx\n" ); +DEFINE_DEBUGFS_ATTRIBUTE (fops_regval, mt76_reg_get, mt76_reg_set, +"0x%08llx\n" );static int mt76_queues_read (struct seq_file *s,void *data)
@@ -65,8 +66,8 @@ struct dentry *mt76_register_debugfs(strdebugfs_create_u8 ("led_pin" ,S_IRUSR |S_IWUSR , dir, &dev->led_pin);debugfs_create_u32 ("regidx" ,S_IRUSR |S_IWUSR , dir, &dev->debugfs_reg); -debugfs_create_file ("regval" ,S_IRUSR |S_IWUSR , dir, dev, - &fops_regval); +debugfs_create_file_unsafe ("regval" ,S_IRUSR |S_IWUSR , dir, dev, + &fops_regval);debugfs_create_blob ("eeprom" ,S_IRUSR , dir, &dev->eeprom);if (dev->otp.data)debugfs_create_blob ("otp" ,S_IRUSR , dir, &dev->otp);
Re: [PATCH] mt76: fix debugfs_simple_attr.cocci warnings
Quoted 10 lines · kbuild test robot
drivers/net/wireless/mediatek/mt76/debugfs.c:36:0-23: WARNING:
fops_regvalshould be defined withDEFINE_DEBUGFS_ATTRIBUTEUse
DEFINE_DEBUGFS_ATTRIBUTErather thanDEFINE_SIMPLE_ATTRIBUTEfor debugfs files.Semantic patch information:
Rationale:DEFINE_SIMPLE_ATTRIBUTE+debugfs_create_file()imposes some significant overhead as compared toDEFINE_DEBUGFS_ATTRIBUTE+debugfs_create_file_unsafe().
Quoted 5 lines
Generated by:
scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocciFixes a5f6039c8f9c ("mt76: add driver code for MT76x2e")CC Felix Fietkau <[email protected]>Signed-off-by Fengguang Wu <[email protected]>
I would like to apply this but the From field doesn't match the s-o-b line. This patch is created automatically, right? I think the best is that if you modify your script to add this to the beginning of the commit log:
From: Fengguang Wu <[email protected]>
That way From and s-o-b match and you can continue to submit it from the lkp address.
Signature · 1 line
Kalle Valo
Fengguang Wu
build botRe: [PATCH] mt76: fix debugfs_simple_attr.cocci warnings
Good idea! I'll follow up with the change.
Hi Kalle,
On Thu, Dec 07, 2017 at 03:42:39PM +0200, Kalle Valo wrote:
>kbuild test robot <[email protected]> writes: > >> drivers/net/wireless/mediatek/mt76/debugfs.c:36:0-23: WARNING: fops_regval should be defined with DEFINE_DEBUGFS_ATTRIBUTE >> >> Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE >> for debugfs files. >> >> Semantic patch information: >> Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() >> imposes some significant overhead as compared to >> DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). >> >> Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci >> >> Fixes: a5f6039c8f9c ("mt76: add driver code for MT76x2e") >> CC: Felix Fietkau <[email protected]> >> Signed-off-by: Fengguang Wu <[email protected]> > >I would like to apply this but the From field doesn't match the s-o-b >line. This patch is created automatically, right? I think the best is >that if you modify your script to add this to the beginning of the >commit log: > >From: Fengguang Wu <[email protected]> > >That way From and s-o-b match and you can continue to submit it from the >lkp address.
Good idea! I'll follow up with the change.
Thanks,
Fengguang
kbuild test robot
build bot[PATCH] mt76: fix returnvar.cocci warnings
In reply to Felix Fietkaudrivers/net/wireless/mediatek/mt76/mt76x2_main.c:86:5-8: Unneeded variable: "ret". Return "0" on line 112
drivers/net/wireless/mediatek/mt76/mt76x2_main.c:86:5-8: Unneeded variable: "ret". Return "0" on line 112
Remove unneeded variable used to store return value.
Generated by: scripts/coccinelle/misc/returnvar.cocci
---
Please take the patch only if it's a positive warning. Thanks!
mt76x2_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/wireless/mediatek/mt76/mt76x2_main.c +1 -2
@@ -83,7 +83,6 @@ mt76x2_add_interface(struct ieee80211_hwstruct mt76x2_dev *dev = hw->priv;struct mt76x2_vif *mvif = (struct mt76x2_vif *) vif->drv_priv;unsigned int idx =0 ; -int ret =0 ;if (vif->addr[0 ] &BIT (1 )) idx =1 + (((dev->mt76.macaddr[0 ] ^ vif->addr[0 ]) >>2 ) &7 );
@@ -109,7 +108,7 @@ mt76x2_add_interface(struct ieee80211_hw mvif->group_wcid.hw_key_idx =-1 ;mt76x2_txq_init (dev, vif->txq); -return ret; +return 0 ; } static void
Re: [PATCH] mt76: fix returnvar.cocci warnings
Quoted 10 lines · kbuild test robot
drivers/net/wireless/mediatek/mt76/mt76x2_main.c:86:5-8: Unneeded variable: "ret". Return "0" on line 112
Remove unneeded variable used to store return value.
Generated by:
scripts/coccinelle/misc/returnvar.cocciFixes a5f6039c8f9c ("mt76: add driver code for MT76x2e")CC Felix Fietkau <[email protected]>Signed-off-by Fengguang Wu <[email protected]>
Here als the same problem with mismatching From and s-o-b lines.
Signature · 1 line
Kalle Valo
kbuild test robot
build botRe: [PATCH v7 3/3] mt76: add driver code for MT76x2e
In reply to Felix FietkauI love your patch! Yet something to improve:
Hi Felix,
I love your patch! Yet something to improve:
[auto build test ERROR on wireless-drivers-next/master]
[also build test ERROR on v4.14 next-20171122]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Felix-Fietkau/dt-bindings-net-add-mt76-wireless-device-binding/20171123-125723 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: i386-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026 reproduce: # save the attached .config to linux build tree make ARCH=i386
All error/warnings (new ones prefixed by >>):
drivers/net/wireless/mediatek/mt76/mac80211.c: In function 'mt76_led_init':
>> drivers/net/wireless/mediatek/mt76/mac80211.c:111:7: error: implicit declaration of function 'of_get_child_by_name' [-Werror=implicit-function-declaration]
np = of_get_child_by_name(np, "led");
^~~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/mediatek/mt76/mac80211.c:111:5: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
np = of_get_child_by_name(np, "led");
^
>> drivers/net/wireless/mediatek/mt76/mac80211.c:113:8: error: implicit declaration of function 'of_property_read_u32' [-Werror=implicit-function-declaration]
if (!of_property_read_u32(np, "led-sources", &led_pin))
^~~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/mediatek/mt76/mac80211.c:115:17: error: implicit declaration of function 'of_property_read_bool' [-Werror=implicit-function-declaration]
dev->led_al = of_property_read_bool(np, "led-active-low");
^~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c: In function 'mt76x2_mac_process_rate':
>> drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:49:20: error: 'RX_FLAG_SHORTPRE' undeclared (first use in this function)
status->flag |= RX_FLAG_SHORTPRE;
^~~~~~~~~~~~~~~~
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:49:20: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:58:19: error: 'RX_FLAG_HT_GF' undeclared (first use in this function)
status->flag |= RX_FLAG_HT_GF;
^~~~~~~~~~~~~
>> drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:61:19: error: 'RX_FLAG_HT' undeclared (first use in this function)
status->flag |= RX_FLAG_HT;
^~~~~~~~~~
>> drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:65:19: error: 'RX_FLAG_VHT' undeclared (first use in this function)
status->flag |= RX_FLAG_VHT;
^~~~~~~~~~~
>> drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:67:9: error: 'struct ieee80211_rx_status' has no member named 'vht_nss'
status->vht_nss = FIELD_GET(MT_RATE_INDEX_VHT_NSS, idx) + 1;
^~
>> drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:75:19: error: 'RX_FLAG_LDPC' undeclared (first use in this function)
status->flag |= RX_FLAG_LDPC;
^~~~~~~~~~~~
>> drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:78:19: error: 'RX_FLAG_SHORT_GI' undeclared (first use in this function)
status->flag |= RX_FLAG_SHORT_GI;
^~~~~~~~~~~~~~~~
>> drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:81:24: error: 'RX_FLAG_STBC_SHIFT' undeclared (first use in this function)
status->flag |= 1 << RX_FLAG_STBC_SHIFT;
^~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:87:19: error: 'RX_FLAG_40MHZ' undeclared (first use in this function)
status->flag |= RX_FLAG_40MHZ;
^~~~~~~~~~~~~
>> drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:90:9: error: 'struct ieee80211_rx_status' has no member named 'vht_flag'; did you mean 'flag'?
status->vht_flag |= RX_VHT_FLAG_80MHZ;
^~
>> drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:90:23: error: 'RX_VHT_FLAG_80MHZ' undeclared (first use in this function)
status->vht_flag |= RX_VHT_FLAG_80MHZ;
^~~~~~~~~~~~~~~~~coccinelle warnings: (new ones prefixed by >>)
>> drivers/net/wireless/mediatek/mt76/debugfs.c:36:0-23: WARNING: fops_regval should be defined with DEFINE_DEBUGFS_ATTRIBUTE -- >> drivers/net/wireless/mediatek/mt76/mt76x2_main.c:86:5-8: Unneeded variable: "ret". Return "0" on line 112
Please review and possibly fold the followup patch.
vim +/RX_FLAG_SHORTPRE +49 drivers/net/wireless/mediatek/mt76/mt76x2_mac.c
30
31 static void
32 mt76x2_mac_process_rate(struct ieee80211_rx_status *status, u16 rate)
33 {
34 u8 idx = FIELD_GET(MT_RXWI_RATE_INDEX, rate);
35
36 switch (FIELD_GET(MT_RXWI_RATE_PHY, rate)) {
37 case MT_PHY_TYPE_OFDM:
38 if (idx >= 8)
39 idx = 0;
40
41 if (status->band == NL80211_BAND_2GHZ)
42 idx += 4;
43
44 status->rate_idx = idx;
45 return;
46 case MT_PHY_TYPE_CCK:
47 if (idx >= 8) {
48 idx -= 8;
> 49 status->flag |= RX_FLAG_SHORTPRE;
50 }
51
52 if (idx >= 4)
53 idx = 0;
54
55 status->rate_idx = idx;
56 return;
57 case MT_PHY_TYPE_HT_GF:
> 58 status->flag |= RX_FLAG_HT_GF;
59 /* fall through */
60 case MT_PHY_TYPE_HT:
> 61 status->flag |= RX_FLAG_HT;
62 status->rate_idx = idx;
63 break;
64 case MT_PHY_TYPE_VHT:
> 65 status->flag |= RX_FLAG_VHT;
66 status->rate_idx = FIELD_GET(MT_RATE_INDEX_VHT_IDX, idx);
> 67 status->vht_nss = FIELD_GET(MT_RATE_INDEX_VHT_NSS, idx) + 1;
68 break;
69 default:
70 WARN_ON(1);
71 return;
72 }
73
74 if (rate & MT_RXWI_RATE_LDPC)
> 75 status->flag |= RX_FLAG_LDPC;
76
77 if (rate & MT_RXWI_RATE_SGI)
> 78 status->flag |= RX_FLAG_SHORT_GI;
79
80 if (rate & MT_RXWI_RATE_STBC)
> 81 status->flag |= 1 << RX_FLAG_STBC_SHIFT;
82
83 switch (FIELD_GET(MT_RXWI_RATE_BW, rate)) {
84 case MT_PHY_BW_20:
85 break;
86 case MT_PHY_BW_40:
> 87 status->flag |= RX_FLAG_40MHZ;
88 break;
89 case MT_PHY_BW_80:
> 90 status->vht_flag |= RX_VHT_FLAG_80MHZ;
91 break;
92 default:
93 break;
94 }
95 }
96 ---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation