Skip to contentSkip to conversation

ARM: dts: exynos: correct trats2 panel reset line

PATCH New Simon Shields 3 participants 3 messages Nov 21, 2017 – Nov 27, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: exynos: correct trats2 panel reset line

trats2 uses gpf2-1 as the panel reset GPIO. gpy4-5 was only used on early revisions of the board.

Fixes 420ae8451a22 ("ARM: dts: exynos4412-trats2: add panel node")
---
 arch/arm/boot/dts/exynos4412-trats2.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos4412-trats2.dts +1 -1
index 220cdf109405..9f4672ba9943 100644
@@ -454,7 +454,7 @@
 		reg = <0>;
 		vdd3-supply = <&lcd_vdd3_reg>;
 		vci-supply = <&ldo25_reg>;
-		reset-gpios = <&gpy4 5 GPIO_ACTIVE_HIGH>;
+		reset-gpios = <&gpf2 1 GPIO_ACTIVE_HIGH>;
 		power-on-delay= <50>;
 		reset-delay = <100>;
 		init-delay = <100>;
Signature · 1 line
2.15.0
#1 lore raw

PATCH 1/1 ARM: dts: exynos: correct trats2 panel reset line

Hi Simon,

Quoted 5 lines · Simon Shields

trats2 uses gpf2-1 as the panel reset GPIO. gpy4-5 was only used on early revisions of the board.

Fixes 420ae8451a22 ("ARM: dts: exynos4412-trats2: add panel node")

It looks that this has been accidentally copy/pasted from the previous dts used for early version of the development board. I've checked the Trats2 schematic and indeed gpf2-1 is the correct pin for panel reset line.

Quoted 9 lines
---
  arch/arm/boot/dts/exynos4412-trats2.dts | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos4412-trats2.dts +0 -0
index 220cdf109405..9f4672ba9943 100644

arch/arm/boot/dts/exynos4412-trats2.dts line 460

Quoted 8 lines
arch/arm/boot/dts/exynos4412-trats2.dts +1 -1
@@ -454,7 +454,7 @@
  		reg = <0>;
  		vdd3-supply = <&lcd_vdd3_reg>;
  		vci-supply = <&ldo25_reg>;
-		reset-gpios = <&gpy4 5 GPIO_ACTIVE_HIGH>;
+		reset-gpios = <&gpf2 1 GPIO_ACTIVE_HIGH>;
  		power-on-delay= <50>;
  		reset-delay = <100>;
  		init-delay = <100>;

Best regards

Signature · 2 lines
Marek Szyprowski, PhD
Samsung R&D Institute Poland
maintainer Applied
#2 lore raw

PATCH 1/1 ARM: dts: exynos: correct trats2 panel reset line

Quoted 9 lines · Marek Szyprowski

Hi Simon,

Quoted 5 lines · Simon Shields

trats2 uses gpf2-1 as the panel reset GPIO. gpy4-5 was only used on early revisions of the board.

Fixes 420ae8451a22 ("ARM: dts: exynos4412-trats2: add panel node")
Quoted 7 lines

It looks that this has been accidentally copy/pasted from the previous dts used for early version of the development board. I've checked the Trats2 schematic and indeed gpf2-1 is the correct pin for panel reset line.

Thanks for testing.

Thanks, applied.

Best regards,
Krzysztof