Skip to contentSkip to conversation

envtools: make sure version/timestamp header file are available

PATCH In review Stefan Agner 4 participants 4 messages Nov 14, 2017 – Nov 21, 2017 Kbuild

lore
Share & tools
lore

Stefan Agner

author
#0 lore raw

PATCH 1/1 envtools: make sure version/timestamp header file are available

From: Stefan Agner <[email protected]>

With commit 84d46e7e8948 ("tools: env: allow to print U-Boot version") the fw_env utilities need the version.h header file. Building only the envtools in a pristine build directory will fail due to missing header files.

Make sure the header files are a dependency of the envtools target.

Fixes 84d46e7e8948 ("tools: env: allow to print U-Boot version")
Signed-off-by Stefan Agner <[email protected]>

---

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
index 67f01ad7e4..b93c2fb05b 100644
@@ -1460,7 +1460,7 @@ checkarmreloc: u-boot
 		false; \
 	fi
 
-envtools: scripts_basic
+envtools: scripts_basic $(version_h) $(timestamp_h)
 	$(Q)$(MAKE) $(build)=tools/env
 
 tools-only: scripts_basic $(version_h) $(timestamp_h)
Signature · 1 line
2.15.0
#1 lore raw

PATCH 1/1 envtools: make sure version/timestamp header file are available

Quoted 11 lines · Stefan Agner

From: Stefan Agner <[email protected]>

With commit 84d46e7e8948 ("tools: env: allow to print U-Boot version") the fw_env utilities need the version.h header file. Building only the envtools in a pristine build directory will fail due to missing header files.

Make sure the header files are a dependency of the envtools target.

Fixes 84d46e7e8948 ("tools: env: allow to print U-Boot version")
Signed-off-by Stefan Agner <[email protected]>
Tested-by Peter Robinson <[email protected]>

Fixes build issues I saw with 2017.11 GA that I have seen.

Peter

Quoted 25 lines

---

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -2
index 67f01ad7e4..b93c2fb05b 100644
@@ -1460,7 +1460,7 @@ checkarmreloc: u-boot
                false; \
        fi
 
-envtools: scripts_basic
+envtools: scripts_basic $(version_h) $(timestamp_h)
        $(Q)$(MAKE) $(build)=tools/env
 
 tools-only: scripts_basic $(version_h) $(timestamp_h)
--

2.15.0

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

#2 lore raw

PATCH 1/1 envtools: make sure version/timestamp header file are available

In reply to Stefan Agner
Quoted 7 lines · Stefan Agner

From: Stefan Agner <[email protected]>

With commit 84d46e7e8948 ("tools: env: allow to print U-Boot version") the fw_env utilities need the version.h header file. Building only the envtools in a pristine build directory will fail due to missing header files.

Quoted 8 lines

Make sure the header files are a dependency of the envtools target.

Fixes 84d46e7e8948 ("tools: env: allow to print U-Boot version")
Signed-off-by Stefan Agner <[email protected]>

---

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by Simon Glass <[email protected]>
#3 lore raw
In reply to Stefan Agner
Quoted 7 lines · Stefan Agner

From: Stefan Agner <[email protected]>

With commit 84d46e7e8948 ("tools: env: allow to print U-Boot version") the fw_env utilities need the version.h header file. Building only the envtools in a pristine build directory will fail due to missing header files.

Quoted 6 lines

Make sure the header files are a dependency of the envtools target.

Fixes 84d46e7e8948 ("tools: env: allow to print U-Boot version")
Signed-off-by Stefan Agner <[email protected]>
Tested-by Peter Robinson <[email protected]>
Reviewed-by Simon Glass <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171121/e39c9909/attachment.sig>