Skip to contentSkip to conversation

dt-bindings: usb: add #phy-cells to usb-nop-xceiv

PATCH New Rob Herring 7 participants 17 messages Nov 9, 2017 – Dec 7, 2017

Subsystems (3)
Device tree bindings USB Arm i.MX and Layerscape
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/6 dt-bindings: usb: add #phy-cells to usb-nop-xceiv

Consumers of usb-nop-xceiv use the phy binding, but #phy-cells is missing from the binding. This is probably because this binding predates the common phy binding. So add #phy-cells as a required property. This should not break any users as missing should be treated as 0 cells.

Signed-off-by Rob Herring <[email protected]>

---
I'll apply to DT tree.

 Documentation/devicetree/bindings/usb/usb-nop-xceiv.txt | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/usb/usb-nop-xceiv.txt +2 -0
index 5be01c859b7a..4dc6a8ee3071 100644
@@ -2,6 +2,7 @@ USB NOP PHY
 
 Required properties:
 - compatible: should be usb-nop-xceiv
+- #phy-cells: Must be 0
 
 Optional properties:
 - clocks: phandle to the PHY clock. Use as per Documentation/devicetree

@@ -33,6 +34,7 @@ Example:
 		reset-gpios = <&gpio1 7 GPIO_ACTIVE_LOW>;
 		vbus-detect-gpio = <&gpio2 13 GPIO_ACTIVE_HIGH>;
 		vbus-regulator = <&vbus_regulator>;
+		#phy-cells = <0>;
 	};
 
 hsusb1_phy is a NOP USB PHY device that gets its clock from an oscillator
Signature · 1 line
2.14.1
author maintainer
#1 lore raw

PATCH 2/6 arm: dts: imx: Add missing #phy-cells to usb-nop-xceiv

"usb-nop-xceiv" is using the phy binding, but is missing #phy-cells property. This is probably because the binding was the precursor to the phy binding.

Fixes the following warning in i.MX dts files:

Warning (phys_property): Missing property '#phy-cells' in node ...

Signed-off-by Rob Herring <[email protected]>
Cc Shawn Guo <[email protected]>
Cc Sascha Hauer <[email protected]>
Cc Fabio Estevam <[email protected]>

---
Please apply to i.MX tree.

 arch/arm/boot/dts/imx25.dtsi                           | 2 ++
 arch/arm/boot/dts/imx27-pdk.dts                        | 1 +
 arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts         | 1 +
 arch/arm/boot/dts/imx27-phytec-phycore-som.dtsi        | 1 +
 arch/arm/boot/dts/imx35.dtsi                           | 2 ++
 arch/arm/boot/dts/imx51-babbage.dts                    | 1 +
 arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts | 1 +
 arch/arm/boot/dts/imx51.dtsi                           | 1 +
 arch/arm/boot/dts/imx53.dtsi                           | 2 ++
 arch/arm/boot/dts/imx7d.dtsi                           | 1 +
 arch/arm/boot/dts/imx7s.dtsi                           | 2 ++
 11 files changed, 15 insertions(+)
arch/arm/boot/dts/imx25.dtsi +2 -0
index 09ce8b81fafa..c43cf704b768 100644
@@ -628,11 +628,13 @@
 		usbphy0: usb-phy at 0 {
 			reg = <0>;
 			compatible = "usb-nop-xceiv";
+			#phy-cells = <0>;
 		};
 
 		usbphy1: usb-phy at 1 {
 			reg = <1>;
 			compatible = "usb-nop-xceiv";
+			#phy-cells = <0>;
 		};
 	};
 };
arch/arm/boot/dts/imx27-pdk.dts +1 -0
index 96f442ba6d22..2a140c8ae6d2 100644
@@ -30,6 +30,7 @@
 			reg = <0>;
 			clocks = <&clks IMX27_CLK_DUMMY>;
 			clock-names = "main_clk";
+			#phy-cells = <0>;
 		};
 	};
 };
arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts +1 -0
index 2a9198f99a8d..2ed2d73b087e 100644
@@ -63,6 +63,7 @@
 			vcc-supply = <&reg_5v0>;
 			clocks = <&clks IMX27_CLK_DUMMY>;
 			clock-names = "main_clk";
+			#phy-cells = <0>;
 		};
 	};
 };
arch/arm/boot/dts/imx27-phytec-phycore-som.dtsi +1 -0
index c973c5d91875..c9095b7654c6 100644
@@ -53,6 +53,7 @@
 			vcc-supply = <&sw3_reg>;
 			clocks = <&clks IMX27_CLK_DUMMY>;
 			clock-names = "main_clk";
+			#phy-cells = <0>;
 		};
 	};
 };
arch/arm/boot/dts/imx35.dtsi +2 -0
index 6d5e6a60bee7..f049c692c6b0 100644
@@ -402,11 +402,13 @@
 		usbphy0: usb-phy at 0 {
 			reg = <0>;
 			compatible = "usb-nop-xceiv";
+			#phy-cells = <0>;
 		};
 
 		usbphy1: usb-phy at 1 {
 			reg = <1>;
 			compatible = "usb-nop-xceiv";
+			#phy-cells = <0>;
 		};
 	};
 };
arch/arm/boot/dts/imx51-babbage.dts +1 -0
index 873cf242679c..699ee77c284e 100644
@@ -165,6 +165,7 @@
 			clocks = <&clks IMX5_CLK_DUMMY>;
 			clock-names = "main_clk";
 			reset-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>;
+			#phy-cells = <0>;
 		};
 	};
 };
arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts +1 -0
index 1305b05c7ed9..b3d952f37cdc 100644
@@ -94,6 +94,7 @@
 			clocks = <&clks IMX5_CLK_USB_PHY_GATE>;
 			clock-names = "main_clk";
 			clock-frequency = <19200000>;
+			#phy-cells = <0>;
 		};
 	};
 };
arch/arm/boot/dts/imx51.dtsi +1 -0
index 1ee1d542d9ad..c27ab6d88263 100644
@@ -113,6 +113,7 @@
 			reg = <0>;
 			clocks = <&clks IMX5_CLK_USB_PHY_GATE>;
 			clock-names = "main_clk";
+			#phy-cells = <0>;
 		};
 	};
arch/arm/boot/dts/imx53.dtsi +2 -0
index 8bf0d89cdd35..423309df103f 100644
@@ -303,6 +303,7 @@
 				compatible = "usb-nop-xceiv";
 				clocks = <&clks IMX5_CLK_USB_PHY1_GATE>;
 				clock-names = "main_clk";
+				#phy-cells = <0>;
 				status = "okay";
 			};
 

@@ -310,6 +311,7 @@
 				compatible = "usb-nop-xceiv";
 				clocks = <&clks IMX5_CLK_USB_PHY2_GATE>;
 				clock-names = "main_clk";
+				#phy-cells = <0>;
 				status = "okay";
 			};
arch/arm/boot/dts/imx7d.dtsi +1 -0
index f46814a7ea44..7bcdc953dc9e 100644
@@ -109,6 +109,7 @@
 		compatible = "usb-nop-xceiv";
 		clocks = <&clks IMX7D_USB_PHY2_CLK>;
 		clock-names = "main_clk";
+		#phy-cells = <0>;
 	};
 
 	fec2: ethernet at 30bf0000 {
arch/arm/boot/dts/imx7s.dtsi +2 -0
index 82ad26e766eb..ded1504bf602 100644
@@ -949,12 +949,14 @@
 				compatible = "usb-nop-xceiv";
 				clocks = <&clks IMX7D_USB_PHY1_CLK>;
 				clock-names = "main_clk";
+				#phy-cells = <0>;
 			};
 
 			usbphynop3: usbphynop3 {
 				compatible = "usb-nop-xceiv";
 				clocks = <&clks IMX7D_USB_HSIC_ROOT_CLK>;
 				clock-names = "main_clk";
+				#phy-cells = <0>;
 			};
 
 			usdhc1: usdhc at 30b40000 {
Signature · 1 line
2.14.1
Applied
#2 lore raw

PATCH 2/6 arm: dts: imx: Add missing #phy-cells to usb-nop-xceiv

Quoted 4 lines · Rob Herring

"usb-nop-xceiv" is using the phy binding, but is missing #phy-cells property. This is probably because the binding was the precursor to the phy binding.

Quoted 8 lines

Fixes the following warning in i.MX dts files:

Warning (phys_property): Missing property '#phy-cells' in node ...

Signed-off-by Rob Herring <[email protected]>
Cc Shawn Guo <[email protected]>
Cc Sascha Hauer <[email protected]>
Cc Fabio Estevam <[email protected]>

Applied, thanks.

author maintainer
#3 lore raw

PATCH 3/6 arm: dts: marvell: Add missing #phy-cells to usb-nop-xceiv

In reply to Rob Herring

"usb-nop-xceiv" is using the phy binding, but is missing #phy-cells property. This is probably because the binding was the precursor to the phy binding.

Fixes the following warning in Marvell dts files:

Warning (phys_property): Missing property '#phy-cells' in node ...

Signed-off-by Rob Herring <[email protected]>
Cc Jason Cooper <[email protected]>
Cc Andrew Lunn <[email protected]>
Cc Gregory Clement <[email protected]>
Cc Sebastian Hesselbarth <[email protected]>

---
Please apply to Marvell tree.

 arch/arm/boot/dts/armada-385-db-ap.dts          | 1 +
 arch/arm/boot/dts/armada-385-linksys.dtsi       | 1 +
 arch/arm/boot/dts/armada-385-synology-ds116.dts | 2 ++
 arch/arm/boot/dts/armada-388-gp.dts             | 2 ++
 4 files changed, 6 insertions(+)
arch/arm/boot/dts/armada-385-db-ap.dts +1 -0
index 25d2d720dc0e..678aa023335d 100644
@@ -236,6 +236,7 @@
 	usb3_phy: usb3_phy {
 		compatible = "usb-nop-xceiv";
 		vcc-supply = <&reg_xhci0_vbus>;
+		#phy-cells = <0>;
 	};
 
 	reg_xhci0_vbus: xhci0-vbus {
arch/arm/boot/dts/armada-385-linksys.dtsi +1 -0
index e1f355ffc8f7..434dc9aaa5e4 100644
@@ -66,6 +66,7 @@
 	usb3_1_phy: usb3_1-phy {
 		compatible = "usb-nop-xceiv";
 		vcc-supply = <&usb3_1_vbus>;
+		#phy-cells = <0>;
 	};
 
 	usb3_1_vbus: usb3_1-vbus {
arch/arm/boot/dts/armada-385-synology-ds116.dts +2 -0
index 31510eb56f10..55a3c4870b8c 100644
@@ -191,11 +191,13 @@
 	usb3_0_phy: usb3_0_phy {
 		compatible = "usb-nop-xceiv";
 		vcc-supply = <&reg_usb3_0_vbus>;
+		#phy-cells = <0>;
 	};
 
 	usb3_1_phy: usb3_1_phy {
 		compatible = "usb-nop-xceiv";
 		vcc-supply = <&reg_usb3_1_vbus>;
+		#phy-cells = <0>;
 	};
 
 	reg_usb3_0_vbus: usb3-vbus0 {
arch/arm/boot/dts/armada-388-gp.dts +2 -0
index f503955dbd3b..51b4ee6df130 100644
@@ -276,11 +276,13 @@
 	usb2_1_phy: usb2_1_phy {
 		compatible = "usb-nop-xceiv";
 		vcc-supply = <&reg_usb2_1_vbus>;
+		#phy-cells = <0>;
 	};
 
 	usb3_phy: usb3_phy {
 		compatible = "usb-nop-xceiv";
 		vcc-supply = <&reg_usb3_vbus>;
+		#phy-cells = <0>;
 	};
 
 	reg_usb3_vbus: usb3-vbus {
Signature · 1 line
2.14.1
author maintainer
#4 lore raw

PATCH 3/6 arm: dts: marvell: Add missing #phy-cells to usb-nop-xceiv

Quoted 8 lines · Rob Herring

"usb-nop-xceiv" is using the phy binding, but is missing #phy-cells property. This is probably because the binding was the precursor to the phy binding.

Fixes the following warning in Marvell dts files:

Warning (phys_property): Missing property '#phy-cells' in node ...

Quoted 7 lines
Signed-off-by Rob Herring <[email protected]>
Cc Jason Cooper <[email protected]>
Cc Andrew Lunn <[email protected]>
Cc Gregory Clement <[email protected]>
Cc Sebastian Hesselbarth <[email protected]>

---
Please apply to Marvell tree.

Ping.

Arnd, can you apply if you'd like the warnings fixed and Marvell maintainers don't respond.

Quoted 6 lines
 arch/arm/boot/dts/armada-385-db-ap.dts          | 1 +
 arch/arm/boot/dts/armada-385-linksys.dtsi       | 1 +
 arch/arm/boot/dts/armada-385-synology-ds116.dts | 2 ++
 arch/arm/boot/dts/armada-388-gp.dts             | 2 ++
 4 files changed, 6 insertions(+)
#5 lore raw

PATCH 3/6 arm: dts: marvell: Add missing #phy-cells to usb-nop-xceiv

Quoted 17 lines · Rob Herring
Quoted 8 lines · Rob Herring

"usb-nop-xceiv" is using the phy binding, but is missing #phy-cells property. This is probably because the binding was the precursor to the phy binding.

Fixes the following warning in Marvell dts files:

Warning (phys_property): Missing property '#phy-cells' in node ...

Quoted 7 lines
Signed-off-by Rob Herring <[email protected]>
Cc Jason Cooper <[email protected]>
Cc Andrew Lunn <[email protected]>
Cc Gregory Clement <[email protected]>
Cc Sebastian Hesselbarth <[email protected]>

---
Please apply to Marvell tree.

Quoted 4 lines

Ping.

Arnd, can you apply if you'd like the warnings fixed and Marvell maintainers don't respond.

Hi Rob

Patches submitted a week before the merge window opens are generally deferred to the next cycle. I expect that once -rc1 is out, Gregory will pick up this patch.

Andrew

#6 lore raw

PATCH 3/6 arm: dts: marvell: Add missing #phy-cells to usb-nop-xceiv

Quoted 20 lines · Andrew Lunn
Quoted 19 lines · Rob Herring
Quoted 8 lines · Rob Herring

"usb-nop-xceiv" is using the phy binding, but is missing #phy-cells property. This is probably because the binding was the precursor to the phy binding.

Fixes the following warning in Marvell dts files:

Warning (phys_property): Missing property '#phy-cells' in node ...

Quoted 7 lines
Signed-off-by Rob Herring <[email protected]>
Cc Jason Cooper <[email protected]>
Cc Andrew Lunn <[email protected]>
Cc Gregory Clement <[email protected]>
Cc Sebastian Hesselbarth <[email protected]>

---
Please apply to Marvell tree.

Ping.

Quoted 8 lines
Quoted 2 lines

Arnd, can you apply if you'd like the warnings fixed and Marvell maintainers don't respond.

Hi Rob

Patches submitted a week before the merge window opens are generally deferred to the next cycle. I expect that once -rc1 is out, Gregory will pick up this patch.

These are real bugfixes, I want them in 4.15, since we now get a loud warning for them. I'd rather not shut up that warning because it's not a false-positive.

Arnd

#7 lore raw

PATCH 3/6 arm: dts: marvell: Add missing #phy-cells to usb-nop-xceiv

Hi Arnd,

Quoted 26 lines · Arnd Bergmann
Quoted 25 lines · Andrew Lunn
Quoted 17 lines · Rob Herring
Quoted 8 lines · Rob Herring

"usb-nop-xceiv" is using the phy binding, but is missing #phy-cells property. This is probably because the binding was the precursor to the phy binding.

Fixes the following warning in Marvell dts files:

Warning (phys_property): Missing property '#phy-cells' in node ...

Quoted 7 lines
Signed-off-by Rob Herring <[email protected]>
Cc Jason Cooper <[email protected]>
Cc Andrew Lunn <[email protected]>
Cc Gregory Clement <[email protected]>
Cc Sebastian Hesselbarth <[email protected]>

---
Please apply to Marvell tree.

Quoted 4 lines

Ping.

Arnd, can you apply if you'd like the warnings fixed and Marvell maintainers don't respond.

Hi Rob

Quoted 7 lines
Quoted 3 lines

Patches submitted a week before the merge window opens are generally deferred to the next cycle. I expect that once -rc1 is out, Gregory will pick up this patch.

These are real bugfixes, I want them in 4.15, since we now get a loud warning for them. I'd rather not shut up that warning because it's not a false-positive.

As pointed by Andrew, I planned to take them once the 4.15-rc1 would be released. It was not obvious for me that it was real fixes. Actually I would have expected to have first the dts fixed in a release and then the warning enabled.

I am fine if you take this patch, especially if it is merged in 4.15-rc1.

So for this patch:

Acked-by Gregory CLEMENT <[email protected]>

Thanks,

Gregory

Quoted 2 lines

Arnd

Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
author maintainer
#8 lore raw

PATCH 3/6 arm: dts: marvell: Add missing #phy-cells to usb-nop-xceiv

Quoted 34 lines · Gregory CLEMENT

Hi Arnd,

Quoted 30 lines · Arnd Bergmann
Quoted 28 lines · Andrew Lunn
Quoted 17 lines · Rob Herring
Quoted 8 lines · Rob Herring

"usb-nop-xceiv" is using the phy binding, but is missing #phy-cells property. This is probably because the binding was the precursor to the phy binding.

Fixes the following warning in Marvell dts files:

Warning (phys_property): Missing property '#phy-cells' in node ...

Quoted 7 lines
Signed-off-by Rob Herring <[email protected]>
Cc Jason Cooper <[email protected]>
Cc Andrew Lunn <[email protected]>
Cc Gregory Clement <[email protected]>
Cc Sebastian Hesselbarth <[email protected]>

---
Please apply to Marvell tree.

Quoted 4 lines

Ping.

Arnd, can you apply if you'd like the warnings fixed and Marvell maintainers don't respond.

Hi Rob

Patches submitted a week before the merge window opens are generally deferred to the next cycle. I expect that once -rc1 is out, Gregory will pick up this patch.

Quoted 8 lines
Quoted 3 lines

These are real bugfixes, I want them in 4.15, since we now get a loud warning for them. I'd rather not shut up that warning because it's not a false-positive.

As pointed by Andrew, I planned to take them once the 4.15-rc1 would be released. It was not obvious for me that it was real fixes. Actually I would have expected to have first the dts fixed in a release and then the warning enabled.

I didn't plan to fix everyone's warnings for them. Unfortunately, the combination of linux-next being infrequent in Oct and kernelci.org failing to report dtc warnings caused all the warnings started to get noticed late, so I fixed the noisier cases. The only way anyone pays attention is when dtc is updated and warnings appear. I've emailed out warnings in advance before. I've turned off the more subjective ones by default. Neither seems to get widely noticed (now in reviews instead of saying "don't do X", I say "don't do X and building with W=2 will tell you this"). More dtc checks are coming, so I'm open to suggestions on the process.

Rob

#9 lore raw

PATCH 3/6 arm: dts: marvell: Add missing #phy-cells to usb-nop-xceiv

In reply to Rob Herring
Quoted 9 lines · Rob Herring

"usb-nop-xceiv" is using the phy binding, but is missing #phy-cells property. This is probably because the binding was the precursor to the phy binding.

Fixes the following warning in Marvell dts files:

Warning (phys_property): Missing property '#phy-cells' in node ...

Signed-off-by Rob Herring <[email protected]>
Reviewed-by Andrew Lunn <[email protected]>

Andrew

#10 lore raw

PATCH 3/6 arm: dts: marvell: Add missing #phy-cells to usb-nop-xceiv

Quoted 5 lines · Andrew Lunn
Quoted 4 lines · Rob Herring

"usb-nop-xceiv" is using the phy binding, but is missing #phy-cells property. This is probably because the binding was the precursor to the phy binding.

Quoted 7 lines
Quoted 5 lines

Fixes the following warning in Marvell dts files:

Warning (phys_property): Missing property '#phy-cells' in node ...

Signed-off-by Rob Herring <[email protected]>
Reviewed-by Andrew Lunn <[email protected]>

I didn't see this come in before -rc1 and in current fixes, so given the acks I've applied it directly now.

-Olof

author maintainer
#11 lore raw

PATCH 4/6 arm: dts: nspire: Add missing #phy-cells to usb-nop-xceiv

In reply to Rob Herring

"usb-nop-xceiv" is using the phy binding, but is missing #phy-cells property. This is probably because the binding was the precursor to the phy binding.

Fixes the following warning in nspire dts files:

Warning (phys_property): Missing property '#phy-cells' in node ...

Signed-off-by Rob Herring <[email protected]>

---
Doesn't seem to be a maintainer for nspire. Arnd, please apply.

 arch/arm/boot/dts/nspire.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/nspire.dtsi +1 -0
index ee5a0bb22354..6aadf6e622d2 100644
@@ -56,6 +56,7 @@
 
 	usb_phy: usb_phy {
 		compatible = "usb-nop-xceiv";
+		#phy-cells = <0>;
 	};
 
 	vbus_reg: vbus_reg {
Signature · 1 line
2.14.1
Applied
#12 lore raw

PATCH 4/6 arm: dts: nspire: Add missing #phy-cells to usb-nop-xceiv

Quoted 11 lines · Rob Herring

"usb-nop-xceiv" is using the phy binding, but is missing #phy-cells property. This is probably because the binding was the precursor to the phy binding.

Fixes the following warning in nspire dts files:

Warning (phys_property): Missing property '#phy-cells' in node ...

Signed-off-by Rob Herring <[email protected]>

---
Doesn't seem to be a maintainer for nspire. Arnd, please apply.

Applied to fixes, thanks!

Arnd

author maintainer
#13 lore raw

PATCH 5/6 arm: dts: omap: Add missing #phy-cells to usb-nop-xceiv

In reply to Rob Herring

"usb-nop-xceiv" is using the phy binding, but is missing #phy-cells property. This is probably because the binding was the precursor to the phy binding.

Fixes the following warning in OMAP dts files:

Warning (phys_property): Missing property '#phy-cells' in node ...

Signed-off-by Rob Herring <[email protected]>
Cc "Beno?t Cousson" <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc Enric Balletbo i Serra <[email protected]>
Cc Javier Martinez Canillas <[email protected]>
Cc linux-omap at vger.kernel.org

---
Please apply to TI tree.

 arch/arm/boot/dts/logicpd-som-lv.dtsi        | 1 +
 arch/arm/boot/dts/omap3-beagle-xm.dts        | 1 +
 arch/arm/boot/dts/omap3-beagle.dts           | 1 +
 arch/arm/boot/dts/omap3-cm-t3x.dtsi          | 2 ++
 arch/arm/boot/dts/omap3-evm-common.dtsi      | 1 +
 arch/arm/boot/dts/omap3-gta04.dtsi           | 1 +
 arch/arm/boot/dts/omap3-igep0020-common.dtsi | 1 +
 arch/arm/boot/dts/omap3-igep0030-common.dtsi | 1 +
 arch/arm/boot/dts/omap3-lilly-a83x.dtsi      | 1 +
 arch/arm/boot/dts/omap3-overo-base.dtsi      | 1 +
 arch/arm/boot/dts/omap3-pandora-common.dtsi  | 1 +
 arch/arm/boot/dts/omap3-tao3530.dtsi         | 1 +
 arch/arm/boot/dts/omap4-droid4-xt894.dts     | 1 +
 arch/arm/boot/dts/omap4-duovero.dtsi         | 1 +
 arch/arm/boot/dts/omap4-panda-common.dtsi    | 1 +
 arch/arm/boot/dts/omap4-var-som-om44.dtsi    | 1 +
 arch/arm/boot/dts/omap5-board-common.dtsi    | 2 ++
 arch/arm/boot/dts/omap5-cm-t54.dts           | 2 ++
 18 files changed, 21 insertions(+)
arch/arm/boot/dts/logicpd-som-lv.dtsi +1 -0
index 26cce4d18405..4a79ce84045c 100644
@@ -33,6 +33,7 @@
 	hsusb2_phy: hsusb2_phy {
 		compatible = "usb-nop-xceiv";
 		reset-gpios = <&gpio1 4 GPIO_ACTIVE_LOW>; /* gpio_4 */
+		#phy-cells = <0>;
 	};
 };
arch/arm/boot/dts/omap3-beagle-xm.dts +1 -0
index 683b96a8f73e..0349fcc9dc26 100644
@@ -90,6 +90,7 @@
 		compatible = "usb-nop-xceiv";
 		reset-gpios = <&gpio5 19 GPIO_ACTIVE_LOW>; /* gpio_147 */
 		vcc-supply = <&hsusb2_power>;
+		#phy-cells = <0>;
 	};
 
 	tfp410: encoder0 {
arch/arm/boot/dts/omap3-beagle.dts +1 -0
index 4d2eaf843fa9..3ca8991a6c3e 100644
@@ -64,6 +64,7 @@
 		compatible = "usb-nop-xceiv";
 		reset-gpios = <&gpio5 19 GPIO_ACTIVE_LOW>;	/* gpio_147 */
 		vcc-supply = <&hsusb2_power>;
+		#phy-cells = <0>;
 	};
 
 	sound {
arch/arm/boot/dts/omap3-cm-t3x.dtsi +2 -0
index fccd5383243c..08533fcdbbe8 100644
@@ -42,12 +42,14 @@
 	hsusb1_phy: hsusb1_phy {
 		compatible = "usb-nop-xceiv";
 		vcc-supply = <&hsusb1_power>;
+		#phy-cells = <0>;
 	};
 
 	/* HS USB Host PHY on PORT 2 */
 	hsusb2_phy: hsusb2_phy {
 		compatible = "usb-nop-xceiv";
 		vcc-supply = <&hsusb2_power>;
+		#phy-cells = <0>;
 	};
 
 	ads7846reg: ads7846-reg {
arch/arm/boot/dts/omap3-evm-common.dtsi +1 -0
index ff35803088e3..26badcc64d77 100644
@@ -28,6 +28,7 @@
 		compatible = "usb-nop-xceiv";
 		reset-gpios = <&gpio1 21 GPIO_ACTIVE_LOW>; /* gpio_21 */
 		vcc-supply = <&hsusb2_power>;
+		#phy-cells = <0>;
 	};
 
 	leds {
arch/arm/boot/dts/omap3-gta04.dtsi +1 -0
index 4504908c23fe..3dc56fb156b7 100644
@@ -120,6 +120,7 @@
 	hsusb2_phy: hsusb2_phy {
 		compatible = "usb-nop-xceiv";
 		reset-gpios = <&gpio6 14 GPIO_ACTIVE_LOW>;
+		#phy-cells = <0>;
 	};
 
 	tv0: connector {
arch/arm/boot/dts/omap3-igep0020-common.dtsi +1 -0
index 667f96245729..ecbec23af49f 100644
@@ -58,6 +58,7 @@
 		compatible = "usb-nop-xceiv";
 		reset-gpios = <&gpio1 24 GPIO_ACTIVE_LOW>; /* gpio_24 */
 		vcc-supply = <&hsusb1_power>;
+		#phy-cells = <0>;
 	};
 
 	tfp410: encoder {
arch/arm/boot/dts/omap3-igep0030-common.dtsi +1 -0
index e94d9427450c..443f71707437 100644
@@ -37,6 +37,7 @@
 	hsusb2_phy: hsusb2_phy {
 		compatible = "usb-nop-xceiv";
 		reset-gpios = <&gpio2 22 GPIO_ACTIVE_LOW>;		/* gpio_54 */
+		#phy-cells = <0>;
 	};
 };
arch/arm/boot/dts/omap3-lilly-a83x.dtsi +1 -0
index fa611a5e4850..a87c0b630435 100644
@@ -51,6 +51,7 @@
 	hsusb1_phy: hsusb1_phy {
 		compatible = "usb-nop-xceiv";
 		vcc-supply = <&reg_vcc3>;
+		#phy-cells = <0>;
 	};
 };
arch/arm/boot/dts/omap3-overo-base.dtsi +1 -0
index f25e158e7163..ac141fcd1742 100644
@@ -51,6 +51,7 @@
 		compatible = "usb-nop-xceiv";
 		reset-gpios = <&gpio6 23 GPIO_ACTIVE_LOW>;	/* gpio_183 */
 		vcc-supply = <&hsusb2_power>;
+		#phy-cells = <0>;
 	};
 
 	/* Regulator to trigger the nPoweron signal of the Wifi module */
arch/arm/boot/dts/omap3-pandora-common.dtsi +1 -0
index 53e007abdc71..cd53dc6c0051 100644
@@ -205,6 +205,7 @@
 		compatible = "usb-nop-xceiv";
 		reset-gpios = <&gpio1 16 GPIO_ACTIVE_LOW>; /* GPIO_16 */
 		vcc-supply = <&vaux2>;
+		#phy-cells = <0>;
 	};
 
 	/* HS USB Host VBUS supply
arch/arm/boot/dts/omap3-tao3530.dtsi +1 -0
index 9a601d15247b..6f5bd027b717 100644
@@ -46,6 +46,7 @@
 		compatible = "usb-nop-xceiv";
 		reset-gpios = <&gpio6 2 GPIO_ACTIVE_LOW>;	/* gpio_162 */
 		vcc-supply = <&hsusb2_power>;
+		#phy-cells = <0>;
 	};
 
 	sound {
arch/arm/boot/dts/omap4-droid4-xt894.dts +1 -0
index 8b93d37310f2..24a463f8641f 100644
@@ -73,6 +73,7 @@
 	/* HS USB Host PHY on PORT 1 */
 	hsusb1_phy: hsusb1_phy {
 		compatible = "usb-nop-xceiv";
+		#phy-cells = <0>;
 	};
 
 	/* LCD regulator from sw5 source */
arch/arm/boot/dts/omap4-duovero.dtsi +1 -0
index 6e6810c258eb..eb123b24c8e3 100644
@@ -43,6 +43,7 @@
 	hsusb1_phy: hsusb1_phy {
 		compatible = "usb-nop-xceiv";
 		reset-gpios = <&gpio2 30 GPIO_ACTIVE_LOW>;	/* gpio_62 */
+		#phy-cells = <0>;
 
 		pinctrl-names = "default";
 		pinctrl-0 = <&hsusb1phy_pins>;
arch/arm/boot/dts/omap4-panda-common.dtsi +1 -0
index 2b48e51c372a..83b31682e5f1 100644
@@ -85,6 +85,7 @@
 	hsusb1_phy: hsusb1_phy {
 		compatible = "usb-nop-xceiv";
 		reset-gpios = <&gpio2 30 GPIO_ACTIVE_LOW>;   /* gpio_62 */
+		#phy-cells = <0>;
 		vcc-supply = <&hsusb1_power>;
 		clocks = <&auxclk3_ck>;
 		clock-names = "main_clk";
arch/arm/boot/dts/omap4-var-som-om44.dtsi +1 -0
index 6500bfc8d130..10fce28ceb5b 100644
@@ -44,6 +44,7 @@
 
 		reset-gpios = <&gpio6 17 GPIO_ACTIVE_LOW>; /* gpio 177 */
 		vcc-supply = <&vbat>;
+		#phy-cells = <0>;
 
 		clocks = <&auxclk3_ck>;
 		clock-names = "main_clk";
arch/arm/boot/dts/omap5-board-common.dtsi +2 -0
index 7824b2631cb6..d9ca403d8b24 100644
@@ -69,12 +69,14 @@
 		clocks = <&auxclk1_ck>;
 		clock-names = "main_clk";
 		clock-frequency = <19200000>;
+		#phy-cells = <0>;
 	};
 
 	/* HS USB Host PHY on PORT 3 */
 	hsusb3_phy: hsusb3_phy {
 		compatible = "usb-nop-xceiv";
 		reset-gpios = <&gpio3 15 GPIO_ACTIVE_LOW>; /* gpio3_79 ETH_NRESET */
+		#phy-cells = <0>;
 	};
 
 	tpd12s015: encoder {
arch/arm/boot/dts/omap5-cm-t54.dts +2 -0
index 552a5c4c5942..73fcdda57dc2 100644
@@ -62,12 +62,14 @@
 	hsusb2_phy: hsusb2_phy {
 		compatible = "usb-nop-xceiv";
 		reset-gpios = <&gpio3 12 GPIO_ACTIVE_LOW>; /* gpio3_76 HUB_RESET */
+		#phy-cells = <0>;
 	};
 
 	/* HS USB Host PHY on PORT 3 */
 	hsusb3_phy: hsusb3_phy {
 		compatible = "usb-nop-xceiv";
 		reset-gpios = <&gpio3 19 GPIO_ACTIVE_LOW>; /* gpio3_83 ETH_RESET */
+		#phy-cells = <0>;
 	};
 
 	leds {
Signature · 1 line
2.14.1
#14 lore raw

PATCH 5/6 arm: dts: omap: Add missing #phy-cells to usb-nop-xceiv

Quoted 8 lines · Rob Herring

"usb-nop-xceiv" is using the phy binding, but is missing #phy-cells property. This is probably because the binding was the precursor to the phy binding.

Fixes the following warning in OMAP dts files:

Warning (phys_property): Missing property '#phy-cells' in node ...

Quoted 8 lines
Signed-off-by Rob Herring <[email protected]>
Cc "Beno?t Cousson" <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc Enric Balletbo i Serra <[email protected]>
Cc Javier Martinez Canillas <[email protected]>
Cc linux-omap at vger.kernel.org

---
Please apply to TI tree.

Thanks applying into omap-for-v4.15/fixes-dt.

Regards,

Tony

author maintainer
#15 lore raw

PATCH 6/6 arm: dts: am33xx: Add missing #phy-cells to ti, am335x-usb-phy

In reply to Rob Herring

"ti,am335x-usb-phy" is using the phy binding, but is missing #phy-cells property. Fixes the following warning in TI dts files:

Warning (phys_property): Missing property '#phy-cells' in node ...

Signed-off-by Rob Herring <[email protected]>
Cc "Beno?t Cousson" <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc linux-omap at vger.kernel.org

---
Please apply to TI tree.

 Documentation/devicetree/bindings/usb/am33xx-usb.txt | 2 ++
 arch/arm/boot/dts/am33xx.dtsi                        | 2 ++
 arch/arm/boot/dts/dm814x.dtsi                        | 1 +
 3 files changed, 5 insertions(+)
Documentation/devicetree/bindings/usb/am33xx-usb.txt +2 -0
index 7a33f22c815a..7a198a30408a 100644
@@ -95,6 +95,7 @@ usb: usb at 47400000 {
 		reg = <0x47401300 0x100>;
 		reg-names = "phy";
 		ti,ctrl_mod = <&ctrl_mod>;
+		#phy-cells = <0>;
 	};
 
 	usb0: usb at 47401000 {

@@ -141,6 +142,7 @@ usb: usb at 47400000 {
 		reg = <0x47401b00 0x100>;
 		reg-names = "phy";
 		ti,ctrl_mod = <&ctrl_mod>;
+		#phy-cells = <0>;
 	};
 
 	usb1: usb at 47401800 {
arch/arm/boot/dts/am33xx.dtsi +2 -0
index 7d7ca054c557..a39465a67ca2 100644
@@ -626,6 +626,7 @@
 				reg-names = "phy";
 				status = "disabled";
 				ti,ctrl_mod = <&usb_ctrl_mod>;
+				#phy-cells = <0>;
 			};
 
 			usb0: usb at 47401000 {

@@ -674,6 +675,7 @@
 				reg-names = "phy";
 				status = "disabled";
 				ti,ctrl_mod = <&usb_ctrl_mod>;
+				#phy-cells = <0>;
 			};
 
 			usb1: usb at 47401800 {
arch/arm/boot/dts/dm814x.dtsi +1 -0
index 9708157f5daf..b7a11c1168d1 100644
@@ -75,6 +75,7 @@
 				reg = <0x47401300 0x100>;
 				reg-names = "phy";
 				ti,ctrl_mod = <&usb_ctrl_mod>;
+				#phy-cells = <0>;
 			};
 
 			usb0: usb at 47401000 {
Signature · 1 line
2.14.1
#16 lore raw

PATCH 6/6 arm: dts: am33xx: Add missing #phy-cells to ti,am335x-usb-phy

Quoted 11 lines · Rob Herring

"ti,am335x-usb-phy" is using the phy binding, but is missing #phy-cells property. Fixes the following warning in TI dts files:

Warning (phys_property): Missing property '#phy-cells' in node ...

Signed-off-by Rob Herring <[email protected]>
Cc "Beno?t Cousson" <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc linux-omap at vger.kernel.org

---
Please apply to TI tree.

Applying this too into omap-for-v4.15/fixes-dt thanks.

Tony