sched/deadline: fix one-bit signed bitfields to be unsigned
PATCH 1/1 sched/deadline: fix one-bit signed bitfields to be unsigned
Commit 799ba82de01e ("sched/deadline: Use C bitfields for the state flags", 2017-10-10) introduced the use of C bitfields for these variables. However, sparse complains about them:
./include/linux/sched.h:476:62: error: dubious one-bit signed bitfield ./include/linux/sched.h:477:62: error: dubious one-bit signed bitfield ./include/linux/sched.h:478:62: error: dubious one-bit signed bitfield ./include/linux/sched.h:479:62: error: dubious one-bit signed bitfield
This is because a one-bit signed bitfield can only hold the values 0 and -1, which can cause problems if the program expects to be able to represent the value positive 1.
In practice, this may not cause a bug since -1 would be considered "true" in logical tests, however we should avoid the practice anyways.
--- include/linux/sched.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
include/linux/sched.h +4 -4
@@ -473,10 +473,10 @@ struct sched_dl_entity {* conditions between the inactive timer handler and the wakeup * code. */ - int dl_throttled : 1; - int dl_boosted : 1; - int dl_yielded : 1; - int dl_non_contending : 1; + unsigned int dl_throttled : 1; + unsigned int dl_boosted : 1; + unsigned int dl_yielded : 1; + unsigned int dl_non_contending : 1;/* * Bandwidth enforcement timer. Each -deadline task has its
Signature · 1 line
2.15.0
Bowers
PATCH 1/1 sched/deadline: fix one-bit signed bitfields to be unsigned
Quoted 27 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Jacob Keller
Sent: Tuesday, November 21, 2017 2:31 PM
To: Intel Wired LAN <[email protected]>
Cc: Peter Zijlstra <[email protected]>; luca abeni <[email protected]>; Ingo Molnar <[email protected]>
Subject: [Intel-wired-lan] [PATCH net] sched/deadline: fix one-bit signed bitfields to be unsignedCommit
799ba82de01e("sched/deadline: Use C bitfields for the state flags", 2017-10-10) introduced the use of C bitfields for these variables. However, sparse complains about them:
./include/linux/sched.h:476:62: error: dubious one-bit signed bitfield./include/linux/sched.h:477:62: error: dubious one-bit signed bitfield./include/linux/sched.h:478:62: error: dubious one-bit signed bitfield./include/linux/sched.h:479:62: error: dubious one-bit signed bitfieldThis is because a one-bit signed bitfield can only hold the values 0 and -1, which can cause problems if the program expects to be able to represent the value positive 1.
In practice, this may not cause a bug since -1 would be considered "true" in logical tests, however we should avoid the practice anyways.
Fixes 799ba82de01e ("sched/deadline: Use C bitfields for the state flags",
Quoted 8 lines
2017-10-10)
Signed-off-by Jacob Keller <[email protected]>Cc Ingo Molnar <[email protected]>Cc Peter Zijlstra <[email protected]>Cc luca abeni <[email protected]>--- include/linux/sched.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)