move libgcc.h to include/linux
PATCH 1/1 move libgcc.h to include/linux
Introducing a new include/lib directory just for this file totally messes up tab completion for include/linux, which is highly annoying.
Move it to include/linux where we have headers for all kinds of other lib/ code as well.
---
include/{lib => linux}/libgcc.h | 0
lib/ashldi3.c | 2 +-
lib/ashrdi3.c | 2 +-
lib/cmpdi2.c | 2 +-
lib/lshrdi3.c | 2 +-
lib/muldi3.c | 2 +-
lib/ucmpdi2.c | 2 +-
7 files changed, 6 insertions(+), 6 deletions(-)
rename include/{lib => linux}/libgcc.h (100%)include/linux/libgcc.h renamed from include/lib/libgcc.h +0 -0
lib/ashldi3.c +1 -1
@@ -16,7 +16,7 @@#include <linux/export.h> -#include <lib/libgcc.h> +#include <linux/libgcc.h> long long notrace __ashldi3 (long long u,word_type b) {
lib/ashrdi3.c +1 -1
@@ -16,7 +16,7 @@#include <linux/export.h> -#include <lib/libgcc.h> +#include <linux/libgcc.h> long long notrace __ashrdi3 (long long u,word_type b) {
lib/cmpdi2.c +1 -1
@@ -16,7 +16,7 @@#include <linux/export.h> -#include <lib/libgcc.h> +#include <linux/libgcc.h> word_type notrace __cmpdi2(long long a, long long b) {
lib/lshrdi3.c +1 -1
@@ -17,7 +17,7 @@*/ #include <linux/module.h> -#include <lib/libgcc.h> +#include <linux/libgcc.h> long long notrace __lshrdi3 (long long u,word_type b) {
lib/muldi3.c +1 -1
@@ -15,7 +15,7 @@*/ #include <linux/export.h> -#include <lib/libgcc.h> +#include <linux/libgcc.h> #define W_TYPE_SIZE 32
lib/ucmpdi2.c +1 -1
@@ -15,7 +15,7 @@*/ #include <linux/module.h> -#include <lib/libgcc.h> +#include <linux/libgcc.h> word_type __ucmpdi2 (unsigned long long a,unsigned long long b) {
Signature · 1 line
2.14.2
Quoted 2 lines · On Wed, 22 Nov 2017 02:47:28 PST (-0800), [email protected] wrote:
Introducing a new
include/libdirectory just for this file totally messes up tab completion forinclude/linux, which is highly annoying.
Sorry about that.
Quoted 2 lines
Move it to
include/linuxwhere we have headers for all kinds of otherlib/code as well.
That looks good to me. I'm kind of new to this, do you want me to take this into my tree?
Quoted 95 lines
Signed-off-by Christoph Hellwig <[email protected]>--- include/{lib => linux}/libgcc.h | 0 lib/ashldi3.c | 2 +- lib/ashrdi3.c | 2 +- lib/cmpdi2.c | 2 +- lib/lshrdi3.c | 2 +- lib/muldi3.c | 2 +- lib/ucmpdi2.c | 2 +- 7 files changed, 6 insertions(+), 6 deletions(-) rename include/{lib => linux}/libgcc.h (100%)include/linux/libgcc.h renamed from include/lib/libgcc.h +0
-0lib/ashldi3.c +1
-1@@ -16,7 +16,7 @@#include <linux/export.h> -#include <lib/libgcc.h> +#include <linux/libgcc.h> long long notrace __ashldi3 (long long u,word_type b) {lib/ashrdi3.c +1
-1@@ -16,7 +16,7 @@#include <linux/export.h> -#include <lib/libgcc.h> +#include <linux/libgcc.h> long long notrace __ashrdi3 (long long u,word_type b) {lib/cmpdi2.c +1
-1@@ -16,7 +16,7 @@#include <linux/export.h> -#include <lib/libgcc.h> +#include <linux/libgcc.h> word_type notrace __cmpdi2(long long a, long long b) {lib/lshrdi3.c +1
-1@@ -17,7 +17,7 @@*/ #include <linux/module.h> -#include <lib/libgcc.h> +#include <linux/libgcc.h> long long notrace __lshrdi3 (long long u,word_type b) {lib/muldi3.c +1
-1@@ -15,7 +15,7 @@*/ #include <linux/export.h> -#include <lib/libgcc.h> +#include <linux/libgcc.h> #define W_TYPE_SIZE 32lib/ucmpdi2.c +1
-1@@ -15,7 +15,7 @@*/ #include <linux/module.h> -#include <lib/libgcc.h> +#include <linux/libgcc.h> word_type __ucmpdi2 (unsigned long long a,unsigned long long b) {
Quoted 6 lines · Palmer Dabbelt
Quoted 2 lines · On Wed, 22 Nov 2017 02:47:28 PST (-0800), [email protected] wrote:
Introducing a new
include/libdirectory just for this file totally messes up tab completion forinclude/linux, which is highly annoying.Sorry about that.
Quoted 7 lines
Quoted 2 lines
Move it to
include/linuxwhere we have headers for all kinds of otherlib/code as well.That looks good to me. I'm kind of new to this, do you want me to take this into my tree?
Reviewed-by Palmer Dabbelt <[email protected]>
I sent it to Linus as I'd expect him to just apply it directly. He hasn't picked it up yesterday, so maybe you should just send it along with your next RISC-V updates.
Quoted 10 lines · On Thu, 23 Nov 2017 00:03:18 PST (-0800), [email protected] wrote:
Quoted 9 lines · Palmer Dabbelt
Quoted 2 lines · On Wed, 22 Nov 2017 02:47:28 PST (-0800), [email protected] wrote:
Introducing a new
include/libdirectory just for this file totally messes up tab completion forinclude/linux, which is highly annoying.Sorry about that.
Quoted 2 lines
Move it to
include/linuxwhere we have headers for all kinds of otherlib/code as well.
Quoted 8 lines
Quoted 4 lines
That looks good to me. I'm kind of new to this, do you want me to take this into my tree?
Reviewed-by Palmer Dabbelt <[email protected]>I sent it to Linus as I'd expect him to just apply it directly. He hasn't picked it up yesterday, so maybe you should just send it along with your next RISC-V updates.
Doesn't look like it made 4.15-rc1, so I'll include it with my next pull request.
Thanks!