Skip to contentSkip to conversation

drm/i915/pmu: Turn on perf events in debug mode

PATCH In review Tvrtko Ursulin 4 participants 6 messages Nov 22, 2017

Subsystems (2)
DRM drivers Intel i915
lore
Share & tools
lore

Tvrtko Ursulin

author maintainer
#0 lore raw

PATCH 1/1 drm/i915/pmu: Turn on perf events in debug mode

From: Tvrtko Ursulin <[email protected]>

We have a policy to select all optional kernel features which are needed for CI if DRM_I915_DEBUG is turned on. So add PERF_EVENTS as well.

Signed-off-by Tvrtko Ursulin <[email protected]>
Suggested-by Chris Wilson <[email protected]>
---
 drivers/gpu/drm/i915/Kconfig.debug | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/Kconfig.debug +1 -0
index 9e53edbc713b..1a75cc94e759 100644
@@ -29,6 +29,7 @@ config DRM_I915_DEBUG
 	select DRM_I915_SW_FENCE_DEBUG_OBJECTS
 	select DRM_I915_SELFTEST
 	select DRM_I915_TRACE_GEM
+	select PERF_EVENTS
         default n
         help
           Choose this option to turn on extra driver debugging that may affect
Signature · 6 lines
2.14.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

Quoting Tvrtko Ursulin (2017-11-22 16:59:01)

Quoted 16 lines

From: Tvrtko Ursulin <[email protected]>

We have a policy to select all optional kernel features which are needed for CI if DRM_I915_DEBUG is turned on. So add PERF_EVENTS as well.

Signed-off-by Tvrtko Ursulin <[email protected]>
Suggested-by Chris Wilson <[email protected]>
---
 drivers/gpu/drm/i915/Kconfig.debug | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/Kconfig.debug +0 -0
index 9e53edbc713b..1a75cc94e759 100644

drivers/gpu/drm/i915/Kconfig.debug config DRM_I915_DEBUG · line 32

Quoted 4 lines
drivers/gpu/drm/i915/Kconfig.debug +1 -0
@@ -29,6 +29,7 @@ config DRM_I915_DEBUG
        select DRM_I915_SW_FENCE_DEBUG_OBJECTS
        select DRM_I915_SELFTEST
        select DRM_I915_TRACE_GEM
+       select PERF_EVENTS

If I am reading arch/x86/Kconfig correctly, then PERF_EVENTS is always selected for X86.

config X86

	def_bool y
	...
	select HAVE_PERF_EVENTS
	...
	select PERF_EVENTS
	...

Is it worth documenting our need for the syscall to run igt/perf_pmu anyway?
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw
Quoted 33 lines · Chris Wilson

Quoting Tvrtko Ursulin (2017-11-22 16:59:01)

Quoted 16 lines

From: Tvrtko Ursulin <[email protected]>

We have a policy to select all optional kernel features which are needed for CI if DRM_I915_DEBUG is turned on. So add PERF_EVENTS as well.

Signed-off-by Tvrtko Ursulin <[email protected]>
Suggested-by Chris Wilson <[email protected]>
---
  drivers/gpu/drm/i915/Kconfig.debug | 1 +
  1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/Kconfig.debug +0 -0
index 9e53edbc713b..1a75cc94e759 100644

drivers/gpu/drm/i915/Kconfig.debug config DRM_I915_DEBUG · line 32

Quoted 4 lines
drivers/gpu/drm/i915/Kconfig.debug +1 -0
@@ -29,6 +29,7 @@ config DRM_I915_DEBUG
         select DRM_I915_SW_FENCE_DEBUG_OBJECTS
         select DRM_I915_SELFTEST
         select DRM_I915_TRACE_GEM
+       select PERF_EVENTS

If I am reading arch/x86/Kconfig correctly, then PERF_EVENTS is always selected for X86.

config X86

	def_bool y
	...
	select HAVE_PERF_EVENTS
	...
	select PERF_EVENTS
	...
Quoted 2 lines

Is it worth documenting our need for the syscall to run igt/perf_pmu anyway?

Probably not. I did not think to check this, and actually, don't think I would have expected it. So thanks for checking!

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
In reply to Tvrtko Ursulin

Quoting Tvrtko Ursulin (2017-11-22 16:59:01)

Quoted 16 lines

From: Tvrtko Ursulin <[email protected]>

We have a policy to select all optional kernel features which are needed for CI if DRM_I915_DEBUG is turned on. So add PERF_EVENTS as well.

Signed-off-by Tvrtko Ursulin <[email protected]>
Suggested-by Chris Wilson <[email protected]>
---
 drivers/gpu/drm/i915/Kconfig.debug | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/Kconfig.debug +0 -0
index 9e53edbc713b..1a75cc94e759 100644

drivers/gpu/drm/i915/Kconfig.debug config DRM_I915_DEBUG · line 32

Quoted 4 lines
drivers/gpu/drm/i915/Kconfig.debug +1 -0
@@ -29,6 +29,7 @@ config DRM_I915_DEBUG
        select DRM_I915_SW_FENCE_DEBUG_OBJECTS
        select DRM_I915_SELFTEST
        select DRM_I915_TRACE_GEM
+       select PERF_EVENTS

Fwiw, I would tag this with # for igt/perf_pmu
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

CI
#4 lore raw

✓ Fi.CI.BAT: success for drm/i915/pmu: Turn on perf events in debug mode

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: drm/i915/pmu: Turn on perf events in debug mode
URL : https://patchwork.freedesktop.org/series/34242/
State : success

== Summary ==

Series 34242v1 drm/i915/pmu: Turn on perf events in debug mode
https://patchwork.freedesktop.org/api/1.0/series/34242/revisions/1/mbox/

Test gem_ringfill:

        Subgroup basic-default-hang:
                dmesg-warn -> PASS       (fi-blb-e6850) fdo#101600
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-b:
                pass       -> INCOMPLETE (fi-snb-2520m) fdo#103713

fdo#101600 https://bugs.freedesktop.org/show_bug.cgi?id=101600
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713

fi-bdw-5557u     total:289  pass:268  dwarn:0   dfail:0   fail:0   skip:21  time:447s
fi-bdw-gvtdvm    total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:462s
fi-blb-e6850     total:289  pass:224  dwarn:0   dfail:0   fail:0   skip:65  time:374s
fi-bsw-n3050     total:289  pass:243  dwarn:0   dfail:0   fail:0   skip:46  time:543s
fi-bwr-2160      total:289  pass:183  dwarn:0   dfail:0   fail:0   skip:106 time:280s
fi-bxt-dsi       total:289  pass:259  dwarn:0   dfail:0   fail:0   skip:30  time:508s
fi-bxt-j4205     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:508s
fi-byt-j1900     total:289  pass:254  dwarn:0   dfail:0   fail:0   skip:35  time:503s
fi-byt-n2820     total:289  pass:250  dwarn:0   dfail:0   fail:0   skip:39  time:487s
fi-cfl-s2        total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:605s
fi-elk-e7500     total:289  pass:229  dwarn:0   dfail:0   fail:0   skip:60  time:429s
fi-gdg-551       total:289  pass:178  dwarn:1   dfail:0   fail:1   skip:109 time:265s
fi-glk-1         total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:543s
fi-hsw-4770      total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:431s
fi-hsw-4770r     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:439s
fi-ilk-650       total:289  pass:228  dwarn:0   dfail:0   fail:0   skip:61  time:427s
fi-ivb-3520m     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:480s
fi-ivb-3770      total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:462s
fi-kbl-7500u     total:289  pass:264  dwarn:1   dfail:0   fail:0   skip:24  time:481s
fi-kbl-7560u     total:289  pass:270  dwarn:0   dfail:0   fail:0   skip:19  time:526s
fi-kbl-7567u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:475s
fi-kbl-r         total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:537s
fi-pnv-d510      total:289  pass:222  dwarn:1   dfail:0   fail:0   skip:66  time:575s
fi-skl-6260u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:459s
fi-skl-6600u     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:547s
fi-skl-6700hq    total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:570s
fi-skl-6700k     total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:521s
fi-skl-6770hq    total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:504s
fi-skl-gvtdvm    total:289  pass:266  dwarn:0   dfail:0   fail:0   skip:23  time:461s
fi-snb-2520m     total:246  pass:212  dwarn:0   dfail:0   fail:0   skip:33 
fi-snb-2600      total:289  pass:249  dwarn:0   dfail:0   fail:0   skip:40  time:428s

Blacklisted hosts:
fi-glk-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:496s

368de251cb3d8b5a69ea4e2731a2b53d329c8485 drm-tip: 2017y-11m-22d-11h-27m-26s UTC integration manifest fa508f018055 drm/i915/pmu: Turn on perf events in debug mode

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7236/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

CI
#5 lore raw

✓ Fi.CI.IGT: success for drm/i915/pmu: Turn on perf events in debug mode

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: drm/i915/pmu: Turn on perf events in debug mode
URL : https://patchwork.freedesktop.org/series/34242/
State : success

== Summary ==

Test drv_selftest:

        Subgroup mock_sanitycheck:
                pass       -> DMESG-WARN (shard-hsw) fdo#103719
Test kms_flip:
        Subgroup plain-flip-fb-recreate:
                pass       -> FAIL       (shard-hsw) fdo#100368 +1
Test drv_module_reload:
        Subgroup basic-reload:
                pass       -> DMESG-WARN (shard-snb) fdo#102848
Test kms_setmode:
        Subgroup basic:
                pass       -> FAIL       (shard-hsw) fdo#99912

fdo#103719 https://bugs.freedesktop.org/show_bug.cgi?id=103719
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102848 https://bugs.freedesktop.org/show_bug.cgi?id=102848
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912

shard-hsw        total:2667 pass:1519 dwarn:8   dfail:2   fail:16  skip:1122 time:9242s
shard-snb        total:2632 pass:1279 dwarn:9   dfail:0   fail:16  skip:1327 time:7549s

Blacklisted hosts:
shard-apl total:2612 pass:1636 dwarn:10 dfail:0 fail:22 skip:942 time:11767s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7236/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx