Skip to contentSkip to conversation

pdbg updates

PATCH New Joel Stanley 2 participants 4 messages Nov 22, 2017

lore
Share & tools
lore

Joel Stanley

author
#0 lore raw

cover pdbg updates

A bump to fix build issues. Thanks for writing the fix Thomas! This should go into master as well as next.

The help text update could go in too, but it is not urgent.

Build tested on ARM and mips64el.

Joel Stanley (2):
pdbg: update help text
pdbg: Bump to latest upstream version

 ...bg-Remove-unused-__unused-from-compiler.h.patch | 39 ----------------------
 package/pdbg/Config.in                             |  4 +--
 package/pdbg/pdbg.hash                             |  2 +-
 package/pdbg/pdbg.mk                               |  2 +-
 4 files changed, 4 insertions(+), 43 deletions(-)
 delete mode 100644 package/pdbg/0001-libpdbg-Remove-unused-__unused-from-compiler.h.patch
Signature · 1 line
2.14.1
author
#1 lore raw

PATCH 1/2 pdbg: update help text

Update the help text to reflect features added in recent versions.

Signed-off-by Joel Stanley <[email protected]>
---
 package/pdbg/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/pdbg/Config.in +2 -2
index 3e23c210c920..4a902694f50c 100644
@@ -2,9 +2,9 @@ config BR2_PACKAGE_PDBG
 	bool "pdbg"
 	help
 	  PowerPC FSI Debugger, for low level debugging of a IBM
-	  Power8 CPU over FSI.
+	  Power8 and Power9 CPU over FSI.
 
 	  pdbg runs on a BMC, which is generally an ARM-powered system
-	  monitoring/controlling a host CPU.
+	  monitoring/controlling a host CPU. It can also run on the host.
 
 	  https://github.com/open-power/pdbg
Signature · 1 line
2.14.1
author
#2 lore raw

PATCH 2/2 pdbg: Bump to latest upstream version

In reply to Joel Stanley

This incorporates a fix supplied by Thomas to resolve build issues on mips and blackfin.

The patch is dropped as it has been applied upstream.

Signed-off-by Joel Stanley <[email protected]>
---
 ...bg-Remove-unused-__unused-from-compiler.h.patch | 39 ----------------------
 package/pdbg/pdbg.hash                             |  2 +-
 package/pdbg/pdbg.mk                               |  2 +-
 3 files changed, 2 insertions(+), 41 deletions(-)
 delete mode 100644 package/pdbg/0001-libpdbg-Remove-unused-__unused-from-compiler.h.patch
package/pdbg/0001-libpdbg-Remove-unused-__unused-from-compiler.h.patch deleted +0 -39
deleted file mode 100644
index e778f283d76e..000000000000
@@ -1,39 +0,0 @@
-From 5a85b8c78846b342bdeba37caed03b64b1dd2864 Mon Sep 17 00:00:00 2001
-From: Joel Stanley <[email protected]>
-Date: Tue, 3 Oct 2017 21:37:46 +1030
-Subject: [PATCH] libpdbg: Remove unused __unused from compiler.h
-MIME-Version: 1.0
-Content-Type: text/plain; charset=UTF-8
-Content-Transfer-Encoding: 8bit
-
-The compiler.h header contains a macro that defines __unused. When
-building against uClibc this collides with uClibc_stdio.h:
-
-In file included from /usr/include/stdio.h:71:0,
-                 from libpdbg/fake.c:17:
-/usr/include/bits/uClibc_stdio.h:149:16: error: expected identifier or ?(? before ?;? token
-  void *__unused;    /* Placeholder for codeset binding. */
-                ^
-
-As it is unused in pdbg, remove it.
-
-Signed-off-by: Joel Stanley <[email protected]>
----
- libpdbg/compiler.h | 1 -
- 1 file changed, 1 deletion(-)
-
-diff --git a/libpdbg/compiler.h b/libpdbg/compiler.h
-index 35bf16525761..86bd9673ac36 100644
---- a/libpdbg/compiler.h
-+++ b/libpdbg/compiler.h
-@@ -24,7 +24,6 @@
- /* Macros for various compiler bits and pieces */
- #define __packed		__attribute__((packed))
- #define __align(x)		__attribute__((__aligned__(x)))
--#define __unused		__attribute__((unused))
- #define __used			__attribute__((used))
- #define __section(x)		__attribute__((__section__(x)))
- #define __noreturn		__attribute__((noreturn))
--- 
-2.14.1
-
package/pdbg/pdbg.hash +1 -1
index 2aec71817770..6fef1280847a 100644
@@ -1,2 +1,2 @@
 # Locally calculated
-sha256 e0b81fc65eb83692c5c07d7ae109882cefebf663444b7ea804d0544451c1a72f pdbg-77158819158d1d7053a737ac090d04fdfbfe9265.tar.gz
+sha256 e9143607b0d15693ace9f50b27f931020127a9d605c45f8609f1fe8608be7949  pdbg-527fe54e1c95e031efd3db008c3f4e096cb3ea58.tar.gz
package/pdbg/pdbg.mk +1 -1
index 70adb0a166d1..f16a392aa6b1 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-PDBG_VERSION = 77158819158d1d7053a737ac090d04fdfbfe9265
+PDBG_VERSION = 527fe54e1c95e031efd3db008c3f4e096cb3ea58
 PDBG_SITE = $(call github,open-power,pdbg,$(PDBG_VERSION))
 PDBG_LICENSE = Apache-2.0
 PDBG_LICENSE_FILES = COPYING
Signature · 1 line
2.14.1
#3 lore raw

cover pdbg updates

In reply to Joel Stanley

Hello,

Quoted 3 lines · Joel Stanley

Joel Stanley (2):
pdbg: update help text
pdbg: Bump to latest upstream version

Both applied to master. However, on the second patch, you had forgotten to include references to the autobuilder failures, so I've done that.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com