mfd: sm501: Add NULL check on devm_kzalloc return value

PATCH In review Gustavo A. R. Silva 2 participants 3 messages Nov 23, 2017 – Nov 27, 2017 Multifunction devices (MFD)

lore

Share & tools

lore

Gustavo A. R. Silva

author

2017-11-23 03:50 UTC #0 lore raw

PATCH 1/1 mfd: sm501: Add NULL check on devm_kzalloc return value

Check return value from call to devm_kzalloc() in order to prevent a NULL pointer dereference.

This issue was detected with the help of Coccinelle.

Fixes b2e63555592f ("i2c: gpio: Convert to use descriptors")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/mfd/sm501.c | 3 +++
 1 file changed, 3 insertions(+)

drivers/mfd/sm501.c +3 -0

index ad77416..08bee41 100644
@@ -1144,6 +1144,9 @@ static int sm501_register_gpio_i2c_instance(struct sm501_devdata *sm,
 	lookup = devm_kzalloc(&pdev->dev,
 			      sizeof(*lookup) + 3 * sizeof(struct gpiod_lookup),
 			      GFP_KERNEL);
+	if (!lookup)
+		return -ENOMEM;
+
 	lookup->dev_id = "i2c-gpio";
 	if (iic->pin_sda < 32)
 		lookup->table[0].chip_label = "SM501-LOW";

Signature · 1 line

2.7.4

Linus Walleij

Acked-by on v1 1/1

2017-11-23 09:38 UTC #1 lore raw

Quoted 7 lines · Gustavo A. R. Silva

Check return value from call to devm_kzalloc() in order to prevent a NULL pointer dereference.
This issue was detected with the help of Coccinelle.
Fixes b2e63555592f ("i2c: gpio: Convert to use descriptors")
Signed-off-by Gustavo A. R. Silva <[email protected]>

Acked-by Linus Walleij <[email protected]>

Yours,
Linus Walleij

Gustavo A. R. Silva

author

2017-11-27 12:58 UTC #2 lore raw

Quoted 12 lines · Linus Walleij

Quoted 7 lines · Gustavo A. R. Silva
Check return value from call to devm_kzalloc() in order to prevent a NULL pointer dereference.
This issue was detected with the help of Coccinelle.
Fixes b2e63555592f ("i2c: gpio: Convert to use descriptors")
Signed-off-by Gustavo A. R. Silva <[email protected]>
Acked-by Linus Walleij <[email protected]>

Thank you, Linus.

--
Gustavo A. R. Silva