Skip to contentSkip to conversation

brcmfmac: Avoid build error with make W=1

PATCH In review Andy Shevchenko 3 participants 4 messages Nov 23, 2017 – Dec 7, 2017 1 message not in the archive

Subsystems (3)
Networking Network drivers Broadcom BRCM80211 IEEE802.11 wireless drivers
lore
Share & tools
lore

Andy Shevchenko

author
#0 lore raw

PATCH 1/1 brcmfmac: Avoid build error with make W=1

When I run make W=1 on gcc (Debian 7.2.0-16) 7.2.0 I got an error for the first run, all next ones are okay.

CC [M] drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.o
drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2078: error: Cannot parse struct or union! scripts/Makefile.build:310: recipe for target 'drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.o' failed

Seems like something happened with W=1 and wrong kernel doc format. As a quick fix remove dubious /** in the code.

Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c +1 -1
index e3495ea95553..870e00cea29c 100644
@@ -2070,7 +2070,7 @@ static int brcmf_sdio_txpkt_hdalign(struct brcmf_sdio *bus, struct sk_buff *pkt)
 	return head_pad;
 }
 
-/**
+/*
  * struct brcmf_skbuff_cb reserves first two bytes in sk_buff::cb for
  * bus layer usage.
  */
Signature · 1 line
2.15.0
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Andy Shevchenko

When I run make W=1 on gcc (Debian 7.2.0-16) 7.2.0 I got an error for the first run, all next ones are okay.

CC [M] drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.o
drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2078: error: Cannot parse struct or union! scripts/Makefile.build:310: recipe for target 'drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.o' failed

Seems like something happened with W=1 and wrong kernel doc format. As a quick fix remove dubious /** in the code.

Acked-by Arend van Spriel <[email protected]>
Quoted 4 lines
Signed-off-by Andy Shevchenko <[email protected]>
---
  drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

A message that is not in the archive (sent off-list or not yet received): 20171123155704.44878-1-andriy.shevchenko-VuQAYsv1563Yd54FQh9/[email protected]

#3 lore raw
Quoted 7 lines · Andy Shevchenko

When I run make W=1 on gcc (Debian 7.2.0-16) 7.2.0 I got an error for the first run, all next ones are okay.

CC [M] drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.o
drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2078: error: Cannot parse struct or union! scripts/Makefile.build:310: recipe for target 'drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.o' failed

Quoted 5 lines

Seems like something happened with W=1 and wrong kernel doc format. As a quick fix remove dubious /** in the code.

Signed-off-by Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/[email protected]>
Acked-by Arend van Spriel <arend.vanspriel-dY08KVG/lbpWk0Htik3J/[email protected]>

I'll queue this to v4.15.

Signature · 3 lines
https://patchwork.kernel.org/patch/10073021/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#4 lore raw
In reply to a message not in the archive
Quoted 7 lines · Andy Shevchenko

When I run make W=1 on gcc (Debian 7.2.0-16) 7.2.0 I got an error for the first run, all next ones are okay.

CC [M] drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.o
drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2078: error: Cannot parse struct or union! scripts/Makefile.build:310: recipe for target 'drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.o' failed

Quoted 5 lines

Seems like something happened with W=1 and wrong kernel doc format. As a quick fix remove dubious /** in the code.

Signed-off-by Andy Shevchenko <[email protected]>
Acked-by Arend van Spriel <[email protected]>

Patch applied to wireless-drivers.git, thanks.

51ef7925e106 brcmfmac: Avoid build error with make W=1

Signature · 3 lines
https://patchwork.kernel.org/patch/10073021/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches