Skip to contentSkip to conversation

ARM: dts: efm32: Add generic compatible string for I2C EEPROM

PATCH RESEND Applied Javier Martinez Canillas 3 participants 8 messages Nov 24, 2017 – Dec 21, 2017 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/4 ARM: dts: efm32: Add generic compatible string for I2C EEPROM

The at24 driver allows to register I2C EEPROM chips using different vendor and devices, but the I2C subsystem does not take the vendor into account when matching using the I2C table since it only has device entries.

But when matching using an OF table, both the vendor and device has to be taken into account so the driver defines only a set of compatible strings using the "atmel" vendor as a generic fallback for compatible I2C devices.

So add this generic fallback to the device node compatible string to make the device to match the driver using the OF device ID table.

---

 arch/arm/boot/dts/efm32gg-dk3750.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/efm32gg-dk3750.dts +1 -1
index c9f3ea29cf9e..adfa559a488b 100644
@@ -37,7 +37,7 @@
 			};
 
 			eeprom at 50 {
-				compatible = "microchip,24c02";
+				compatible = "microchip,24c02", "atmel,24c02";
 				reg = <0x50>;
 				pagesize = <16>;
 			};
Signature · 1 line
2.14.3
#1 lore raw

PATCH RESEND 2/4 ARM: dts: keystone: Add generic compatible string for I2C EEPROM

The at24 driver allows to register I2C EEPROM chips using different vendor and devices, but the I2C subsystem does not take the vendor into account when matching using the I2C table since it only has device entries.

But when matching using an OF table, both the vendor and device has to be taken into account so the driver defines only a set of compatible strings using the "atmel" vendor as a generic fallback for compatible I2C devices.

So add this generic fallback to the device node compatible string to make the device to match the driver using the OF device ID table.

---

 arch/arm/boot/dts/keystone-k2e-evm.dts  | 2 +-
 arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +-
 arch/arm/boot/dts/keystone-k2l-evm.dts  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/keystone-k2e-evm.dts +1 -1
index f1f32c54e72f..2c59f4cb3b44 100644
@@ -82,7 +82,7 @@
 
 &i2c0 {
 	dtt at 50 {
-		compatible = "at,24c1024";
+		compatible = "atmel,24c1024";
 		reg = <0x50>;
 	};
 };
arch/arm/boot/dts/keystone-k2hk-evm.dts +1 -1
index 6dd13b98aaba..13759db99d81 100644
@@ -158,7 +158,7 @@
 
 &i2c0 {
 	dtt at 50 {
-		compatible = "at,24c1024";
+		compatible = "atmel,24c1024";
 		reg = <0x50>;
 	};
 };
arch/arm/boot/dts/keystone-k2l-evm.dts +1 -1
index 528667618db4..e6de1ae33c73 100644
@@ -55,7 +55,7 @@
 
 &i2c0 {
 	dtt at 50 {
-		compatible = "at,24c1024";
+		compatible = "atmel,24c1024";
 		reg = <0x50>;
 	};
 };
Signature · 1 line
2.14.3
#2 lore raw

Re: [RESEND PATCH 2/4] ARM: dts: keystone: Add generic compatible string for I2C EEPROM

Quoted 8 lines · Javier Martinez Canillas

The at24 driver allows to register I2C EEPROM chips using different vendor and devices, but the I2C subsystem does not take the vendor into account when matching using the I2C table since it only has device entries.

But when matching using an OF table, both the vendor and device has to be taken into account so the driver defines only a set of compatible strings using the "atmel" vendor as a generic fallback for compatible I2C devices.

Quoted 6 lines

So add this generic fallback to the device node compatible string to make the device to match the driver using the OF device ID table.

---

Applied

#3 lore raw

PATCH RESEND 3/4 ARM: dts: lpc18xx: Add generic compatible string for I2C EEPROM

In reply to Javier Martinez Canillas

The at24 driver allows to register I2C EEPROM chips using different vendor and devices, but the I2C subsystem does not take the vendor into account when matching using the I2C table since it only has device entries.

But when matching using an OF table, both the vendor and device has to be taken into account so the driver defines only a set of compatible strings using the "atmel" vendor as a generic fallback for compatible I2C devices.

So add this generic fallback to the device node compatible string to make the device to match the driver using the OF device ID table.

---

 arch/arm/boot/dts/lpc4337-ciaa.dts          | 6 +++---
 arch/arm/boot/dts/lpc4350-hitex-eval.dts    | 2 +-
 arch/arm/boot/dts/lpc4357-ea4357-devkit.dts | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)
arch/arm/boot/dts/lpc4337-ciaa.dts +3 -3
index 7c16d639a1b4..beddaba85393 100644
@@ -174,17 +174,17 @@
 	clock-frequency = <400000>;
 
 	eeprom at 50 {
-		compatible = "microchip,24c512";
+		compatible = "microchip,24c512", "atmel,24c512";
 		reg = <0x50>;
 	};
 
 	eeprom at 51 {
-		compatible = "microchip,24c02";
+		compatible = "microchip,24c02", "atmel,24c02";
 		reg = <0x51>;
 	};
 
 	eeprom at 54 {
-		compatible = "microchip,24c512";
+		compatible = "microchip,24c512", "atmel,24c512";
 		reg = <0x54>;
 	};
 };
arch/arm/boot/dts/lpc4350-hitex-eval.dts +1 -1
index 874c75d44013..8b973f537d3a 100644
@@ -429,7 +429,7 @@
 	};
 
 	eeprom at 50 {
-		compatible = "nxp,24c02";
+		compatible = "nxp,24c02", "atmel,24c02";
 		reg = <0x50>;
 	};
 
arch/arm/boot/dts/lpc4357-ea4357-devkit.dts +1 -1
index 9b5fad622522..02b23fa29d75 100644
@@ -490,7 +490,7 @@
 	};
 
 	eeprom at 57 {
-		compatible = "microchip,24c64";
+		compatible = "microchip,24c64", "atmel,24c64";
 		reg = <0x57>;
 	};
 };
Signature · 1 line
2.14.3
#4 lore raw

Re: [RESEND PATCH 3/4] ARM: dts: lpc18xx: Add generic compatible string for I2C EEPROM

Quoted 4 lines · Javier Martinez Canillas

The at24 driver allows to register I2C EEPROM chips using different vendor and devices, but the I2C subsystem does not take the vendor into account when matching using the I2C table since it only has device entries.

Quoted 8 lines

But when matching using an OF table, both the vendor and device has to be taken into account so the driver defines only a set of compatible strings using the "atmel" vendor as a generic fallback for compatible I2C devices.

So add this generic fallback to the device node compatible string to make the device to match the driver using the OF device ID table.

Applied, thanks

Arnd

#5 lore raw

PATCH RESEND 4/4 ARM: dts: socfpga: Add generic compatible string for I2C EEPROM

In reply to Javier Martinez Canillas

The at24 driver allows to register I2C EEPROM chips using different vendor and devices, but the I2C subsystem does not take the vendor into account when matching using the I2C table since it only has device entries.

But when matching using an OF table, both the vendor and device has to be taken into account so the driver defines only a set of compatible strings using the "atmel" vendor as a generic fallback for compatible I2C devices.

So add this generic fallback to the device node compatible string to make the device to match the driver using the OF device ID table.

---

 arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts +1 -1
index 655fe87e272d..2459d133f1be 100644
@@ -237,7 +237,7 @@
 	clock-frequency = <100000>;
 
 	at24 at 50 {
-		compatible = "at24,24c02";
+		compatible = "atmel,24c02";
 		pagesize = <8>;
 		reg = <0x50>;
 	};
Signature · 1 line
2.14.3
#6 lore raw

Re: [RESEND PATCH 4/4] ARM: dts: socfpga: Add generic compatible string for I2C EEPROM

Quoted 4 lines · Javier Martinez Canillas

The at24 driver allows to register I2C EEPROM chips using different vendor and devices, but the I2C subsystem does not take the vendor into account when matching using the I2C table since it only has device entries.

Quoted 8 lines

But when matching using an OF table, both the vendor and device has to be taken into account so the driver defines only a set of compatible strings using the "atmel" vendor as a generic fallback for compatible I2C devices.

So add this generic fallback to the device node compatible string to make the device to match the driver using the OF device ID table.

Applied, thanks!

Arnd

#7 lore raw
In reply to Javier Martinez Canillas
Quoted 4 lines · Javier Martinez Canillas

The at24 driver allows to register I2C EEPROM chips using different vendor and devices, but the I2C subsystem does not take the vendor into account when matching using the I2C table since it only has device entries.

Quoted 8 lines

But when matching using an OF table, both the vendor and device has to be taken into account so the driver defines only a set of compatible strings using the "atmel" vendor as a generic fallback for compatible I2C devices.

So add this generic fallback to the device node compatible string to make the device to match the driver using the OF device ID table.

Applied to next/dt, thanks

Arnd