Skip to contentSkip to conversation

arm64: dts: renesas: initial V3MSK board device tree

PATCH New Sergei Shtylyov 3 participants 5 messages Nov 24, 2017 – Dec 4, 2017

Subsystems (2)
Device tree bindings Arm/RISC-V/Renesas architecture
lore
Share & tools
lore

Sergei Shtylyov

author
#0 lore raw

PATCH 1/2 arm64: dts: renesas: initial V3MSK board device tree

Add the initial device tree for the V3M Starter Kit board. The board has 1 debug serial port (SCIF0); include support for it, so that the serial console can work.

Based on the original (and large) patch by Vladimir Barinov.

Signed-off-by Vladimir Barinov <[email protected]>
Signed-off-by Sergei Shtylyov <[email protected]>
---
 arch/arm64/boot/dts/renesas/Makefile           |    2 -
 arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts |   44 +++++++++++++++++++++++++
 2 files changed, 45 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/renesas/Makefile +1 -1
Index: renesas/arch/arm64/boot/dts/renesas/Makefile
===================================================================
@@ -7,7 +7,7 @@ dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-es
 dtb-$(CONFIG_ARCH_R8A7796) += r8a7796-salvator-x.dtb r8a7796-m3ulcb.dtb
 dtb-$(CONFIG_ARCH_R8A7796) += r8a7796-m3ulcb-kf.dtb
 dtb-$(CONFIG_ARCH_R8A7796) += r8a7796-salvator-xs.dtb
-dtb-$(CONFIG_ARCH_R8A77970) += r8a77970-eagle.dtb
+dtb-$(CONFIG_ARCH_R8A77970) += r8a77970-eagle.dtb r8a77970-v3msk.dtb
 dtb-$(CONFIG_ARCH_R8A77995) += r8a77995-draak.dtb
 
 always		:= $(dtb-y)
arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts new file +44 -0

44 lines not on this page · raw message

#1 lore raw

PATCH 1/2 arm64: dts: renesas: initial V3MSK board device tree

Quoted 45 lines · Sergei Shtylyov

Add the initial device tree for the V3M Starter Kit board. The board has 1 debug serial port (SCIF0); include support for it, so that the serial console can work.

Based on the original (and large) patch by Vladimir Barinov.

Signed-off-by Vladimir Barinov <[email protected]>
Signed-off-by Sergei Shtylyov <[email protected]>
---
 arch/arm64/boot/dts/renesas/Makefile           |    2 -
 arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts |   44 +++++++++++++++++++++++++
 2 files changed, 45 insertions(+), 1 deletion(-)

Index: renesas/arch/arm64/boot/dts/renesas/Makefile
===================================================================

arch/arm64/boot/dts/renesas/Makefile +1 -1
@@ -7,7 +7,7 @@ dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-es
 dtb-$(CONFIG_ARCH_R8A7796) += r8a7796-salvator-x.dtb r8a7796-m3ulcb.dtb
 dtb-$(CONFIG_ARCH_R8A7796) += r8a7796-m3ulcb-kf.dtb
 dtb-$(CONFIG_ARCH_R8A7796) += r8a7796-salvator-xs.dtb
-dtb-$(CONFIG_ARCH_R8A77970) += r8a77970-eagle.dtb
+dtb-$(CONFIG_ARCH_R8A77970) += r8a77970-eagle.dtb r8a77970-v3msk.dtb
 dtb-$(CONFIG_ARCH_R8A77995) += r8a77995-draak.dtb
 
 always		:= $(dtb-y)

Index: renesas/arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts
===================================================================

arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts new file +13 -0
@@ -0,0 +1,44 @@
+/*
+ * Device Tree Source for the V3M Starter Kit board
+ *
+ * Copyright (C) 2017 Renesas Electronics Corp.
+ * Copyright (C) 2017 Cogent Embedded, Inc.
+ *
+ * This file is licensed under the terms of the GNU General Public License
+ * version 2.  This program is licensed "as is" without any warranty of any
+ * kind, whether express or implied.
+ */
+
+/dts-v1/;
+#include "r8a77970.dtsi"

arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts line 23

Quoted 10 lines
arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts new file +10 -0
+
+/ {
+	model = "Renesas V3M Starter Kit board";
+	compatible = "renesas,v3msk", "renesas,r8a77970";
+
+	aliases {
+		serial0 = &scif0;
+	};
+
+	chosen {

For consistency with other Renesas boards I would like to request the following be added here:

		bootargs = "ignore_loglevel rw";
Quoted 22 lines
arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts new file +21 -0
+		stdout-path = "serial0:115200n8";
+	};
+
+	memory at 48000000 {
+		device_type = "memory";
+		/* first 128MB is reserved for secure area. */
+		reg = <0x0 0x48000000 0x0 0x38000000>;
+	};
+};
+
+&extal_clk {
+	clock-frequency = <16666666>;
+};
+
+&extalr_clk {
+	clock-frequency = <32768>;
+};
+
+&scif0 {
+	status = "okay";
+};
author
#2 lore raw

PATCH 1/2 arm64: dts: renesas: initial V3MSK board device tree

Hello!

Quoted 11 lines · Simon Horman
Quoted 11 lines

Add the initial device tree for the V3M Starter Kit board. The board has 1 debug serial port (SCIF0); include support for it, so that the serial console can work.

Based on the original (and large) patch by Vladimir Barinov.

Signed-off-by Vladimir Barinov <[email protected]>
Signed-off-by Sergei Shtylyov <[email protected]>
---
  arch/arm64/boot/dts/renesas/Makefile           |    2 -

[...]

Quoted 32 lines
Quoted 18 lines

Index: renesas/arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts
===================================================================

arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts new file +13 -0
@@ -0,0 +1,44 @@
+/*
+ * Device Tree Source for the V3M Starter Kit board
+ *
+ * Copyright (C) 2017 Renesas Electronics Corp.
+ * Copyright (C) 2017 Cogent Embedded, Inc.
+ *
+ * This file is licensed under the terms of the GNU General Public License
+ * version 2.  This program is licensed "as is" without any warranty of any
+ * kind, whether express or implied.
+ */
+
+/dts-v1/;
+#include "r8a77970.dtsi"

arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts line 23

Quoted 10 lines
arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts new file +10 -0
+
+/ {
+	model = "Renesas V3M Starter Kit board";
+	compatible = "renesas,v3msk", "renesas,r8a77970";
+
+	aliases {
+		serial0 = &scif0;
+	};
+
+	chosen {

For consistency with other Renesas boards I would like to request the following be added here:

Quoted 1 line
		bootargs = "ignore_loglevel rw";

There's currently no consistency as ulcb.dtsi doesn't seem to specify
"bootargs" prop at all. Moreover, this prop seems to be ignored by ARM64 kernel -- I can only specify "bootargs" in U-Boot....

MBR, Sergei

#3 lore raw

PATCH 1/2 arm64: dts: renesas: initial V3MSK board device tree

Quoted 48 lines · Sergei Shtylyov

Hello!

Quoted 11 lines · Simon Horman
Quoted 11 lines

Add the initial device tree for the V3M Starter Kit board. The board has 1 debug serial port (SCIF0); include support for it, so that the serial console can work.

Based on the original (and large) patch by Vladimir Barinov.

Signed-off-by Vladimir Barinov <[email protected]>
Signed-off-by Sergei Shtylyov <[email protected]>
---
  arch/arm64/boot/dts/renesas/Makefile           |    2 -

[...]

Quoted 32 lines
Quoted 18 lines

Index: renesas/arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts
===================================================================

arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts new file +13 -0
@@ -0,0 +1,44 @@
+/*
+ * Device Tree Source for the V3M Starter Kit board
+ *
+ * Copyright (C) 2017 Renesas Electronics Corp.
+ * Copyright (C) 2017 Cogent Embedded, Inc.
+ *
+ * This file is licensed under the terms of the GNU General Public License
+ * version 2.  This program is licensed "as is" without any warranty of any
+ * kind, whether express or implied.
+ */
+
+/dts-v1/;
+#include "r8a77970.dtsi"

arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts line 23

Quoted 10 lines
arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts new file +10 -0
+
+/ {
+	model = "Renesas V3M Starter Kit board";
+	compatible = "renesas,v3msk", "renesas,r8a77970";
+
+	aliases {
+		serial0 = &scif0;
+	};
+
+	chosen {

For consistency with other Renesas boards I would like to request the following be added here:

Quoted 5 lines
Quoted 1 line
		bootargs = "ignore_loglevel rw";

There's currently no consistency as ulcb.dtsi doesn't seem to specify
"bootargs" prop at all. Moreover, this prop seems to be ignored by ARM64 kernel -- I can only specify "bootargs" in U-Boot....

I had assumed that ulcb.dtsi should be updated in this regards but I now see that bootargs does not seem to have any effect (on r8a7796/salvator-x) as you suggest.

I have applied this and the following patch.

#4 lore raw

PATCH 1/2 arm64: dts: renesas: initial V3MSK board device tree

In reply to Sergei Shtylyov
Quoted 8 lines · Sergei Shtylyov

Add the initial device tree for the V3M Starter Kit board. The board has 1 debug serial port (SCIF0); include support for it, so that the serial console can work.

Based on the original (and large) patch by Vladimir Barinov.

Signed-off-by Vladimir Barinov <[email protected]>
Signed-off-by Sergei Shtylyov <[email protected]>
Reviewed-by Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds