Skip to contentSkip to conversation

support/download: svn non-interactive in BR2_SVN

PATCH New Sam Voss 3 participants 3 messages Nov 17, 2017 – Nov 26, 2017

lore
Share & tools
lore

Sam Voss

author
#0 lore raw

PATCH 1/1 support/download: svn non-interactive in BR2_SVN

Instead of overriding the _svn command and injecting --non-interactive, change the default value of BR2_SVN to include this flag so the end user can choose not to use the flag.

This change helps users behind corporate system rules which may not allow them to locally cache credentials and require interactive mode.

[Originally implemented by]
CC "Yann E. MORIN" <[email protected]>
---
 Config.in            | 2 +-
 support/download/svn | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Config.in +1 -1
index 90f793a..d192995 100644
@@ -106,7 +106,7 @@ config BR2_WGET
 
 config BR2_SVN
 	string "Subversion (svn) command"
-	default "svn"
+	default "svn --non-interactive"
 
 config BR2_BZR
 	string "Bazaar (bzr) command"
support/download/svn +1 -1
index ee799f4..ad84a39 100755
@@ -33,7 +33,7 @@ _svn() {
     eval ${SVN} "${@}"
 }
 
-_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
+_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
 
 # If this is a HEAD revision, export the exact version
 # that was checked out.
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 support/download: svn non-interactive in BR2_SVN

Sam, All,

On 2017-11-17 12:50 -0600, Sam Voss spake thusly:

Quoted 11 lines

Instead of overriding the _svn command and injecting --non-interactive, change the default value of BR2_SVN to include this flag so the end user can choose not to use the flag.

This change helps users behind corporate system rules which may not allow them to locally cache credentials and require interactive mode.

[Originally implemented by]
CC "Yann E. MORIN" <[email protected]>

Thomas, since this is my code: ;-)

Regards,
Yann E. MORIN.

Quoted 34 lines
---
 Config.in            | 2 +-
 support/download/svn | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Config.in +1 -1
index 90f793a..d192995 100644
@@ -106,7 +106,7 @@ config BR2_WGET
 
 config BR2_SVN
 	string "Subversion (svn) command"
-	default "svn"
+	default "svn --non-interactive"
 
 config BR2_BZR
 	string "Bazaar (bzr) command"
support/download/svn +1 -1
index ee799f4..ad84a39 100755
@@ -33,7 +33,7 @@ _svn() {
     eval ${SVN} "${@}"
 }
 
-_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
+_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
 
 # If this is a HEAD revision, export the exact version
 # that was checked out.
Signature · 1 line
1.9.1
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 support/download: svn non-interactive in BR2_SVN

In reply to Sam Voss

Hello,

Quoted 7 lines · Sam Voss

Instead of overriding the _svn command and injecting --non-interactive, change the default value of BR2_SVN to include this flag so the end user can choose not to use the flag.

This change helps users behind corporate system rules which may not allow them to locally cache credentials and require interactive mode.

Quoted 8 lines
[Originally implemented by]
CC "Yann E. MORIN" <[email protected]>
---
 Config.in            | 2 +-
 support/download/svn | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

I hesitated a bit between master and next to apply this patch. But since this is basically fixing/adjusting a change that is in master, I opted for merging that in master so that we don't change two times the behavior in two consecutive releases.

So: applied to master. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com