Skip to contentSkip to conversation

drm: drm_vblank_cleanup: WARN when refcount > 0

PATCH New PrasannaKumar Muralidharan 2 participants 2 messages Nov 26, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 drm: drm_vblank_cleanup: WARN when refcount > 0

Warn when refcount is > 0 in drm_vblank_cleanup.

---
Changes in v4:
* Print refcount value.

Changes in v3:
* Dropped i915 patch that is used for testing this.

No changes in v2.

 drivers/gpu/drm/drm_vblank.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/gpu/drm/drm_vblank.c +7 -1
index 3e61aeb..062cc17 100644
@@ -403,9 +403,15 @@ void drm_vblank_cleanup(struct drm_device *dev)
 		return;
 
 	for (pipe = 0; pipe < dev->num_crtcs; pipe++) {
+		unsigned int refcount;
 		struct drm_vblank_crtc *vblank = &dev->vblank[pipe];
 
-		WARN_ON(atomic_read(&vblank->refcount) > 0);
+		refcount = atomic_read(&vblank->refcount);
+		if (refcount > 0) {
+			DRM_DEBUG("vblank refcount: %u in %s\n", refcount,
+				   __func__);
+			WARN_ON(refcount > 0);
+		}
 
 		WARN_ON(READ_ONCE(vblank->enabled) &&
 			drm_core_check_feature(dev, DRIVER_MODESET));
Signature · 6 lines
2.10.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✗ Fi.CI.BAT: failure for drm: drm_vblank_cleanup: WARN when refcount > 0 (rev3)

== Series Details ==

== Series Details ==

Series: drm: drm_vblank_cleanup: WARN when refcount > 0 (rev3)
URL : https://patchwork.freedesktop.org/series/32648/
State : failure

== Summary ==

Applying: drm: drm_vblank_cleanup: WARN when refcount > 0 Patch failed at 0001 drm: drm_vblank_cleanup: WARN when refcount > 0

Current HEAD:
commit 71c6106a8fb5a41227539b9afb050d76eaebf9f5

Author: Chris Wilson <[email protected]>
Date:   Sun Nov 26 12:47:30 2017 +0000
    drm-tip: 2017y-11m-26d-12h-47m-01s UTC integration manifest

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx